On Mon, 3 Jul 2023 21:22:36 GMT, Oliver Kopp wrote:
>> `plugins.properties` needs to be updated to show the option added for this
>> plugin.
>>
>> BTW, the current argument described in the usage is out-dated which needs
>> update.
>>
>> system-modules.argument=retainModuleTarget
>
> Added
On Mon, 3 Jul 2023 17:09:35 GMT, Mandy Chung wrote:
>> What I meant here is to change the `configure` method to allow the plugin to
>> take an argument for example
>>
>> --system-modules batch-size=100
>>
>>
>> This argument is optional. If not specified, the default value is 75.
>>
On Sat, 1 Jul 2023 10:07:15 GMT, Oliver Kopp wrote:
>> test/jdk/tools/jlink/JLink100Modules.java line 40:
>>
>>> 38: * @library ../lib
>>> 39: * @modules java.base/jdk.internal.jimage
>>> 40: * jdk.jdeps/com.sun.tools.classfile
>>
>> I guess you copied this from other jlink tests.
On Thu, 29 Jun 2023 20:43:59 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
> line 669:
>
>
On Mon, 3 Jul 2023 17:07:16 GMT, Mandy Chung wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 669:
>>
>>> 667: */
>>> 668: private void genModuleDescriptorsMethod(ClassBuilder clb) {
>>> 669: if (moduleInfos.siz
On Mon, 3 Jul 2023 16:21:22 GMT, Mandy Chung wrote:
>> I assume the "old" comments were too detailed. I removed them at
>> [JabRef/jdk@`23bbc0c`
>> (#2)](https://github.com/JabRef/jdk/pull/2/commits/23bbc0ce0c8fd8a4cd689c0260c5fbcb91b20046)
>> to have the code reviewable. I can readd some of t
On Sat, 1 Jul 2023 10:38:05 GMT, Oliver Kopp wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 691:
>>
>>> 689: }
>>> 690:
>>> 691: List> splitModuleInfos = new
>>> ArrayList<>();
>>
>> Please add the comments to d
On Thu, 29 Jun 2023 20:58:53 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
> line 691:
>
>
On Thu, 29 Jun 2023 20:26:58 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> test/jdk/tools/jlink/JLink100Modules.java line 40:
>
>> 38: * @library ../lib
>> 39: * @modules java
On Thu, 29 Jun 2023 19:15:15 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
On Thu, 29 Jun 2023 20:34:58 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix threshold
>
> test/jdk/tools/jlink/JLink100Modules.java line 47:
>
>> 45: * jdk.compiler
>> 46: * @build
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Tue, 3 Jan 2023 16:17:41 GMT, Alan Bateman wrote:
>>> Would it be possible to paste in a summary on the VerifyError with the
>>> previous iteration?
>>
>> Isn't this https://github.com/openjdk/jdk/pull/10704#issuecomment-1286106503?
>>
>> Type top (current frame, locals[15]) is not assi
On Thu, 8 Dec 2022 07:41:22 GMT, Oliver Kopp wrote:
>> Would it be possible to paste in a summary on the VerifyError with the
>> previous iteration? If I read the latest update then the limit per helper
>> method has been bump to avoid it, is that right?
>
>> Would it be possible to paste in a
On Thu, 8 Dec 2022 07:41:22 GMT, Oliver Kopp wrote:
>> Would it be possible to paste in a summary on the VerifyError with the
>> previous iteration? If I read the latest update then the limit per helper
>> method has been bump to avoid it, is that right?
>
>> Would it be possible to paste in a
On Thu, 8 Dec 2022 07:41:22 GMT, Oliver Kopp wrote:
> Yes. Then, the compiler still works - and we can try to debug using the test
> case (yet to be finalized).
Okay, so maybe the PR should be returned to draft until it is ready.
-
PR: https://git.openjdk.org/jdk/pull/10704
On Tue, 6 Dec 2022 16:46:02 GMT, Alan Bateman wrote:
> Would it be possible to paste in a summary on the VerifyError with the
> previous iteration?
Isn't this https://github.com/openjdk/jdk/pull/10704#issuecomment-1286106503?
Type top (current frame, locals[15]) is not assignable to refere
On Mon, 5 Dec 2022 21:38:20 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to spl
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
19 matches
Mail list logo
