On Wed, 21 Sep 2022 09:23:31 GMT, Alan Bateman wrote:
> > Assuming we are set with the other changes, did you want to add the
> > following paragraph (or similar) at line 58 to make it clear that if the
> > Manifest is not found, then the JarEntry attributes will not be available:
>
> This is
On Tue, 20 Sep 2022 18:08:21 GMT, Lance Andersen wrote:
> Assuming we are set with the other changes, did you want to add the following
> paragraph (or similar) at line 58 to make it clear that if the Manifest is
> not found, then the JarEntry attributes will not be available:
This is somethin
On Tue, 20 Sep 2022 17:47:03 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
>> It is worth noting that with this updat
On Tue, 20 Sep 2022 17:53:27 GMT, Sean Mullan wrote:
> Now that this API has a section about signed JARs, I think it is very
> important to include the following sentences which are copied from `JarFile`:
>
> "Please note that the verification process does not include validating the
> signer's
On Tue, 20 Sep 2022 17:47:03 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
>> It is worth noting that with this updat
> Please review this PR which updates the JarInputStream class description to
> clarify when the Manifest is accessible via JarInputStream::getManifest and
> JarInputStream::get[Jar]Entry.
>
> It is worth noting that with this update, we are finally documenting
> behavior that dates back to w
