Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code [v4]

2022-10-06 Thread Lance Andersen
On Thu, 6 Oct 2022 20:43:30 GMT, Justin Lu wrote: >> Problem: Outdated doc does not match code. Claimed to throw exception and >> compared to Long method. >> Fix: Update doc to match code, compared to Double.parseDouble() accordingly. > > Justin Lu has updated the pull request incrementally with

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code [v4]

2022-10-06 Thread Justin Lu
> Problem: Outdated doc does not match code. Claimed to throw exception and > compared to Long method. > Fix: Update doc to match code, compared to Double.parseDouble() accordingly. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Refact

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code [v3]

2022-10-06 Thread Justin Lu
On Thu, 6 Oct 2022 10:58:36 GMT, Lance Andersen wrote: > Looks fine Justin. > > Please make sure the comments are < 80 characters and if they are longer > break them into two lines as they seem like they might be long @LanceAndersen Made the change, thanks Lance - PR: https://git

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code [v3]

2022-10-06 Thread Lance Andersen
On Wed, 5 Oct 2022 21:26:09 GMT, Justin Lu wrote: >> Problem: Outdated doc does not match code. Claimed to throw exception and >> compared to Long method. >> Fix: Update doc to match code, compared to Double.parseDouble() accordingly. > > Justin Lu has updated the pull request incrementally with

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code [v3]

2022-10-05 Thread Joe Darcy
On Wed, 5 Oct 2022 21:26:09 GMT, Justin Lu wrote: >> Problem: Outdated doc does not match code. Claimed to throw exception and >> compared to Long method. >> Fix: Update doc to match code, compared to Double.parseDouble() accordingly. > > Justin Lu has updated the pull request incrementally with

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code [v3]

2022-10-05 Thread Justin Lu
> Problem: Outdated doc does not match code. Claimed to throw exception and > compared to Long method. > Fix: Update doc to match code, compared to Double.parseDouble() accordingly. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Update

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code [v2]

2022-10-05 Thread Justin Lu
On Wed, 5 Oct 2022 20:57:12 GMT, Lance Andersen wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update doc code > > src/java.base/share/classes/java/text/DigitList.java line 198: > >> 196: >> 197: /** >> 198:

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code [v2]

2022-10-05 Thread Lance Andersen
On Wed, 5 Oct 2022 20:49:52 GMT, Justin Lu wrote: >> Problem: Outdated doc does not match code. Claimed to throw exception and >> compared to Long method. >> Fix: Update doc to match code, compared to Double.parseDouble() accordingly. > > Justin Lu has updated the pull request incrementally with

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code [v2]

2022-10-05 Thread Justin Lu
> Problem: Outdated doc does not match code. Claimed to throw exception and > compared to Long method. > Fix: Update doc to match code, compared to Double.parseDouble() accordingly. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Update

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code

2022-10-05 Thread Naoto Sato
On Tue, 4 Oct 2022 23:11:57 GMT, Justin Lu wrote: > Problem: Outdated doc does not match code. Claimed to throw exception and > compared to Long method. > Fix: Update doc to match code, compared to Double.parseDouble() accordingly. Turned out that the comment was not aligning with the behavior

Re: RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code

2022-10-05 Thread Naoto Sato
On Tue, 4 Oct 2022 23:11:57 GMT, Justin Lu wrote: > Problem: Outdated doc does not match code. Claimed to throw exception and > compared to Long method. > Fix: Update doc to match code, compared to Double.parseDouble() accordingly. Looks good to me. Since you are only modifying the comments, pl

RFR: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code

2022-10-04 Thread Justin Lu
Problem: Outdated doc does not match code. Claimed to throw exception and compared to Long method. Fix: Update doc to match code, compared to Double.parseDouble() accordingly. - Commit messages: - Update java doc to reflect code Changes: https://git.openjdk.org/jdk/pull/10567/files