Re: RFR: 8077587: BigInteger Roots [v15]

2025-07-10 Thread fabioromano1
On Thu, 10 Jul 2025 15:21:10 GMT, Raffaello Giulietti wrote: >> @rgiulietti Regarding the tests for _n_-th root, the tests for `sqrt()` >> could be extended in order to test also `nthRoot()`. > > @fabioromano1 IIUC, the bulk of the code in the PR is aimed at finding a good > starting estimate.

Re: RFR: 8077587: BigInteger Roots [v15]

2025-07-10 Thread Raffaello Giulietti
On Sat, 17 May 2025 11:25:58 GMT, fabioromano1 wrote: >> The [Rampdown Phase One](https://openjdk.org/projects/jdk/25/) for JDK 25 is >> about 3 weeks from now. >> >> I think it's a bit too late for API additions to be approved in due time. >> And even if we could rush this work for 25, it mak

Re: RFR: 8077587: BigInteger Roots [v15]

2025-06-05 Thread Raffaello Giulietti
On Sat, 17 May 2025 11:25:58 GMT, fabioromano1 wrote: >> The [Rampdown Phase One](https://openjdk.org/projects/jdk/25/) for JDK 25 is >> about 3 weeks from now. >> >> I think it's a bit too late for API additions to be approved in due time. >> And even if we could rush this work for 25, it mak

Re: RFR: 8077587: BigInteger Roots [v15]

2025-05-17 Thread fabioromano1
On Wed, 14 May 2025 18:48:50 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert "Use type long for bitLength instead of int" >> >> This reverts commit c8e1b8159206d9fb5532df7ccdf9

Re: RFR: 8077587: BigInteger Roots [v15]

2025-05-14 Thread fabioromano1
On Wed, 14 May 2025 18:48:50 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert "Use type long for bitLength instead of int" >> >> This reverts commit c8e1b8159206d9fb5532df7ccdf9

Re: RFR: 8077587: BigInteger Roots [v15]

2025-05-14 Thread Raffaello Giulietti
On Wed, 14 May 2025 18:07:08 GMT, fabioromano1 wrote: >> This PR implements nth root computation for BigIntegers using Newton method. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision: > > Revert "Use type long for bitLength inste

Re: RFR: 8077587: BigInteger Roots [v15]

2025-05-14 Thread fabioromano1
On Wed, 14 May 2025 18:27:28 GMT, Raffaello Giulietti wrote: > I doubt that the AKS primality test is of any practical relevance, although > it's a _great_ theoretical achievement. Yes, indeed it was just an example, but the exact power detection can be used also as a test apart from the enti

Re: RFR: 8077587: BigInteger Roots [v15]

2025-05-14 Thread Raffaello Giulietti
On Wed, 14 May 2025 18:07:08 GMT, fabioromano1 wrote: >> This PR implements nth root computation for BigIntegers using Newton method. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision: > > Revert "Use type long for bitLength inste

Re: RFR: 8077587: BigInteger Roots [v15]

2025-05-14 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Revert "Use type long for bitLength instead of int" This reverts commit c8e1b8159206d9fb5532df7ccdf98a

Re: RFR: 8077587: BigInteger Roots [v15]

2025-04-19 Thread fabioromano1
> This PR implements nth root computation for `BigInteger`s using Newton method > and optimizes `BigInteger.pow(int)` method. > [Here is a proof of convergence of the recurrence > used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf) fabioromano1 has updat