Re: RFR: 8028265: Add legacy tz tests to OpenJDK

2022-07-14 Thread Naoto Sato
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote: > Please review this PR. The PR open sources the closed timezone tests. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9476

Re: RFR: 8028265: Add legacy tz tests to OpenJDK

2022-07-14 Thread Sean Coffey
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote: > Please review this PR. The PR open sources the closed timezone tests. Marked as reviewed by coffeys (Reviewer). test/jdk/java/util/TimeZone/tools/share/makeZoneData.pl line 32: > 30: # static TimeZoneData. > 31: # For J2SE since JDK1.4,

Re: RFR: 8028265: Add legacy tz tests to OpenJDK

2022-07-13 Thread Naoto Sato
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote: > Please review this PR. The PR open sources the closed timezone tests. Please modify the PR title to match the JBS. - PR: https://git.openjdk.org/jdk/pull/9476

Re: RFR: 8028265: Add legacy tz tests to OpenJDK

2022-07-13 Thread Sean Coffey
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote: > Please review this PR. The PR open sources the closed timezone tests. 1 minor comment. Looks good to me. test/jdk/java/util/TimeZone/tools/share/Makefile line 33: > 31: # > 32: > 33: TZDATA = ../../../../../../../../open/src/java.base/s

Re: RFR: 8028265: Add legacy tz tests to OpenJDK

2022-07-13 Thread Yoshiki Sato
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote: > Please review this PR. The PR open sources the closed timezone tests. Can I ask you to help reviewing this PR? @coffeys @naotoj - PR: https://git.openjdk.org/jdk/pull/9476

RFR: 8028265: Add legacy tz tests to OpenJDK

2022-07-13 Thread Yoshiki Sato
Please review this PR. The PR open sources the closed timezone tests. - Commit messages: - Minor change added to Makefile - 8028265: Move closed timezone tests to open repository Changes: https://git.openjdk.org/jdk/pull/9476/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr