Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v6]

2023-02-27 Thread Vicente Romero
On Sat, 25 Feb 2023 16:07:24 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v5]

2023-02-27 Thread Vicente Romero
On Sat, 25 Feb 2023 16:03:39 GMT, Archie L. Cobbs wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 2765: >> >>> 2763: * any other methods; in this case the class is definitely >>> responsible. >>> 2764: */ >>> 2765: BiPredicate >>> buildResponsib

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v5]

2023-02-25 Thread Archie L . Cobbs
On Sat, 25 Feb 2023 13:38:05 GMT, Vicente Romero wrote: >> Archie L. Cobbs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Do some refactoring & cleanup suggested in reviews. > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Ch

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v4]

2023-02-25 Thread Archie L . Cobbs
On Sat, 25 Feb 2023 04:05:29 GMT, Vicente Romero wrote: >> Archie L. Cobbs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo in one comment and clarify another. > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.jav

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v6]

2023-02-25 Thread Archie L . Cobbs
> This bug relates to the "potentially ambiguous overload" warning which is > enabled by `-Xlint:overloads`. > > The warning detects certain ambiguities that can cause problems for lambdas. > For example, consider the interface `Spliterator.OfInt`, which declares these > two methods: > > void

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v5]

2023-02-25 Thread Vicente Romero
On Sat, 25 Feb 2023 03:57:30 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v5]

2023-02-25 Thread Vicente Romero
On Sat, 25 Feb 2023 03:57:30 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v4]

2023-02-24 Thread Vicente Romero
On Fri, 24 Feb 2023 18:09:16 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v4]

2023-02-24 Thread Archie L . Cobbs
On Fri, 24 Feb 2023 22:24:10 GMT, Vicente Romero wrote: >> Archie L. Cobbs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo in one comment and clarify another. > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.jav

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v5]

2023-02-24 Thread Archie L . Cobbs
> This bug relates to the "potentially ambiguous overload" warning which is > enabled by `-Xlint:overloads`. > > The warning detects certain ambiguities that can cause problems for lambdas. > For example, consider the interface `Spliterator.OfInt`, which declares these > two methods: > > void

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v4]

2023-02-24 Thread Vicente Romero
On Fri, 24 Feb 2023 18:09:16 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v3]

2023-02-24 Thread Vicente Romero
On Fri, 24 Feb 2023 20:05:52 GMT, Archie L. Cobbs wrote: >> I'm not saying that we should de-stream the code, actually we can do that >> later on, in a separate issue, iff there is a performance related complain, >> but it is true that in the past, I have seen some performance issues and the >

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v3]

2023-02-24 Thread Archie L . Cobbs
On Fri, 24 Feb 2023 19:49:18 GMT, Vicente Romero wrote: >>> I think the code should be split a bit using helper methods >> >> OK - will do. >> >>> I'm a bit worried that overuse of streams in this code could imply some >>> performance hit >> >> I asked basically the same question ([in a separ

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v3]

2023-02-24 Thread Vicente Romero
On Fri, 24 Feb 2023 19:27:02 GMT, Archie L. Cobbs wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 2719: >> >>> 2717: * does not override any other methods (in which case site is >>> responsible). >>> 2718: */ >>> 2719: void checkPotentiallyAmbigu

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v3]

2023-02-24 Thread Archie L . Cobbs
On Fri, 24 Feb 2023 19:00:51 GMT, Vicente Romero wrote: > I think the code should be split a bit using helper methods OK - will do. > I'm a bit worried that overuse of streams in this code could imply some > performance hit I asked basically the same question ([in a separate thread](https://

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v3]

2023-02-24 Thread Vicente Romero
On Fri, 24 Feb 2023 16:04:38 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v3]

2023-02-24 Thread Archie L . Cobbs
On Fri, 24 Feb 2023 18:01:56 GMT, Vicente Romero wrote: >> Archie L. Cobbs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove placeholder flag UNUSED_1; just leave a comment instead. > > src/jdk.compiler/share/classes/com/sun/tools/j

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v4]

2023-02-24 Thread Archie L . Cobbs
> This bug relates to the "potentially ambiguous overload" warning which is > enabled by `-Xlint:overloads`. > > The warning detects certain ambiguities that can cause problems for lambdas. > For example, consider the interface `Spliterator.OfInt`, which declares these > two methods: > > void

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v3]

2023-02-24 Thread Vicente Romero
On Fri, 24 Feb 2023 16:04:38 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v2]

2023-02-24 Thread Archie L . Cobbs
On Fri, 24 Feb 2023 11:49:55 GMT, Vicente Romero wrote: > I think a CSR is needed as we will be generating more warnings and projects > compiling with -Werror could see compilation errors Will do - thanks. > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java line 280: > >> 278

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v3]

2023-02-24 Thread Archie L . Cobbs
> This bug relates to the "potentially ambiguous overload" warning which is > enabled by `-Xlint:overloads`. > > The warning detects certain ambiguities that can cause problems for lambdas. > For example, consider the interface `Spliterator.OfInt`, which declares these > two methods: > > void

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v2]

2023-02-24 Thread Vicente Romero
On Tue, 21 Feb 2023 01:42:41 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v2]

2023-02-24 Thread Vicente Romero
On Tue, 21 Feb 2023 01:42:41 GMT, Archie L. Cobbs wrote: >> This bug relates to the "potentially ambiguous overload" warning which is >> enabled by `-Xlint:overloads`. >> >> The warning detects certain ambiguities that can cause problems for lambdas. >> For example, consider the interface `Spl

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme [v2]

2023-02-20 Thread Archie L . Cobbs
> This bug relates to the "potentially ambiguous overload" warning which is > enabled by `-Xlint:overloads`. > > The warning detects certain ambiguities that can cause problems for lambdas. > For example, consider the interface `Spliterator.OfInt`, which declares these > two methods: > > void

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme

2023-02-20 Thread Archie L . Cobbs
On Mon, 20 Feb 2023 23:53:05 GMT, SWinxy wrote: > In the `AWTEventMulticaster` class(es), which interfaces are causing the > ambiguity? Ah - my apologies. Those got added during development but were not needed once all the bugs were worked out. I've removed them and that will also eliminate `

Re: RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme

2023-02-20 Thread SWinxy
On Sun, 19 Feb 2023 23:52:52 GMT, Archie L. Cobbs wrote: > This bug relates to the "potentially ambiguous overload" warning which is > enabled by `-Xlint:overloads`. > > The warning detects certain ambiguities that can cause problems for lambdas. > For example, consider the interface `Splitera

RFR: 8026369: javac potentially ambiguous overload warning needs an improved scheme

2023-02-19 Thread Archie L . Cobbs
This bug relates to the "potentially ambiguous overload" warning which is enabled by `-Xlint:overloads`. The warning detects certain ambiguities that can cause problems for lambdas. For example, consider the interface `Spliterator.OfInt`, which declares these two methods: void forEachRemaining