mit/4c7b3e7fc39a06e208ea1668095d055457549d63
Stats: 28 lines in 1 file changed: 0 ins; 5 del; 23 mod
8334758: Incorrect note in Javadoc for a few RandomGenerator methods
Reviewed-by: bpb
-
PR: https://git.openjdk.org/jdk/pull/20152
On Fri, 19 Jul 2024 17:08:38 GMT, Raffaello Giulietti
wrote:
> I guess that the approval of the CSR, once done, would "de-facto" count as a
> 2nd review?
I agree.
-
PR Comment: https://git.openjdk.org/jdk/pull/20152#issuecomment-2239863660
On Fri, 19 Jul 2024 16:50:50 GMT, Raffaello Giulietti
wrote:
>> Small corrections to @implSpec notes in a few methods in RandomGenerator.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Improved wording.
I guess th
On Fri, 19 Jul 2024 16:50:50 GMT, Raffaello Giulietti
wrote:
>> Small corrections to @implSpec notes in a few methods in RandomGenerator.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Improved wording.
Looks fine
> Small corrections to @implSpec notes in a few methods in RandomGenerator.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Improved wording.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20152/files
- ne
On Fri, 12 Jul 2024 06:28:15 GMT, Raffaello Giulietti
wrote:
> Small corrections to @implSpec notes in a few methods in RandomGenerator.
src/java.base/share/classes/java/util/random/RandomGenerator.java line 816:
> 814: * distribution in the range 0 (inclusive)
> 815: * to {@code bou
Small corrections to @implSpec notes in a few methods in RandomGenerator.
-
Commit messages:
- 8334758: Incorrect note in Javadoc for a few RandomGenerator methods
Changes: https://git.openjdk.org/jdk/pull/20152/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20152&a
Thanks, filed 9077206.
Den fre. 21. jun. 2024 kl. 21.06 skrev Raffaello Giulietti <
raffaello.giulie...@oracle.com>:
> Hi,
>
> your observation seems correct.
>
> In order to file a properly tracked bug report, please proceed according
> to this guide:
>
>
> https://docs.oracle.com/en/java/javase
Hi,
your observation seems correct.
In order to file a properly tracked bug report, please proceed according
to this guide:
https://docs.oracle.com/en/java/javase/22/troubleshoot/submit-bug-report.html
Thanks
On 2024-06-21 19:12, Stig Rohde Døssing wrote:
Hi,
The Javadoc for RandomGener
Hi,
The Javadoc for RandomGenerator.nextLong(long origin, long bound) has this
to say:
Implementation Requirements:The default implementation checks that origin
and bound are positive longs
This doesn't seem to be true. The default implementation checks that origin
and bound are a valid range (t
10 matches
Mail list logo
