Re: [jdk19] RFR: 8291512: Snippetize modules API examples [v2]

2022-07-28 Thread Mark Reinhold
On Thu, 28 Jul 2022 17:54:33 GMT, Joe Darcy wrote: > Looks fine; may want to change this issue to be a subtask of JDK-8289774. Thanks. Converted to subtask. - PR: https://git.openjdk.org/jdk19/pull/156

Re: [jdk19] RFR: 8291512: Snippetize modules API examples [v2]

2022-07-28 Thread Mark Reinhold
> The specification of the modules API contains several non-normative code > examples. We should convert them to use snippets, per [JEP > 413](https://openjdk.org/jeps/413). Mark Reinhold has updated the pull request incrementally with one additional commit since the last revision: Fix heade

Re: [jdk19] RFR: 8291512: Snippetize modules API examples

2022-07-28 Thread Joe Darcy
On Thu, 28 Jul 2022 17:41:31 GMT, Mark Reinhold wrote: > The specification of the modules API contains several non-normative code > examples. We should convert them to use snippets, per [JEP > 413](https://openjdk.org/jeps/413). Looks fine; may want to change this issue to be a subtask of JDK-

[jdk19] RFR: 8291512: Snippetize modules API examples

2022-07-28 Thread Mark Reinhold
The specification of the modules API contains several non-normative code examples. We should convert them to use snippets, per [JEP 413](https://openjdk.org/jeps/413). - Commit messages: - 8291512: Snippetize modules API examples Changes: https://git.openjdk.org/jdk19/pull/156/fil