Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-13 Thread Joe Wang
On Wed, 13 Jul 2022 16:28:10 GMT, Iris Clark wrote: >> The pre tag is supported for code blocks by most markdown implementations so >> this should be OK and as Joe mentions has been there for ages in this file. > > Agree. I think the `pre` tag will be fine in this instance. Thanks! --

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-13 Thread Iris Clark
On Wed, 13 Jul 2022 10:13:09 GMT, Lance Andersen wrote: >> Iris can probably comment on this. It's been the pre tag across the existing >> md files. > > The pre tag is supported for code blocks by most markdown implementations so > this should be OK and as Joe mentions has been there for ages i

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-13 Thread Naoto Sato
On Wed, 13 Jul 2022 00:04:24 GMT, Joe Wang wrote: > Update dom.md, adding notice. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/138

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-13 Thread Lance Andersen
On Wed, 13 Jul 2022 05:31:27 GMT, Joe Wang wrote: >> src/java.xml/share/legal/dom.md line 4: >> >>> 2: >>> 3: ### W3C Software Notice >>> 4: >> >> Since this is a markdown, should this be three back-ticks "```" instead of >> "pre" HTML tag? > > Iris can probably comment on this. It's been th

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-13 Thread Lance Andersen
On Wed, 13 Jul 2022 00:04:24 GMT, Joe Wang wrote: > Update dom.md, adding notice. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/138

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Joe Wang
On Wed, 13 Jul 2022 01:57:43 GMT, Naoto Sato wrote: >> Update dom.md, adding notice. > > src/java.xml/share/legal/dom.md line 4: > >> 2: >> 3: ### W3C Software Notice >> 4: > > Since this is a markdown, should this be three back-ticks "```" instead of > "pre" HTML tag? Iris can probably com

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Iris Clark
On Wed, 13 Jul 2022 00:04:24 GMT, Joe Wang wrote: > Update dom.md, adding notice. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/138

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Naoto Sato
On Wed, 13 Jul 2022 00:04:24 GMT, Joe Wang wrote: > Update dom.md, adding notice. src/java.xml/share/legal/dom.md line 4: > 2: > 3: ### W3C Software Notice > 4: Since this is a markdown, should this be three back-ticks "```" instead of "pre" HTML tag? - PR: https://git.openjdk

[jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Joe Wang
Update dom.md, adding notice. - Commit messages: - 8290207: Missing notice in dom.md Changes: https://git.openjdk.org/jdk19/pull/138/files Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=138&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290207 Stats: 15 lines in 1 fil