Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-08-07 Thread David Holmes
Hi Patrick, On 6/08/2022 7:05 pm, Patrick Pfeifer wrote: On Mon, 18 Jul 2022 15:22:01 GMT, Jonathan Gibbons wrote: Please review these changes to the nroff manpage files so that they match their markdown sources that Oracle maintains. Not a problem with this PR as such, but we still have a

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-08-06 Thread Patrick Pfeifer
On Sat, 6 Aug 2022 09:01:39 GMT, Patrick Pfeifer wrote: >> src/java.base/share/man/keytool.1 line 456: >> >>> 454: \f[CB]PrivateKeyEntry\f[R] for the signer that already exists in the >>> 455: keystore. >>> 456: This option is used to sign the certificate with the signer?s private >> >> Not a p

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-08-06 Thread Patrick Pfeifer
On Mon, 18 Jul 2022 15:22:01 GMT, Jonathan Gibbons wrote: >> Please review these changes to the nroff manpage files so that they match >> their markdown sources that Oracle maintains. >> >> All pages at a minimum have 19-ea replaced with 19, and copyright set to >> 2022 if needed. Additionall

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-19 Thread David Holmes
On Mon, 18 Jul 2022 23:27:58 GMT, David Holmes wrote: >> src/java.base/share/man/keytool.1 line 456: >> >>> 454: \f[CB]PrivateKeyEntry\f[R] for the signer that already exists in the >>> 455: keystore. >>> 456: This option is used to sign the certificate with the signer?s private >> >> Not a pro

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-18 Thread David Holmes
On Mon, 18 Jul 2022 15:26:23 GMT, Jonathan Gibbons wrote: >> Please review these changes to the nroff manpage files so that they match >> their markdown sources that Oracle maintains. >> >> All pages at a minimum have 19-ea replaced with 19, and copyright set to >> 2022 if needed. Additionall

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-18 Thread Jonathan Gibbons
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote: > Please review these changes to the nroff manpage files so that they match > their markdown sources that Oracle maintains. > > All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 > if needed. Additionally: > > T

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-18 Thread Jonathan Gibbons
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote: > Please review these changes to the nroff manpage files so that they match > their markdown sources that Oracle maintains. > > All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 > if needed. Additionally: > > T

[jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-17 Thread David Holmes
Please review these changes to the nroff manpage files so that they match their markdown sources that Oracle maintains. All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 if needed. Additionally: The Java manpage was missing updates from: - [JDK-8282018](https://bugs