On Wed, 12 Jun 2024 14:24:56 GMT, Alan Bateman wrote:
>> 8334048: -Xbootclasspath can not read some ZIP64 zip files
>
> Are you planning to add tests? I don't think we should be changing this code
> with good tests.
Hi @AlanBateman, when you have a chance can you take a look at the tests I
add
On Tue, 10 Sep 2024 05:46:46 GMT, Jaikiran Pai wrote:
>> I pushed the review suggestions. There were two GitHub Actions failures on
>> `macos-aarch64`, but they look to be occurrences of this existing bug:
>> https://bugs.openjdk.org/browse/JDK-8247940.
>
> Hello @f
On Mon, 9 Sep 2024 20:27:47 GMT, fitzsim wrote:
>> 8334048: -Xbootclasspath can not read some ZIP64 zip files
>
> fitzsim has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - BootClassPathZipFileTest: Use test.classes di
> 8334048: -Xbootclasspath can not read some ZIP64 zip files
fitzsim has updated the pull request incrementally with two additional commits
since the last revision:
- BootClassPathZipFileTest: Use test.classes directory for test ZIPs
- BootClassPathZipFileTest, BootClassPathZipFileCrea
On Wed, 4 Sep 2024 11:45:30 GMT, Severin Gehwolf wrote:
>> fitzsim has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootClassPathZipFileTest: Switch to createClassBytes, createZip static
>> functions
>
On Wed, 4 Sep 2024 11:33:39 GMT, Severin Gehwolf wrote:
>> fitzsim has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootClassPathZipFileTest: Switch to createClassBytes, createZip static
>> functions
On Mon, 2 Sep 2024 16:02:31 GMT, Andrew John Hughes wrote:
>> fitzsim has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BootClassPathZipFileTest: Switch to createClassBytes, createZip static
>> functions
&
On Wed, 31 Jul 2024 21:54:15 GMT, fitzsim wrote:
>> 8334048: -Xbootclasspath can not read some ZIP64 zip files
>
> fitzsim has updated the pull request incrementally with one additional commit
> since the last revision:
>
> BootClassPathZipFileTest: Switch to create
On Wed, 31 Jul 2024 21:54:15 GMT, fitzsim wrote:
>> 8334048: -Xbootclasspath can not read some ZIP64 zip files
>
> fitzsim has updated the pull request incrementally with one additional commit
> since the last revision:
>
> BootClassPathZipFileTest: Switch to create
On Wed, 31 Jul 2024 21:54:15 GMT, fitzsim wrote:
>> 8334048: -Xbootclasspath can not read some ZIP64 zip files
>
> fitzsim has updated the pull request incrementally with one additional commit
> since the last revision:
>
> BootClassPathZipFileTest: Switch to create
> 8334048: -Xbootclasspath can not read some ZIP64 zip files
fitzsim has updated the pull request incrementally with one additional commit
since the last revision:
BootClassPathZipFileTest: Switch to createClassBytes, createZip static
functions
-
Changes:
- all: ht
> 8334048: -Xbootclasspath can not read some ZIP64 zip files
fitzsim has updated the pull request incrementally with six additional commits
since the last revision:
- BootClassPathZipFileTest: Add test
- BootClassPathZip64Test: Remove test
- BootClassPathZip64Test: Delete class file
On Wed, 12 Jun 2024 14:02:58 GMT, fitzsim wrote:
> 8334048: -Xbootclasspath can not read some ZIP64 zip files
It turns out ZIP64 is underrepresented in the test suite in general; for
example, https://bugs.openjdk.org/browse/JDK-8185896 is still open.
Using the Java class library alone, I h
On Wed, 12 Jun 2024 14:24:56 GMT, Alan Bateman wrote:
> Are you planning to add tests? I don't think we should be changing this code
> with good tests.
Yes, I will write a test that replicates the failure. So far I verified the
bad-signature condition with GDB, but I agree there should be a t
8334048: -Xbootclasspath can not read some ZIP64 zip files
-
Commit messages:
- 8334048: -Xbootclasspath can not read some ZIP64 zip files
Changes: https://git.openjdk.org/jdk/pull/19678/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19678&range=00
Issue: https://bugs.op
15 matches
Mail list logo
