Re: RFR: 8359123: Misleading examples in jmod man page [v5]

2025-06-18 Thread duke
On Wed, 18 Jun 2025 07:17:13 GMT, Ana Maria Mihalceanu wrote: >> Please review my PR. This PR includes the following: >> >> - [x] Fix a small typo in a word and copyright. >> - [x] Enhance description for `--target-platform`. >> - [x] Rearrange `jmod create` example from basic to complex. > > An

Withdrawn: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-06-18 Thread duke
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote: > The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problem

Re: RFR: 8359735: [Ubuntu 25.10] java/lang/ProcessBuilder/Basic.java, java/lang/ProcessHandle/InfoTest.java fail due to rust-coreutils

2025-06-17 Thread duke
On Mon, 16 Jun 2025 22:49:02 GMT, Vladimir Petko wrote: > To accommodate systems like Ubuntu 25.10 that use Rust coreutils, this PR > updates tests that previously assumed BusyBox was the only environment to use > symlinks for core utilities. > > Changes: > - `java/lang/ProcessBuilder/Basic.

Re: RFR: 8359449: [TEST] open/test/jdk/java/io/File/SymLinks.java Refactor extract method for Windows specific test

2025-06-17 Thread duke
On Tue, 17 Jun 2025 14:56:59 GMT, Dermot Boyle wrote: > … extract method for Windows specific test @dermotb Your change (at version 9f0647e6d7176c36e3acf93a4256d102f0867e0a) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/25853#issuecom

Withdrawn: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe

2025-06-12 Thread duke
On Wed, 19 Feb 2025 07:53:15 GMT, Nicole Xu wrote: > The UnsafeOps JMH benchmark fails with the following error: > > ``` > java.lang.IllegalAccessError: class > org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot > access class jdk.internal.misc.Unsafe (in m

Re: RFR: 8358078: javap crashes with NPE on preview class file [v3]

2025-06-04 Thread duke
On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote: >> This change addresses a NPE in javap when trying to print a class with >> minorVersion != 0. With this change, we fall back to the methods that don't >> take a `ClassFileFormatVersion` in such case. > > Hannes Greule has updated the pull

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v5]

2025-06-03 Thread duke
On Tue, 20 May 2025 10:54:44 GMT, He-Pin(kerr) wrote: >> Motivation: >> When a user passes a wrong parameter, the current implementation throws an >> IllegalArgumentException with an error message `null`, which is not helpful. >> >> Modification: >> Add detail error messages. >> >> Result: >>

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v4]

2025-06-03 Thread duke
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote: >> The documentation suggests that --linux-package-deps is a boolean option, >> while in fact it is a string option with dependencies separated by comma and >> space >> >> You can tell that this option is supposed to have an argument

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v15]

2025-06-02 Thread duke
On Tue, 27 May 2025 19:21:45 GMT, David Beaumont wrote: >> Adding read-only support to ZipFileSystem. >> >> The new `accessMode` environment property allows for readOnly and readWrite >> values, and ensures that the requested mode is consistent with what's >> returned. >> >> This involved a l

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v6]

2025-05-30 Thread duke
On Fri, 30 May 2025 19:34:16 GMT, Mohamed Issa wrote: >> The goal of this PR is to implement an x86_64 intrinsic for >> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are >> included to check the performance of specific input value ranges to help >> prevent regression

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v5]

2025-05-30 Thread duke
On Thu, 29 May 2025 18:56:11 GMT, Mohamed Issa wrote: >> The goal of this PR is to implement an x86_64 intrinsic for >> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are >> included to check the performance of specific input value ranges to help >> prevent regression

Withdrawn: 8351354: Enhance java -XshowSettings:security:tls to show enabled TLS groups and signature algorithms

2025-05-29 Thread duke
On Thu, 3 Apr 2025 18:47:43 GMT, Matthew Donovan wrote: > In this PR I added TLS groups and signature algorithms to the output of the > show settings flag. The values are printed in a single column, like the > cipher suites. There can be a lot of values so putting on a single line is > ugly. I

Re: RFR: 8334742: Change java.time month/day field types to 'byte' [v2]

2025-05-28 Thread duke
On Wed, 30 Apr 2025 20:38:59 GMT, Gautham Krishnan wrote: >> In the following classes, month and day values are stored in fields of type >> 'int' or 'short'. The range of allowed values is small enough that the type >> can be 'byte' instead. >> >> java.time.YearMonth >> java.time.MonthDay >> j

Re: RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null [v2]

2025-05-27 Thread duke
On Mon, 26 May 2025 15:48:10 GMT, Steffen Nießing wrote: >> `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the >> specified argument is `null`. This PR adds the missing `throws` declaration >> for the NPE. > > Steffen Nießing has updated the pull request incrementally w

Re: RFR: 8356443: Update open/test/jdk/TEST.groups manual test groups definitions with missing manual test

2025-05-27 Thread duke
On Wed, 21 May 2025 15:37:34 GMT, serhiysachkov wrote: > Update open/test/jdk/TEST.groups manual test groups definitions with missing > manual test @serhiysachkov Your change (at version a977e3ca9cc40f0a2af2d8faaf5cfd8adace60f2) is now ready to be sponsored by a Committer. - PR

Re: RFR: 8357644: Add missing CPE statements

2025-05-24 Thread duke
On Fri, 23 May 2025 11:40:24 GMT, Sorna Sarathi N wrote: > Adds missing classpath exception in a couple of files. @Sorna-Sarathi Your change (at version 1778c756b997c47938fff1bf15bb8c6b5b855af5) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jd

Re: RFR: 8357462: Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as manual [v2]

2025-05-22 Thread duke
On Thu, 22 May 2025 08:31:06 GMT, serhiysachkov wrote: >> Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as >> manual > > serhiysachkov has updated the pull request incrementally with one additional > commit since the last revision: > > 8357462: copyright update @ser

Re: RFR: 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better performance [v3]

2025-05-22 Thread duke
On Sun, 20 Apr 2025 13:01:30 GMT, Jason Zaugg wrote: >> zipfs has a (undocumented) property "zipinfo-time" which was introduced in >> https://bugs.openjdk.org/browse/JDK-8150496 to help improve performance of >> the ZipFileSystem. When a ZipFileSystem is created with this property's >> value s

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v6]

2025-05-21 Thread duke
On Wed, 21 May 2025 06:54:37 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > address review comments @pawanchawdhary1 Your cha

Re: RFR: 8357052: java/io/File/GetXSpace.java prints wrong values in exception

2025-05-20 Thread duke
On Thu, 15 May 2025 13:49:14 GMT, Arno Zeller wrote: > When the test java/io/File/GetXSpace.java fails, because the usable space is > greater than the free space, the values in the exception are not the correct > ones. @ArnoZeller Your change (at version 8506932622f713e0a21dda7150128773718d28

Withdrawn: 8349545: ClassLoader.definePackage() throws IllegalArgumentException if package already defined

2025-05-19 Thread duke
On Sun, 23 Feb 2025 11:32:41 GMT, Robert Stupp wrote: > Concurent calls to `ClassLoader.definePackage()` can yield > `IllegalArgumentException`s if the package is already defined. Some built-in > class loaders, like `URLClassLoader`, already handle this case, but custom > class loaders (would)

Re: RFR: 8356974: tools/launcher/ToolsOpts.java fails if the build id contains "-J" [v2]

2025-05-19 Thread duke
On Mon, 19 May 2025 09:13:14 GMT, Manuel Hässig wrote: >> When passing `-J-version` to the patched javac, >> `tools/launcher/ToolsOpts.java` wants to verify that the output corresponds >> to the expected version output. However, if the build id of the JDK running >> this test contains the subs

Re: RFR: 8357106: Add missing classpath exception copyright headers

2025-05-19 Thread duke
On Fri, 16 May 2025 07:04:04 GMT, Sorna Sarathi N wrote: > This PR adds missing classpath exception @Sorna-Sarathi Your change (at version 1b55b287f84d5cad1958aec440f3b499a874b04c) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/25261#i

Withdrawn: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

2025-05-16 Thread duke
On Fri, 14 Mar 2025 12:29:22 GMT, Christoph Langer wrote: > Alternative approach to #24012 > > This keeps the current handling of *.pdb vs *.stripped.pdb which allows > debugging at the cost of a little hack in jlink. Maybe the code in jlink can > be improved, e.g. make it more conditional. >

Withdrawn: 8352489: Relax jspawnhelper version checks to informative

2025-05-15 Thread duke
On Thu, 20 Mar 2025 09:52:02 GMT, Aleksey Shipilev wrote: > See the bug for rationale. > > This goal for this improvement is to be easily backportable, so we can catch > up with update releases. As such, it does a few borderline-trivial changes, > and _does not_ change the jspawnhelper protoc

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v4]

2025-05-15 Thread duke
On Wed, 14 May 2025 14:39:37 GMT, Johannes Graham wrote: >> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead >> of converting to decimal string and then parsing it. This results in an >> approximate 6x improvement for me. > > Johannes Graham has updated the pull reque

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v12]

2025-05-15 Thread duke
On Wed, 14 May 2025 08:18:39 GMT, Timofei Pushkin wrote: >> If a base class is package-private then its subclasses should have the same >> package name and defining class loader, otherwise `IllegalAccessError` is >> thrown when linking a subclass. Currently when dumping a static archive >> sep

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-15 Thread duke
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The incremen

Re: RFR: 8355719: Reduce memory consumption of BigInteger.pow() [v55]

2025-05-09 Thread duke
On Thu, 8 May 2025 16:48:40 GMT, fabioromano1 wrote: >> This PR optimizes `BigInteger.pow(int)` method. The primary enhancement in >> `pow()` is not concerned most on execution time, but rather in memory >> optimization, because the PR implementation does the "shift of the exponent" >> squarin

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v12]

2025-05-07 Thread duke
On Tue, 6 May 2025 20:52:34 GMT, Markus KARG wrote: >> This Pull Request proposes an implementation for >> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new >> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int >> dstBegin)` to the `CharSequence` in

Re: RFR: 8355249: Remove the use of WMIC from the entire source code [v2]

2025-05-06 Thread duke
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote: >> After searching the entire JDK source code, I found that WMIC is only used >> in four files. These WMIC calls can be replaced with PowerShell for WMI. >> >> The primary challenge in this replacement is to make it work the same as >> bef

Withdrawn: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava

2025-05-05 Thread duke
On Wed, 24 Jul 2024 19:11:42 GMT, Brian Burkhalter wrote: > This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. This pull request has been closed without being integr

Withdrawn: 8349543: LinkedBlockingDeque does not immediately throw InterrruptedException in put/take

2025-05-05 Thread duke
On Wed, 5 Feb 2025 15:36:15 GMT, kabutz wrote: > The LinkedBlockingDeque does not behave consistently with other concurrency > components. If we call putFirst(), putLast(), takeFirst(), or takeLast() with > a thread that is interrupted, it does not immediately throw an > InterruptedException,

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread duke
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java [v3]

2025-05-05 Thread duke
On Sat, 3 May 2025 13:02:34 GMT, Oleksii Sylichenko wrote: >> This PR proposes three improvements to the `Basic.java` test: >> >> 1. Increase Timeout >>- The current timeout is insufficient when running the test in IntelliJ >> IDEA. >>- I propose increasing it by one minute. >>- The

Withdrawn: 8315585: Optimization for decimal to string

2025-05-04 Thread duke
On Sat, 25 Jan 2025 07:25:40 GMT, Shaojin Wen wrote: > Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString > and BigDecimal::toPlainString performance and reduce duplicate code This pull request has been closed without being integrated. - PR: https://git.o

Withdrawn: 8349189: Speed up DateTime parse & format via Class File API

2025-05-04 Thread duke
On Fri, 31 Jan 2025 10:29:53 GMT, Shaojin Wen wrote: > By using the Class File API to dynamically generate a CompositePrinterParser, > and defining DateTimePrinterParser[] printerParsers as a specific field, C2 > can do TypeProfile optimization. > > Since the CompositePrinterParser is generate

Withdrawn: 8349241: Fix the concurrent execution JVM crash of StringBuilder::append(int/long)

2025-05-04 Thread duke
On Mon, 3 Feb 2025 18:51:20 GMT, Shaojin Wen wrote: > The following code can reproduce the problem, writing out of bounds causes > JVM Crash > > > StringBuilder buf = new StringBuilder(); > buf.append('中'); > > Thread[] threads = new Thread[40]; > final CountD

Withdrawn: 8351344: Avoid explicit Objects.requireNonNull in String.join

2025-05-01 Thread duke
On Thu, 20 Feb 2025 09:30:02 GMT, Andrey Turbanov wrote: > We have helpful NPE messages now - they are more user-friendly. > And shorter methods are more likely to be inlined. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/23710

Re: RFR: 8355391: Use Long::hashCode in java.time

2025-04-30 Thread duke
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote: > Replace manual bitwise operations in `hashCode` implementations of > `java.time` with `Long::hashCode`. @vy Your change (at version 891d9ada7ce6860ea8e1253021f04053cc27090a) is now ready to be sponsored by a Committer. - P

Re: RFR: 8342886: Update MET timezone in TimeZoneNames files [v5]

2025-04-29 Thread duke
On Tue, 29 Apr 2025 18:11:05 GMT, Gautham Krishnan wrote: >> MET timezone entry in TimeZoneNames.java and TimeZoneNames_*.java needs to >> be updated as MET is alias to Europe/Brussels as per 2024b tzdata changes. >> >> Also Bug4848242.java needs to be removed as the test expects all euro local

Withdrawn: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner

2025-04-29 Thread duke
On Fri, 15 Nov 2024 20:54:56 GMT, Aleksey Shipilev wrote: > DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` > implementation. That implementation carries a doubly-linked list, and so > makes DBB suffer from the same issue fixed for generic > `java.lang.ref.Cleaner` users with

Re: RFR: 8350542: Optional.orElseThrow(Supplier) does not specify behavior when supplier returns null [v2]

2025-04-28 Thread duke
On Mon, 28 Apr 2025 22:14:29 GMT, simon wrote: >> Javadoc for java.util.Optional.orElseThrow(Supplier) misses mentioning of >> another possible cause of a NullPointerException - when the exception >> supplying function returns a null result. >> - >> ### Progress >> - [ ] Change must be

Withdrawn: 8347408: Create an internal method handle adapter for system calls with errno

2025-04-23 Thread duke
On Tue, 25 Feb 2025 08:27:26 GMT, Per Minborg wrote: > As we advance, converting older JDK code to use the relatively new FFM API > requires system calls that can provide `errno` and the likes to explicitly > allocate a `MemorySegment` to capture potential error states. This can lead > to nega

Withdrawn: 8347009: Speed ​​up parseInt and parseLong

2025-04-23 Thread duke
On Sat, 4 Jan 2025 10:24:15 GMT, Shaojin Wen wrote: > This is an optimization for decimal Integer.parseInt and Long.parseLong, > which improves performance by about 10%. The optimization includes: > 1. Improve performance by parsing 2 numbers at a time, which has performance > improvements for

Re: RFR: 8354522: Clones of DecimalFormat cause interferences when used concurrently [v9]

2025-04-17 Thread duke
On Wed, 16 Apr 2025 17:40:39 GMT, Johannes Graham wrote: >> The `DigitList` class used in `DecimalFormat` does not reset the `data` >> array in its clone method. This can cause interference when clones are used >> concurrently. > > Johannes Graham has updated the pull request incrementally with

Withdrawn: 8347814: Make all imports consistent in the FFM API tests and benchmarks

2025-04-16 Thread duke
On Wed, 19 Feb 2025 09:22:09 GMT, Per Minborg wrote: > This PR proposes to make all imports consistent in the FFM API tests and > benchmarks. > > This is a follow-up PR from https://github.com/openjdk/jdk/pull/22827 > > Passes tier1-3 This pull request has been closed without being integrated

Re: RFR: 8354111: JavaDoc states that Iterator.remove() is linear in the LinkedBlockingDeque

2025-04-14 Thread duke
On Tue, 8 Apr 2025 08:50:37 GMT, kabutz wrote: > One of the features of the LinkedBlockingDeque is that it is a doubly-linked > node queue, with pointers in each node to "prev" and "next", which allows > remove() in the Iterator to remove the node in constant time. However, in the > JavaDoc of

Re: RFR: 8346230: [perf] scalability issue for the specjvm2008::xml.transform workload [v6]

2025-04-14 Thread duke
On Mon, 14 Apr 2025 15:22:21 GMT, Vladimir Ivanov wrote: >> The HashMap for caching was deleted. Now it use only ThreadLocal variable >> without synchronization. >> According to the specjvm2008::xml.transform workload the performance for low >> threads counts was not affected and improved for h

Re: RFR: 8354513: Bug in j.u.l.Handler deadlock test allows null pointer during race condition

2025-04-14 Thread duke
On Mon, 14 Apr 2025 10:56:45 GMT, David Beaumont wrote: > Add null pointer guard in test formatter (since it can be called with a log > record without parameters). @david-beaumont Your change (at version 67bea85bb13c3a7c46d28a458230a2a8e51e7f4d) is now ready to be sponsored by a Committer. -

Re: RFR: 8353683: [REDO] j.u.l.Handler classes create deadlock risk via synchronized publish() method

2025-04-10 Thread duke
On Tue, 8 Apr 2025 11:00:27 GMT, David Beaumont wrote: > 8353683: j.u.l.Handler classes create deadlock risk via synchronized > publish() method. > > 1. Remove synchronization of calls to publish() in Handlers in > java.util.logging package. > 2. Add explanatory comments to various affected me

Re: RFR: 8350462: MethodTypeForm.LF_INTERPRET can cache the MemberName instead [v2]

2025-04-10 Thread duke
On Sun, 6 Apr 2025 08:09:27 GMT, Zihao Lin wrote: >> Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET >> Lambda form. Instead of caching the entire LambdaForm, change it to store a >> SoftReference. This will avoid unnecessary memory usage. > > Zihao Lin has updated the

Re: RFR: 8341402: BigDecimal's square root optimization [v32]

2025-04-10 Thread duke
On Fri, 28 Mar 2025 18:24:49 GMT, fabioromano1 wrote: >> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed >> up `BigDecimal.sqrt()` implementation. Here is how I made it. >> >> The main steps of the algorithm are as follows: >> first argument reduce the value to an i

Re: RFR: 8353840: JNativeScan should not throw error for missing system classes [v3]

2025-04-09 Thread duke
On Tue, 8 Apr 2025 13:51:59 GMT, Danish Nawab wrote: >> ## Description >> >> https://bugs.openjdk.org/browse/JDK-8353840 >> >> ### Existing behavior >> Log the error message and terminate in case of missing system class >> >> >> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit c

Withdrawn: 8069345: (fs) FileTreeWalker throws NotDirectoryException on file junction points

2025-04-08 Thread duke
On Thu, 17 Oct 2024 00:05:26 GMT, Brian Burkhalter wrote: > Improve support for Windows directory junctions. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/21555

Re: RFR: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method [v13]

2025-04-05 Thread duke
On Wed, 2 Apr 2025 21:59:32 GMT, David Beaumont wrote: >> 8349206: j.u.l.Handler classes create deadlock risk via synchronized >> publish() method. >> >> 1. Remove synchronization of calls to publish() in Handlers in >> java.util.logging package. >> 2. Add explanatory comments to various affec

Withdrawn: JDK-8348030 : Extend Math.min and Math.max to support multiple parameters

2025-04-04 Thread duke
On Wed, 15 Jan 2025 14:26:32 GMT, Aviad Zer wrote: > This change extends the Math.min function to support multiple parameters, > improving its usability and code readability. > > Previously, finding the minimum value among multiple variables required using > nested Math.min calls or converting

Withdrawn: 8348556: Inlining fails earlier for MemorySegment::reinterpret

2025-04-03 Thread duke
On Wed, 5 Feb 2025 10:17:09 GMT, Per Minborg wrote: > This PR proposes to add some `@ForceInline` annotations in the `Module` class > in order to assist inlining of FFM var/method handles. > > There are also some changes in other classes (notably `j.l.Object`) which, if > implemented, can take

Withdrawn: 8336017: Deprecate java.util.logging.LoggingMXBean, its implementation, and accessor method for removal

2025-04-02 Thread duke
On Thu, 23 Jan 2025 15:23:37 GMT, Kevin Walls wrote: > java.util.logging.LoggingMXBean and > java.util.logging.LogManager::getLoggingMXBean are deprecated since > JDK-8139982 in JDK 9. > > These deprecations should be uprated to state they are for future removal. > > java.util.logging.Logging

Withdrawn: 8346946: Allow class loaders to bind to layers for service loading

2025-04-02 Thread duke
On Thu, 2 Jan 2025 17:13:17 GMT, David M. Lloyd wrote: > When loading services by class loader > (`ServiceLoader.load(Class,ClassLoader)`), the module layers bound to the > given class loader are searched for services, along with the layers bound to > class loader's parent, and so on. For non-

Withdrawn: 8258246: sun.net.www.ParseUtil.decode throws java.lang.IllegalArgumentException: Error decoding percent encoded characters

2025-03-30 Thread duke
On Fri, 31 Jan 2025 09:47:35 GMT, Fabian Meumertzheim wrote: > `URLClassPath` called into `ParseUtil.fileToEncodedURL`, which misencoded > characters with a four byte UTF-8 representation. Replacing that function > with `toPath().toUri().toURL()` (and removing it, since its only used once) > r

Re: RFR: 8351593: [JMH] test PhoneCode.Bulk reports NPE exception [v3]

2025-03-27 Thread duke
On Mon, 24 Mar 2025 19:34:55 GMT, Vladimir Ivanov wrote: >> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently >> these tests using empty data set that looks bad. > > Vladimir Ivanov has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter [v2]

2025-03-25 Thread duke
On Tue, 25 Mar 2025 13:00:44 GMT, Mikhail Yankelevich wrote: >> Updating `jdk.test.lib.SecurityTools` class to have jar method accept >> `List` parameter similar to `keytool` methods. >> Currently this only accept String parameter, which is error prone with >> missing space > > Mikhail Yankele

Re: RFR: 8351593: [JMH] test PhoneCode.Bulk reports NPE exception [v2]

2025-03-24 Thread duke
On Thu, 20 Mar 2025 23:39:24 GMT, Vladimir Ivanov wrote: >> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently >> these tests using empty data set that looks bad. > > Vladimir Ivanov has updated the pull request incrementally with one > additional commit since the last

Withdrawn: 4452735: Add GZIPOutputStream constructor to specify Deflater

2025-03-22 Thread duke
On Wed, 17 Jul 2024 21:07:23 GMT, Archie Cobbs wrote: > The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater`

Withdrawn: 8344911: Introduce test utility for asserting file open status

2025-03-21 Thread duke
On Sat, 23 Nov 2024 15:47:53 GMT, Eirik Bjørsnøs wrote: > Please review this PR which adds a utility API in the test libraries to > assert whether a file is currently open. > > Several OpenJDK tests currently rely on approximations to check this, > including deletion (fails only on Windows),

Withdrawn: 8346230: [perf] scalability issue for the specjvm2008::xml.transform workload

2025-03-18 Thread duke
On Fri, 17 Jan 2025 23:08:20 GMT, Vladimir Ivanov wrote: > The HashMap for caching was deleted. Now it use only ThreadLocal variable > without synchronization. > According to the specjvm2008::xml.transform workload the performance for low > threads counts was not affected and improved for high

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v14]

2025-03-13 Thread duke
On Fri, 7 Mar 2025 06:19:03 GMT, Galder Zamarreño wrote: >> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in >> order to help improve vectorization performance. >> >> Currently vectorization does not kick in for loops containing either of >> these calls because of t

Withdrawn: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

2025-03-12 Thread duke
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote: > Seems sensible to improve this given that it can be tricky to figure out > which parameter caused the exception to be thrown. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-11 Thread duke
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Withdrawn: 8347471: Provide valid flags and mask in AccessFlag.Location

2025-03-11 Thread duke
On Tue, 14 Jan 2025 07:38:30 GMT, Chen Liang wrote: > Some AccessFlag parsing methods throw IAE because a flag mask is not valid in > a location. However, there is no easy way to check what flag mask bits or > what flags are valid for a location. We need such APIs to check, specific to > each

Withdrawn: 8316882: Add NOT_INTERRUPTIBLE OpenOption and use it in ZipFS

2025-03-07 Thread duke
On Wed, 25 Dec 2024 23:55:18 GMT, Bruno Ploumhans wrote: > Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882. > > Following discussion in nio-dev a while ago, I have opted to add a new > `NOT_INTERRUPTIBLE` open option, superseding > `FileChannelImpl#setUninterruptible`. This pull

Re: RFR: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 [v2]

2025-03-06 Thread duke
On Tue, 4 Mar 2025 19:37:32 GMT, Vladimir Ivanov wrote: >> test setup was updated to generate data of requested size. > > Vladimir Ivanov has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8350811 [JMH] test foreign.StrLenTest failed with

Withdrawn: 8345687: Improve the implementation of SegmentFactories::allocateSegment

2025-03-06 Thread duke
On Fri, 6 Dec 2024 16:30:47 GMT, Quan Anh Mai wrote: > Hi, > > This patch improves the performance of a typical `Arena::allocate` in several > ways: > > - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of > the instance with the one obtained from the call in the unco

Re: RFR: 8350909: [JMH] test ThreadOnSpinWaitShared failed for 2 threads config

2025-03-06 Thread duke
On Fri, 28 Feb 2025 01:20:44 GMT, Vladimir Ivanov wrote: > The scope was updated to support multithread configuration (jmh option '-t > 2') . No other changes needed. @IvaVladimir Your change (at version 2b70cd408597bbfd0a2f490714a7ebab8eceb1f6) is now ready to be sponsored by a Committer. -

Re: RFR: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException [v2]

2025-03-05 Thread duke
On Wed, 26 Feb 2025 07:04:58 GMT, Nicole Xu wrote: >> Suite `MaskedLogicOpts.maskedLogicOperationsLong512()` failed on both x86 >> and AArch64 with the following error: >> >> >> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249 >> >> >> The variable `long256_arr_idx

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v17]

2025-03-04 Thread duke
On Fri, 28 Feb 2025 20:40:37 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Re: RFR: 8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024

2025-03-03 Thread duke
On Tue, 25 Feb 2025 19:06:05 GMT, Vladimir Ivanov wrote: > Array initialization by parameter was added. Extra constant was used to align > cycle step with used arrays. @IvaVladimir Your change (at version 6f3450752f812bbc5fea4fdd9ecf2e9110c94229) is now ready to be sponsored by a Committer.

Re: RFR: 8350701: [JMH] test foreign.AllocFromSliceTest failed with Exception for size>1024

2025-02-27 Thread duke
On Tue, 25 Feb 2025 21:35:22 GMT, Vladimir Ivanov wrote: > The 'size' parameters was used instead of hardcoded constant to improve > support for different sizes. @IvaVladimir Your change (at version b45da29c5bf50c5961f59500cd22d84a35a09be4) is now ready to be sponsored by a Committer. --

Withdrawn: 8328821: Map.of() derived view collection mutators should throw UnsupportedOperationException

2025-02-27 Thread duke
On Wed, 27 Mar 2024 17:36:28 GMT, Liam Miller-Cushon wrote: > This change overrides mutator methods in the implementation returned by > `Map.of().entrySet()` to throw `UnsupportedOperationException`. This pull request has been closed without being integrated. - PR: https://git.ope

Re: RFR: 8349943: [JMH] Use jvmArgs consistently

2025-02-19 Thread duke
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote: > As is suggested in > [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should > be used consistently in microbenchmarks to 'align with the intuition that > when you use jvmArgsAppend/-Prepend intent is to add to a set of

Withdrawn: 8310996: Add JFR event for connect operations

2025-02-17 Thread duke
On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote: > Adds a JFR event for socket connect operations. > > Existing tests TestSocketEvents and TestSocketChannelEvents modified to also > check for connect events. This pull request has been closed without being integrated. - PR: h

Withdrawn: 8342869: Errors related to unused code on Windows after 8339120 in awt

2025-02-17 Thread duke
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse

Withdrawn: 8342486: Implement JEP draft: Structured Concurrency (Fifth Preview)

2025-02-17 Thread duke
On Wed, 6 Nov 2024 15:47:55 GMT, Alan Bateman wrote: > Changes for [JEP draft: Structured Concurrency (Fifth > Preview)](https://openjdk.org/jeps/8340343). The JEP isn't on the technical > roadmap yet. The proposal is to re-preview the API with some changes, > specifically: > > - A > [Struct

Withdrawn: 8316804: Gracefully handle the case where --release is not specified last

2025-02-14 Thread duke
On Wed, 13 Nov 2024 15:24:43 GMT, Christian Stein wrote: > Please review this change for the `jar` tool to gracefully handle the case > where `--release` is not specified as the last arguments. > > Prior to this commit, operation modes `-d --describe-module` and `--validate` > expected to read

Re: RFR: 8344802: Crash in StubRoutines::verify_mxcsr with -XX:+EnableX86ECoreOpts and -Xcheck:jni [v7]

2025-02-12 Thread duke
On Wed, 12 Feb 2025 15:47:04 GMT, Volodymyr Paprotski wrote: >> (Also see `8319429: Resetting MXCSR flags degrades ecore`) >> >> This PR fixes two issues: >> - the original issue is a crash caused by `__ warn` corrupting the stack on >> Windows only >> - This issue also uncovered that -Xcheck:

Re: RFR: 8344802: Crash in StubRoutines::verify_mxcsr with -XX:+EnableX86ECoreOpts and -Xcheck:jni [v6]

2025-02-12 Thread duke
On Tue, 11 Feb 2025 21:47:31 GMT, Volodymyr Paprotski wrote: >> (Also see `8319429: Resetting MXCSR flags degrades ecore`) >> >> This PR fixes two issues: >> - the original issue is a crash caused by `__ warn` corrupting the stack on >> Windows only >> - This issue also uncovered that -Xcheck:

Withdrawn: 8342035: jlink plugins for setting java.vendor, java.vm.vendor and java.vendor.url

2025-02-08 Thread duke
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote: > Add jlink plugins to allow branding change for java.vendor, java.vm.vendor > and java.vendor.url. > > The jlink plugin will change the value in java.lang.VersionProps, which will > set those property values. The `java.vm.vendor` was initializ

Withdrawn: 8340380: Improve source launcher's shebang script detection

2025-02-07 Thread duke
On Tue, 5 Nov 2024 16:16:13 GMT, Christian Stein wrote: > Please review this change that improves the launcher mode detection by > reading the initial two characters from the started file for being a shebang > script. It addresses the reported confusing error messages and also supports > more

Re: RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v6]

2025-02-07 Thread duke
On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote: >> Adds `test.lib.Utils::createTempFileOfSize` to generate >> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory >> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file >> tracked by git: >> >>

Withdrawn: 8344246: Unnecessary Hashtable usage in EventSupport.notifiers

2025-02-03 Thread duke
On Tue, 5 Nov 2024 08:28:10 GMT, Andrey Turbanov wrote: > The field `com.sun.jndi.ldap.EventSupport#notifiers` is always accessed under > `lock`. It means extra synchronization from `Hashtable` is not needed. > Subtle difference in Hashtable vs Hashmap behavior is that Hashtable doesn't > allow

Withdrawn: 8242888: Convert dynamic proxy to hidden classes

2025-01-31 Thread duke
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote: > Please review this change that adds a new dynamic proxies implementation as > hidden classes. > > Summary: > 1. Adds new implementation which can be `-Djdk.reflect.useHiddenProxy=true` > for early adoption. > 2. ClassLoader.defineClass0 tak

Withdrawn: 8329251: Print custom truststore/ keystore name

2025-01-31 Thread duke
On Thu, 1 Aug 2024 04:11:24 GMT, Prasadrao Koppula wrote: > This patch aims to enhance observability by logging the keystore's name at > the TrustManagerFactory and KeyStore level across all keystore types and the > default SSL implementation. It ensures that whenever an API user supplies a >

Re: RFR: 8287788: Implement a better allocator for downcalls [v18]

2025-01-27 Thread duke
On Thu, 23 Jan 2025 17:36:11 GMT, Matthias Ernst wrote: >> Certain signatures for foreign function calls (e.g. HVA return by value) >> require allocation of an intermediate buffer to adapt the FFM's to the >> native stub's calling convention. In the current implementation, this buffer >> is ma

Re: RFR: 8347994: Add additional diagnostics to macOS failure handler to assist with diagnosing MCast test failures

2025-01-23 Thread duke
On Thu, 23 Jan 2025 10:38:50 GMT, serhiysachkov wrote: > Add additional diagnostics to macOS failure handler to assist with diagnosing > MCast test failures @serhiysachkov Your change (at version 3a7f43ef409e09bbf818a9f43dee1f544538b104) is now ready to be sponsored by a Committer. -

Re: RFR: 8347965: (tz) Update Timezone Data to 2025a

2025-01-22 Thread duke
On Tue, 21 Jan 2025 13:03:45 GMT, Johny Jose wrote: > Changes to Update Timezone Data to 2025a @johnyjose30 Your change (at version 20715329faf466ba6f7fb748f35fb2a4ff22c53e) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jdk/pull/23212#issuecom

Withdrawn: 8337199: Add jcmd Thread.vthread_summary diagnostic command

2025-01-21 Thread duke
On Thu, 14 Nov 2024 21:34:08 GMT, Larry Cable wrote: > c.f: > [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420) > > Summary > --- > > Add `jcmd Thread.vthread_summary` to print summary information that is > useful when trying to diagnose issues wi

Withdrawn: 8342775: [Graal] java/util/concurrent/locks/Lock/OOMEInAQS.java fails OOME thrown from the UncaughtExceptionHandler

2025-01-20 Thread duke
On Mon, 28 Oct 2024 18:45:59 GMT, Tom Rodriguez wrote: > Deoptimization with escape analysis can fail when trying to rematerialize > objects as described in JDK-8227309. In this test this can happen in Xcomp > mode in the framework of the test resulting in a test failure. Making the > number

Withdrawn: 8344191: Build code should not have classpath exception

2025-01-15 Thread duke
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote: > In several (most? all?) of the build system files, the copyright header > includes the classpath exception. This makes no sense, and should be removed. > > I have removed the classpath exception from makefiles, autoconf, shell > sc

Re: RFR: 8346142: [perf] scalability issue for the specjvm2008::xml.validation workload [v2]

2025-01-14 Thread duke
On Fri, 13 Dec 2024 02:18:35 GMT, Vladimir Ivanov wrote: >> The double check needs less time vs enter to 'synchronize' block when it not >> needed. This patch for the xml.validation workload for runs with 112 threads >> reports ~2.5% improvement on the server with Xeon 8480: >> orig: 1T - 433.6

  1   2   3   4   >