On Tue, 25 Feb 2025 08:27:26 GMT, Per Minborg wrote:
> As we advance, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a `MemorySegment` to capture potential error states. This can lead
> to nega
On Sat, 4 Jan 2025 10:24:15 GMT, Shaojin Wen wrote:
> This is an optimization for decimal Integer.parseInt and Long.parseLong,
> which improves performance by about 10%. The optimization includes:
> 1. Improve performance by parsing 2 numbers at a time, which has performance
> improvements for
On Wed, 16 Apr 2025 17:40:39 GMT, Johannes Graham wrote:
>> The `DigitList` class used in `DecimalFormat` does not reset the `data`
>> array in its clone method. This can cause interference when clones are used
>> concurrently.
>
> Johannes Graham has updated the pull request incrementally with
On Wed, 19 Feb 2025 09:22:09 GMT, Per Minborg wrote:
> This PR proposes to make all imports consistent in the FFM API tests and
> benchmarks.
>
> This is a follow-up PR from https://github.com/openjdk/jdk/pull/22827
>
> Passes tier1-3
This pull request has been closed without being integrated
On Tue, 8 Apr 2025 08:50:37 GMT, kabutz wrote:
> One of the features of the LinkedBlockingDeque is that it is a doubly-linked
> node queue, with pointers in each node to "prev" and "next", which allows
> remove() in the Iterator to remove the node in constant time. However, in the
> JavaDoc of
On Mon, 14 Apr 2025 15:22:21 GMT, Vladimir Ivanov wrote:
>> The HashMap for caching was deleted. Now it use only ThreadLocal variable
>> without synchronization.
>> According to the specjvm2008::xml.transform workload the performance for low
>> threads counts was not affected and improved for h
On Mon, 14 Apr 2025 10:56:45 GMT, David Beaumont wrote:
> Add null pointer guard in test formatter (since it can be called with a log
> record without parameters).
@david-beaumont
Your change (at version 67bea85bb13c3a7c46d28a458230a2a8e51e7f4d) is now ready
to be sponsored by a Committer.
-
On Tue, 8 Apr 2025 11:00:27 GMT, David Beaumont wrote:
> 8353683: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
On Sun, 6 Apr 2025 08:09:27 GMT, Zihao Lin wrote:
>> Modify the cache in MethodTypeForm that currently stores the LF_INTERPRET
>> Lambda form. Instead of caching the entire LambdaForm, change it to store a
>> SoftReference. This will avoid unnecessary memory usage.
>
> Zihao Lin has updated the
On Fri, 28 Mar 2025 18:24:49 GMT, fabioromano1 wrote:
>> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
>> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>>
>> The main steps of the algorithm are as follows:
>> first argument reduce the value to an i
On Tue, 8 Apr 2025 13:51:59 GMT, Danish Nawab wrote:
>> ## Description
>>
>> https://bugs.openjdk.org/browse/JDK-8353840
>>
>> ### Existing behavior
>> Log the error message and terminate in case of missing system class
>>
>>
>> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit c
On Thu, 17 Oct 2024 00:05:26 GMT, Brian Burkhalter wrote:
> Improve support for Windows directory junctions.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21555
On Wed, 2 Apr 2025 21:59:32 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affec
On Wed, 15 Jan 2025 14:26:32 GMT, Aviad Zer wrote:
> This change extends the Math.min function to support multiple parameters,
> improving its usability and code readability.
>
> Previously, finding the minimum value among multiple variables required using
> nested Math.min calls or converting
On Wed, 5 Feb 2025 10:17:09 GMT, Per Minborg wrote:
> This PR proposes to add some `@ForceInline` annotations in the `Module` class
> in order to assist inlining of FFM var/method handles.
>
> There are also some changes in other classes (notably `j.l.Object`) which, if
> implemented, can take
On Thu, 23 Jan 2025 15:23:37 GMT, Kevin Walls wrote:
> java.util.logging.LoggingMXBean and
> java.util.logging.LogManager::getLoggingMXBean are deprecated since
> JDK-8139982 in JDK 9.
>
> These deprecations should be uprated to state they are for future removal.
>
> java.util.logging.Logging
On Thu, 2 Jan 2025 17:13:17 GMT, David M. Lloyd wrote:
> When loading services by class loader
> (`ServiceLoader.load(Class,ClassLoader)`), the module layers bound to the
> given class loader are searched for services, along with the layers bound to
> class loader's parent, and so on. For non-
On Fri, 31 Jan 2025 09:47:35 GMT, Fabian Meumertzheim wrote:
> `URLClassPath` called into `ParseUtil.fileToEncodedURL`, which misencoded
> characters with a four byte UTF-8 representation. Replacing that function
> with `toPath().toUri().toURL()` (and removing it, since its only used once)
> r
On Mon, 24 Mar 2025 19:34:55 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Tue, 25 Mar 2025 13:00:44 GMT, Mikhail Yankelevich
wrote:
>> Updating `jdk.test.lib.SecurityTools` class to have jar method accept
>> `List` parameter similar to `keytool` methods.
>> Currently this only accept String parameter, which is error prone with
>> missing space
>
> Mikhail Yankele
On Thu, 20 Mar 2025 23:39:24 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 17 Jul 2024 21:07:23 GMT, Archie Cobbs wrote:
> The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical
> because the GZIP encoding is based on ZLIB "deflate" encoding.
>
> However, while `DeflaterOutputStream` provides constructors that take a
> custom `Deflater`
On Sat, 23 Nov 2024 15:47:53 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds a utility API in the test libraries to
> assert whether a file is currently open.
>
> Several OpenJDK tests currently rely on approximations to check this,
> including deletion (fails only on Windows),
On Fri, 17 Jan 2025 23:08:20 GMT, Vladimir Ivanov wrote:
> The HashMap for caching was deleted. Now it use only ThreadLocal variable
> without synchronization.
> According to the specjvm2008::xml.transform workload the performance for low
> threads counts was not affected and improved for high
On Fri, 7 Mar 2025 06:19:03 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of t
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote:
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Greg Lew
On Tue, 14 Jan 2025 07:38:30 GMT, Chen Liang wrote:
> Some AccessFlag parsing methods throw IAE because a flag mask is not valid in
> a location. However, there is no easy way to check what flag mask bits or
> what flags are valid for a location. We need such APIs to check, specific to
> each
On Wed, 25 Dec 2024 23:55:18 GMT, Bruno Ploumhans wrote:
> Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882.
>
> Following discussion in nio-dev a while ago, I have opted to add a new
> `NOT_INTERRUPTIBLE` open option, superseding
> `FileChannelImpl#setUninterruptible`.
This pull
On Tue, 4 Mar 2025 19:37:32 GMT, Vladimir Ivanov wrote:
>> test setup was updated to generate data of requested size.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8350811 [JMH] test foreign.StrLenTest failed with
On Fri, 6 Dec 2024 16:30:47 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch improves the performance of a typical `Arena::allocate` in several
> ways:
>
> - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of
> the instance with the one obtained from the call in the unco
On Fri, 28 Feb 2025 01:20:44 GMT, Vladimir Ivanov wrote:
> The scope was updated to support multithread configuration (jmh option '-t
> 2') . No other changes needed.
@IvaVladimir
Your change (at version 2b70cd408597bbfd0a2f490714a7ebab8eceb1f6) is now ready
to be sponsored by a Committer.
-
On Wed, 26 Feb 2025 07:04:58 GMT, Nicole Xu wrote:
>> Suite `MaskedLogicOpts.maskedLogicOperationsLong512()` failed on both x86
>> and AArch64 with the following error:
>>
>>
>> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>>
>>
>> The variable `long256_arr_idx
On Fri, 28 Feb 2025 20:40:37 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Tue, 25 Feb 2025 19:06:05 GMT, Vladimir Ivanov wrote:
> Array initialization by parameter was added. Extra constant was used to align
> cycle step with used arrays.
@IvaVladimir
Your change (at version 6f3450752f812bbc5fea4fdd9ecf2e9110c94229) is now ready
to be sponsored by a Committer.
On Tue, 25 Feb 2025 21:35:22 GMT, Vladimir Ivanov wrote:
> The 'size' parameters was used instead of hardcoded constant to improve
> support for different sizes.
@IvaVladimir
Your change (at version b45da29c5bf50c5961f59500cd22d84a35a09be4) is now ready
to be sponsored by a Committer.
--
On Wed, 27 Mar 2024 17:36:28 GMT, Liam Miller-Cushon wrote:
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
This pull request has been closed without being integrated.
-
PR: https://git.ope
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is to add to a set of
On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote:
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
This pull request has been closed without being integrated.
-
PR: h
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Wed, 6 Nov 2024 15:47:55 GMT, Alan Bateman wrote:
> Changes for [JEP draft: Structured Concurrency (Fifth
> Preview)](https://openjdk.org/jeps/8340343). The JEP isn't on the technical
> roadmap yet. The proposal is to re-preview the API with some changes,
> specifically:
>
> - A
> [Struct
On Wed, 13 Nov 2024 15:24:43 GMT, Christian Stein wrote:
> Please review this change for the `jar` tool to gracefully handle the case
> where `--release` is not specified as the last arguments.
>
> Prior to this commit, operation modes `-d --describe-module` and `--validate`
> expected to read
On Wed, 12 Feb 2025 15:47:04 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
On Tue, 11 Feb 2025 21:47:31 GMT, Volodymyr Paprotski
wrote:
>> (Also see `8319429: Resetting MXCSR flags degrades ecore`)
>>
>> This PR fixes two issues:
>> - the original issue is a crash caused by `__ warn` corrupting the stack on
>> Windows only
>> - This issue also uncovered that -Xcheck:
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
On Tue, 5 Nov 2024 16:16:13 GMT, Christian Stein wrote:
> Please review this change that improves the launcher mode detection by
> reading the initial two characters from the started file for being a shebang
> script. It addresses the reported confusing error messages and also supports
> more
On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote:
>> Adds `test.lib.Utils::createTempFileOfSize` to generate
>> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
>> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
>> tracked by git:
>>
>>
On Tue, 5 Nov 2024 08:28:10 GMT, Andrey Turbanov wrote:
> The field `com.sun.jndi.ldap.EventSupport#notifiers` is always accessed under
> `lock`. It means extra synchronization from `Hashtable` is not needed.
> Subtle difference in Hashtable vs Hashmap behavior is that Hashtable doesn't
> allow
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote:
> Please review this change that adds a new dynamic proxies implementation as
> hidden classes.
>
> Summary:
> 1. Adds new implementation which can be `-Djdk.reflect.useHiddenProxy=true`
> for early adoption.
> 2. ClassLoader.defineClass0 tak
On Thu, 1 Aug 2024 04:11:24 GMT, Prasadrao Koppula wrote:
> This patch aims to enhance observability by logging the keystore's name at
> the TrustManagerFactory and KeyStore level across all keystore types and the
> default SSL implementation. It ensures that whenever an API user supplies a
>
On Thu, 23 Jan 2025 17:36:11 GMT, Matthias Ernst wrote:
>> Certain signatures for foreign function calls (e.g. HVA return by value)
>> require allocation of an intermediate buffer to adapt the FFM's to the
>> native stub's calling convention. In the current implementation, this buffer
>> is ma
On Thu, 23 Jan 2025 10:38:50 GMT, serhiysachkov wrote:
> Add additional diagnostics to macOS failure handler to assist with diagnosing
> MCast test failures
@serhiysachkov
Your change (at version 3a7f43ef409e09bbf818a9f43dee1f544538b104) is now ready
to be sponsored by a Committer.
-
On Tue, 21 Jan 2025 13:03:45 GMT, Johny Jose wrote:
> Changes to Update Timezone Data to 2025a
@johnyjose30
Your change (at version 20715329faf466ba6f7fb748f35fb2a4ff22c53e) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.org/jdk/pull/23212#issuecom
On Thu, 14 Nov 2024 21:34:08 GMT, Larry Cable wrote:
> c.f:
> [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420)
>
> Summary
> ---
>
> Add `jcmd Thread.vthread_summary` to print summary information that is
> useful when trying to diagnose issues wi
On Mon, 28 Oct 2024 18:45:59 GMT, Tom Rodriguez wrote:
> Deoptimization with escape analysis can fail when trying to rematerialize
> objects as described in JDK-8227309. In this test this can happen in Xcomp
> mode in the framework of the test resulting in a test failure. Making the
> number
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote:
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> sc
On Fri, 13 Dec 2024 02:18:35 GMT, Vladimir Ivanov wrote:
>> The double check needs less time vs enter to 'synchronize' block when it not
>> needed. This patch for the xml.validation workload for runs with 112 threads
>> reports ~2.5% improvement on the server with Xeon 8480:
>> orig: 1T - 433.6
On Mon, 14 Oct 2024 20:31:51 GMT, Kevin Bourrillion wrote:
> 8342566: Improve javadoc of java.lang.annotation.ElementType
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21506
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström
wrote:
>> Could I get a review of this fix to refine the warnings printed by `libjsig`
>> when using the deprecated `signal()`/`sigset()` functions?
>>
>> Currently the libjsig library supports chaining `signal()` and `sigset()`.
>> With these
On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Tue, 16 Jul 2024 18:02:57 GMT, Chen Liang wrote:
> In annotated types, local and inner class types should be annotated as
> "top-level" types. For example, in the test here
>
> public static Class getLocalsMember() {
> class Local {
> class Member {
>
On Mon, 11 Nov 2024 11:55:27 GMT, Per Minborg wrote:
> This PR proposes to add a new `MemorySegment::fill" benchmark where the byte
> size of the segments varies.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/22010
On Wed, 12 Jun 2024 14:02:58 GMT, Thomas Fitzsimmons wrote:
> 8334048: -Xbootclasspath can not read some ZIP64 zip files
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/19678
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some files, mostly in comments, docs
>> and man pages.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW M
On Wed, 6 Nov 2024 14:15:42 GMT, jengebr wrote:
> This change optimizes the runtime of `Class.getMethod(String, Class[])` by
> reducing the cost of the existing search logic. Specifically, while
> iterating across each Method to find a match (existing logic) it now compares
> parameter count
On Tue, 5 Nov 2024 20:16:09 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8339890](https://bugs.openjdk.org/browse/JDK-8339890)
> where vm flags specified via javaopts were getting ignored. I added the flags
> to the test.
>
> Thanks,
> Sonia
This pull request has bee
On Fri, 5 Jul 2024 15:40:24 GMT, Shaojin Wen wrote:
> String.format is widely used, and improving its performance is very
> meaningful. This PR can significantly improve the performance of
> String.format. Sorry, there are many changes, which will take a lot of time.
> I hope you can review it
On Sat, 29 Jun 2024 11:53:31 GMT, Shaojin Wen wrote:
> We need a String format solution with good performance. String Template was
> once expected, but it has been removed. j.u.Formatter is powerful, but its
> performance is not good enough.
>
> This PR implements a subset of j.u.Formatter cap
On Thu, 31 Oct 2024 03:52:16 GMT, Ioi Lam wrote:
> When lots of classes are loaded during `java -Xshare:dump`, the internal
> arrays used by some of the HashMaps and ArrayLists become too large to be
> archived by CDS (> 256KB).
>
> At the very end of Java bytecode execution during `java -Xsha
On Tue, 17 Dec 2024 08:04:25 GMT, Sorna Sarathi N wrote:
> Hi all,
>
> This pull request contains a backport of
> [openjdk/jdk#22704](https://github.com/openjdk/jdk/pull/22704.)
>
> The commit being backported was authored by Sorna Sarathi on 13 Dec 2024 and
> was reviewed by Amit Kumar, Alex
On Tue, 17 Dec 2024 07:49:31 GMT, Sorna Sarathi N wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [458979d8](https://github.com/openjdk/jdk/commit/458979d83ac784273263b54516369d79764010dd)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Thu, 19 Dec 2024 12:38:27 GMT, liyazzi wrote:
>> For two cases:
>>
>> 1. When the ImageReaderFactory was loaded by local jdk,that means the
>> ImageReaderFactory was loaded by boot class loader,then init the `Path
>> BOOT_MODULES_JIMAGE` by using `sun.nio.fs.DefaultFileSystemProvider` which
On Tue, 15 Oct 2024 17:34:53 GMT, Chen Liang wrote:
> Currently, to efficiently check if a `ClassEntry`, such as one from an
> `InvokeInstruction`, is of a particular class, we use such a pattern (as seen
> in JEP 486 [Appendix](https://openjdk.org/jeps/486#Appendix)):
>
> inst.owner().name().
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
On Tue, 17 Dec 2024 13:45:02 GMT, Jan Kratochvil
wrote:
> There are 2 typos and I find the API a bit complex so it does not help a new
> perplexed user of the API to be additionally confused by typos.
@jankratochvil
Your change (at version c2f74d95ef3bd6c32eb24a4656fe164ff131a679) is now read
On Sun, 20 Oct 2024 23:15:44 GMT, Shaojin Wen wrote:
> Set the default value of DirectCodeBuilder::handlers to Null to reduce
> overhead in scenarios where there is no handler.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21598
On Wed, 11 Dec 2024 15:55:00 GMT, Ivan Šipka wrote:
>> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore
>> @JornVernee
>>
>> adding as manual tests
>
> Ivan Šipka has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - reve
On Fri, 11 Oct 2024 08:11:37 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which removes overrides of
> `InflaterInputStream.fill` in `ZipFileInflaterInputStream` and
> `ZipFileSystem::getInputStream`. Associated boolean fields used to track
> `eof` are also removed.
>
> These ov
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote:
> I am getting the `Duplication annotation for class` error as mentioned in
> https://hibernate.atlassian.net/browse/HHH-18901. The current error message
> does not include the application class name (e.g. container) that the
> specified an
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception in several files.
>
> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
@Sorna-Sarathi
Your change (at version 84398ccf8d3ee2b584dfaeaed094d109f89108b4) is now ready
to be spo
On Wed, 10 Jul 2024 22:33:54 GMT, Joe Darcy wrote:
> First pass at adding some quality of implementation discussions around the
> overridable methods of Object.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/20128
On Tue, 27 Aug 2024 10:09:09 GMT, Shaojin Wen wrote:
> The string concatenation of the java.base module is implemented using
> StringBuilder. By providing a series of concat methods in StringConcatHelper,
> it is used in the java.lang package to replace string concatenation.
>
> These concat m
On Tue, 24 Sep 2024 13:31:25 GMT, Eirik Bjørsnøs wrote:
> Please consider this PR which makes `ZipFileInflaterInputStream` release its
> `Inflater` instance back to the pool when observing that the stream has been
> fully consumed.
>
> This is motivated by the following observations:
>
> * Af
On Mon, 30 Sep 2024 08:02:16 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed c
On Fri, 26 Jul 2024 14:20:07 GMT, Shaojin Wen wrote:
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
This pull request has been closed without being integrated.
-
On Fri, 30 Aug 2024 07:27:11 GMT, Eirik Bjørsnøs wrote:
> Please review this PR with picks up on the excellent work done by
> @archiecobbs in #18385
>
> The proposed changes aim to solve two issues with the current
> `java.util.zip.GZIPInputStream`:
>
> * The class parses multiple concatenat
On Thu, 28 Nov 2024 11:33:43 GMT, Jonathan Lampérth wrote:
> This PR includes a suggested change in behaviour of `javap -l` without `-v`
> or `-c`.
> Previously it was possible to print `LineNumberTable` and
> `LocalVariableTable` without disassembled code output. This didn't make much
> sense
On Tue, 26 Nov 2024 08:57:04 GMT, Jonathan Lampérth wrote:
>> Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066
>>
>> This PR includes changes to ensure the indentation of `LineNumberTable` and
>> `LocalVariableTable` behave in the same way both for the `javap -verbose`
On Mon, 21 Oct 2024 14:13:35 GMT, David M. Lloyd wrote:
>> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a
>> `Runnable`, which is consumed by a `Consumer` (instantiated within
>> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a
>> number of
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is output on localized windows platforms.
>>
>> I have refe
On Thu, 7 Nov 2024 18:30:22 GMT, Vladimir Ivanov wrote:
>> The synchronization block may be substituted by the 'volatile' variable
>> smaller synchronization block.
>> It reduce the total blocking time for the specjvm2008::xml.validation
>> workload and improve the reported score.
>> Scores for
On Tue, 19 Nov 2024 19:33:18 GMT, kabutz wrote:
> See internal bug review 9077848
>
> This is a very small unimportant mistake in the naming of the documentation
> that does not match the code.
@kabutz
Your change (at version 2817981d67c561580f262c049384be6f7fe6520f) is now ready
to be spons
On Thu, 14 Nov 2024 15:10:37 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote:
>> As the documentation of getCeilingEntry currently reads, the inference is
>> misleading as follows:
>>
>> if no such entry exists, returns the entry for the least key greater than
>> the specified key;
>> if no such entry exists (i.e., th
On Fri, 20 Sep 2024 00:33:39 GMT, Weijun Wang wrote:
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow
On Tue, 12 Nov 2024 16:12:36 GMT, kabutz wrote:
>> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to
>> the head, which has item == null, rather than to the first element. The
>> trySplit() method no longer worked, and always returned null. Therefore,
>> parallel strea
On Wed, 30 Oct 2024 08:54:55 GMT, kabutz wrote:
> The ArrayBlockingQueue has had a readObject() method since Java 7, which
> checks invariants of the deserialized object. However, it does not have a
> writeObject() method. This means that the ArrayBlockingQueue could be
> modified whilst it is
On Fri, 25 Oct 2024 09:28:53 GMT, Jonathan Lampérth wrote:
>> This PR includes changes to ensure `Code:` block indentation in `javap`for
>> the `-verbose` case and non `-verbose` case is the same, which currently
>> does not hold.
>>
>> Current behaviour of `javap` differs with and without `-v
On Thu, 29 Aug 2024 01:30:55 GMT, Shaojin Wen wrote:
> A small optimization to simplify the implementation logic of
> LambdaForm$BasicType#basicType method can reduce the call stack and reduce
> the overall bytecode size.
>
> Below is the compiler log
>
> * baseline
>
> @ 1 java.lang.invo
On Sat, 24 Aug 2024 10:49:56 GMT, Eirik Bjørsnøs wrote:
> Please review this refactoring PR which moves the `ZipEntry.flag` field back
> to `ZipOutputStream.XEntry`.
>
> Moving this field will save four bytes from the `ZipEntry` object size and
> also saves an unneccessary read in `ZipFile.get
1 - 100 of 322 matches
Mail list logo
