Re: RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform [v4]

2024-11-25 Thread Victor Dyakov
On Wed, 20 Nov 2024 18:13:22 GMT, Alexey Semenyuk wrote: >> Taizo Kurashige has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix about size of cmdline > > Thank you for working on this patch! @alexeysemenyukoracle could you please spons

Re: RFR: 8322041: JDK 22 RDP1 L10n resource files update

2023-12-13 Thread Victor Dyakov
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote: > Translation drop for JDK22 RDP1 @alexeysemenyukoracle please review jpackage part - PR Comment: https://git.openjdk.org/jdk/pull/17096#issuecomment-1854847266

Re: RFR: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild

2023-10-16 Thread Victor Dyakov
On Fri, 6 Oct 2023 22:15:00 GMT, Alexander Matveev wrote: > - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` > CLI options to jpackage to provide signing identity directly to `codesign` > and `productbuild` tools as per CSR > [JDK-8316631](https://bugs.openjdk.org/br

Re: [jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG

2022-06-30 Thread Victor Dyakov
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev wrote: > Fixed 3 issues which made signature invalid: > - We should not remove .jpackage.xml from signed app image when creating DMG > or PKG otherwise it invalidates signature. > - .package should be created when app image is generated, so th