Integrated: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state

2023-10-03 Thread Swati Sharma
On Thu, 10 Aug 2023 15:30:19 GMT, Swati Sharma wrote: > In addition to the issue > [JDK-8311178](https://bugs.openjdk.org/browse/JDK-8311178), logically fixing > the scope from benchmark to thread for below benchmark files having shared > state, also which fixes few of th

Re: RFR: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state

2023-08-22 Thread Swati Sharma
On Thu, 10 Aug 2023 15:30:19 GMT, Swati Sharma wrote: > In addition to the issue > [JDK-8311178](https://bugs.openjdk.org/browse/JDK-8311178), logically fixing > the scope from benchmark to thread for below benchmark files having shared > state, also which fixes few of th

RFR: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state

2023-08-10 Thread Swati Sharma
In addition to the issue [JDK-8311178](https://bugs.openjdk.org/browse/JDK-8311178), logically fixing the scope from benchmark to thread for below benchmark files having shared state, also which fixes few of the benchmarks scalability problems. org/openjdk/bench/java/io/DataInputStreamTest.java

Integrated: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-11 Thread Swati Sharma
On Sat, 1 Jul 2023 07:53:17 GMT, Swati Sharma wrote: > The below benchmark files have scaling issues due to cache contention and > leads to poor scaling when run on multiple threads. The patch sets the scope > from benchmark level to thread level to fix the issue: > - org/openjdk/b

Re: RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-11 Thread Swati Sharma
On Wed, 5 Jul 2023 14:39:08 GMT, Eric Caspole wrote: >> The below benchmark files have scaling issues due to cache contention and >> leads to poor scaling when run on multiple threads. The patch sets the scope >> from benchmark level to thread level to fix the issue: >> - org/openjdk/bench/java

Re: RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-11 Thread Swati Sharma
On Mon, 10 Jul 2023 16:07:44 GMT, John Jiang wrote: > Not review this PR, but just raise a question. Should a JMH test, at least in > JDK repo, always uses `@State(Scope.Thread)`, even though it uses only one > thread? > > I just looked through those JMH tests, and found all of them, like the

Re: RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-08 Thread Swati Sharma
On Sat, 1 Jul 2023 07:53:17 GMT, Swati Sharma wrote: > The below benchmark files have scaling issues due to cache contention and > leads to poor scaling when run on multiple threads. The patch sets the scope > from benchmark level to thread level to fix the issue: > - org/openjdk/b

Re: RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-03 Thread Swati Sharma
On Sat, 1 Jul 2023 19:05:23 GMT, Sergey Tsypanov wrote: >> The below benchmark files have scaling issues due to cache contention and >> leads to poor scaling when run on multiple threads. The patch sets the scope >> from benchmark level to thread level to fix the issue: >> - org/openjdk/bench/j

RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-01 Thread Swati Sharma
The below benchmark files have scaling issues due to cache contention and leads to poor scaling when run on multiple threads. The patch sets the scope from benchmark level to thread level to fix the issue: - org/openjdk/bench/java/io/DataOutputStreamTest.java - org/openjdk/bench/java/lang/ArrayCo