Re: RFR: 8333582: Update CLDR to Version 46.0

2024-10-30 Thread Steven Loomis
On Tue, 29 Oct 2024 18:12:43 GMT, Naoto Sato wrote: > Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted. Spot checked the data and tests. Checked the provider changes, all LGTM. - Marked as reviewed by srl (Committer). PR Review: https://git.openjdk.org

Re: RFR: 8341684: Typo in External Specifications link of java.util.Currency [v2]

2024-10-09 Thread Steven Loomis
On Wed, 9 Oct 2024 00:08:30 GMT, Justin Lu wrote: >> A trivial correction to the _j.util.Currency_ external specification ISO >> currency codes link. Browsers will auto resolve and correct the link, but it >> should still be fixed regardless. > > Justin Lu has updated the pull request incremen

Re: RFR: 8334653: ISO 4217 Amendment 177 Update [v3]

2024-07-10 Thread Steven Loomis
On Fri, 21 Jun 2024 01:58:05 GMT, Naoto Sato wrote: > Out of curiosity, what's the rationale behind the currency name change from > "Zimbabwe Dollar" (ISO 4217 definition) to "Zimbabwean Dollar"? I'm not sure. - PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_

Re: RFR: 8334653: ISO 4217 Amendment 177 Update [v3]

2024-06-20 Thread Steven Loomis
On Thu, 20 Jun 2024 19:47:56 GMT, Naoto Sato wrote: >> I see your point. CLDR takes precedence over ISO4217 regarding currencies >> here? > > That is more consistent IMO CLDR is aware of this change but hasn't added it yet. We're mid cycle so it won't be much more than metadata this round due

Re: RFR: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14

2024-06-18 Thread Steven Loomis
On Mon, 17 Jun 2024 21:05:13 GMT, Justin Lu wrote: > Please review this PR, which is a trivial update of the IANA subtag registry > to version 2024-06-14. > Announcement: > https://mm.icann.org/pipermail/ietf-languages-announcements/2024-June/92.html Marked as reviewed by srl (Committer).

Re: RFR: 8331866: Add warnings for locale data dependence [v2]

2024-05-09 Thread Steven Loomis
On Thu, 9 May 2024 17:58:34 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line >> 157: >> >>> 155: * Note that the CLDR locale data are subject to change. Users should >>> not assume >>> 156: * that the locale data remain the same across CLDR

Re: RFR: 8331866: Add warnings for locale data dependence [v2]

2024-05-09 Thread Steven Loomis
On Thu, 9 May 2024 17:58:21 GMT, Naoto Sato wrote: >> In order to enlighten users to not depend on a particular version of the >> locale data, putting a note into the JDK vs. CLDR version chart would be >> appropriate. > > Naoto Sato has updated the pull request with a new target base due to a

Re: RFR: 8306116: Update CLDR to Version 44.0

2023-11-08 Thread Steven Loomis
On Tue, 31 Oct 2023 21:06:13 GMT, Naoto Sato wrote: > Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44). > Besides the data upgrade, regression tests are modified to accommodate the > following CLDR fixes: > > CLDR-16534: Suggestion to rename the Islamic Calendar to Hijr

Re: RFR: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16

2023-10-18 Thread Steven Loomis
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote: > This change updates the IANA subtag registry to the update released on > 2023-10-16. > > Announcement -> > https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html Marked as reviewed by srl (Committer).

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Steven Loomis
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY. Alt

Re: RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v3]

2023-09-19 Thread Steven Loomis
On Tue, 19 Sep 2023 18:53:30 GMT, Naoto Sato wrote: >> look at https://www.unicode.org/Public/UCD/latest/ for example, it points >> you only to license.txt. > > We are checking on it and will update it if necessary. it was unnecessary to mention copyright.html or terms of use in the source lic

Re: RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v5]

2023-09-19 Thread Steven Loomis
On Tue, 19 Sep 2023 18:55:28 GMT, Naoto Sato wrote: >> This PR is to incorporate the latest Unicode 15.1, which was released >> yesterday. Besides the usual character data update, an upgraded >> implementation of RegEx which reflects the Indic Conjunct Break specified in >> the latest [Unicode

Re: RFR: JDK-8316435: sun.util.calendar.CalendarSystem subclassing should be restricted

2023-09-19 Thread Steven Loomis
On Mon, 18 Sep 2023 22:42:09 GMT, Justin Lu wrote: > Please review this PR which restricts sub-classing of the internal calendar > system in sun.util.calendar to only the existing implementations. > > As the implementation is long-standing and complete with no intent for future > sub-classing,

Re: RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v3]

2023-09-19 Thread Steven Loomis
On Tue, 19 Sep 2023 16:57:57 GMT, Steven Loomis wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 addi

Re: RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v3]

2023-09-19 Thread Steven Loomis
On Mon, 18 Sep 2023 18:33:20 GMT, Naoto Sato wrote: >> This PR is to incorporate the latest Unicode 15.1, which was released >> yesterday. Besides the usual character data update, an upgraded >> implementation of RegEx which reflects the Indic Conjunct Break specified in >> the latest [Unicode

Re: RFR: 8307547: Support variant collations [v4]

2023-05-12 Thread Steven Loomis
On Fri, 12 May 2023 16:41:20 GMT, Steven Loomis wrote: >>> I'm just wondering where a developer might go to get a definitive list, >>> i.e. aside from this API note, how would they know that "-trad" or >>> "-traditional" can be u

Re: RFR: 8307547: Support variant collations [v4]

2023-05-12 Thread Steven Loomis
On Fri, 12 May 2023 16:32:57 GMT, Naoto Sato wrote: > > I'm just wondering where a developer might go to get a definitive list, > > i.e. aside from this API note, how would they know that "-trad" or > > "-traditional" can be used to configure the ordering. Locale.forLanguageTag > > supports mo

Re: RFR: 8307547: Support variant collations [v4]

2023-05-12 Thread Steven Loomis
On Thu, 11 May 2023 20:51:37 GMT, Naoto Sato wrote: >> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default >> collation for Swedish to the modern one. In order to provide a means for >> users who need the old collation, this PR intends to make `Collator` >> recognize th

Re: RFR: 8306323: Update license files in CLDR v43

2023-04-18 Thread Steven Loomis
On Tue, 18 Apr 2023 18:40:03 GMT, Naoto Sato wrote: > The upgrade to CLDR v43 was missing the license-related file updates. Here > are the supplemental updates. Marked as reviewed by srl (Committer). [testing] Marked as reviewed by srl (Committer). - PR Review: https://git.openj

Re: RFR: 8306323: Update license files in CLDR v43

2023-04-18 Thread Steven Loomis
On Tue, 18 Apr 2023 20:15:32 GMT, Steven Loomis wrote: >> The upgrade to CLDR v43 was missing the license-related file updates. Here >> are the supplemental updates. > > Marked as reviewed by srl (Committer). - [Steven Loomis](https://openjdk.org/census#srl) (@srl2