Re: RFR: 8350518: org.openjdk.bench.java.util.TreeMapUpdate.compute fails with "java.lang.IllegalArgumentException: key out of range"

2025-02-24 Thread Sergey Kuksenko
On Mon, 24 Feb 2025 08:44:00 GMT, Tagir F. Valeev wrote: > It appears that the benchmark was erroneous. The combination of "tailMap" > mode and comparator = true didn't work correctly, as the comparator is > descending. This PR changes the benchmark to use headMap instead of tailMap > in compa

Re: RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v5]

2024-09-03 Thread Sergey Kuksenko
On Mon, 2 Sep 2024 16:19:01 GMT, fabioromano1 wrote: >> This implementation of MutableBigInteger.leftShift(int) optimizes the >> current version, avoiding unnecessary copy of the MutableBigInteger's value >> content and performing the primitive shifting only in the original portion >> of the v

Re: RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v5]

2024-09-03 Thread Sergey Kuksenko
On Tue, 3 Sep 2024 15:49:01 GMT, fabioromano1 wrote: > > It would be nice to see some benchmarks where it gives performance benefits. > > @kuksenko Try to run the benchmark of the `BigInteger`'s square root, maybe > there the benefits are more visible... "maybe" So, you don't have proof th

Re: RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v5]

2024-09-03 Thread Sergey Kuksenko
On Mon, 2 Sep 2024 16:19:01 GMT, fabioromano1 wrote: >> This implementation of MutableBigInteger.leftShift(int) optimizes the >> current version, avoiding unnecessary copy of the MutableBigInteger's value >> content and performing the primitive shifting only in the original portion >> of the v

Re: RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v6]

2024-04-17 Thread Sergey Kuksenko
7;t have benchmarks targeting lambdas startup. From: Mandy Chung ***@***.***> Sent: Wednesday, April 17, 2024 9:32 AM To: openjdk/jdk Cc: Sergey Kuksenko; Mention Subject: [External] : Re: [openjdk/jdk] 8294960: Convert java.base/java.la

Re: RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-10 Thread Sergey Kuksenko
On Mon, 10 Jul 2023 08:17:59 GMT, Hamlin Li wrote: >> @Hamlin-Li >> The PR is fully correct. >> Don't forget, every Java instance method has a specific argument which >> called "this". That is why @State annotation is working. > > @kuksenko @swati-sha Thanks for explanation. I can understand w

Re: RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-07 Thread Sergey Kuksenko
On Fri, 7 Jul 2023 08:29:06 GMT, Hamlin Li wrote: >> The below benchmark files have scaling issues due to cache contention and >> leads to poor scaling when run on multiple threads. The patch sets the scope >> from benchmark level to thread level to fix the issue: >> - org/openjdk/bench/java/io

Re: RFR: 8302204: Optimize BigDecimal.divide

2023-02-13 Thread Sergey Kuksenko
On Fri, 10 Feb 2023 10:00:05 GMT, Xiaowei Lu wrote: > [JDK-8269667](https://bugs.openjdk.org/browse/JDK-8269667) has uncovered the > poor performance of BigDecimal.divide under certain circumstance. > > We confront similar situations when benchmarking Spark3 on TPC-DS test kit. > According to

Re: RFR: 8302204: Optimize BigDecimal.divide

2023-02-12 Thread Sergey Kuksenko
On Fri, 10 Feb 2023 10:00:05 GMT, Xiaowei Lu wrote: > [JDK-8269667](https://bugs.openjdk.org/browse/JDK-8269667) has uncovered the > poor performance of BigDecimal.divide under certain circumstance. > > We confront similar situations when benchmarking Spark3 on TPC-DS test kit. > According to

Re: RFR: 8302204: Optimize BigDecimal.divide

2023-02-11 Thread Sergey Kuksenko
On Fri, 10 Feb 2023 10:00:05 GMT, Xiaowei Lu wrote: > [JDK-8269667](https://bugs.openjdk.org/browse/JDK-8269667) has uncovered the > poor performance of BigDecimal.divide under certain circumstance. > > We confront similar situations when benchmarking Spark3 on TPC-DS test kit. > According to

Re: RFR: 8300487: Store cardinality as a field in BitSet

2023-01-18 Thread Sergey Kuksenko
On Tue, 3 Jan 2023 23:25:39 GMT, fabioromano1 wrote: > The enanchment is useful for applications that make heavy use of BitSet > objects as sets of integers, and therefore they need to make a lot of calls > to cardinality() method, which actually require linear time in the number of > words in