Integrated: 8332400: isspace argument should be a valid unsigned char

2024-06-14 Thread Robert Toyonaga
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote: > ### Summary > This change ensures we don't get undefined behavior when > calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). > `isspace` accepts an `int` argument that "

Re: RFR: 8332400: isspace argument should be a valid unsigned char

2024-06-11 Thread Robert Toyonaga
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote: > ### Summary > This change ensures we don't get undefined behavior when > calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). > `isspace` accepts an `int` argument that "

Re: RFR: 8332400: isspace argument should be a valid unsigned char [v2]

2024-06-11 Thread Robert Toyonaga
ndefined behavior from happening. For > instances outside of Hotspot, I've added casts to `unsigned char`. > > **Testing** > - Added a new test in `test/hotspot/gtest/runtime/test_os.cpp` to check > `os::is_space` is working correctly. > - tier1 Robert Toyonaga has updated

Re: RFR: 8332400: isspace argument should be a valid unsigned char

2024-06-10 Thread Robert Toyonaga
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote: > ### Summary > This change ensures we don't get undefined behavior when > calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). > `isspace` accepts an `int` argument that "

RFR: 8332400: isspace argument should be a valid unsigned char

2024-06-06 Thread Robert Toyonaga
### Summary This change ensures we don't get undefined behavior when calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). `isspace` accepts an `int` argument that "the application shall ensure is a character representable as an unsigned char or equal to th