Integrated: 8352730: RISC-V: Disable tests in qemu-user

2025-05-05 Thread Robbin Ehn
On Tue, 25 Mar 2025 14:19:55 GMT, Robbin Ehn wrote: > Hi, for you to consider. > > These tests constantly fails in qemu-user. > Either the require host to be same arch explicit or implicit (sysroot). > E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implement

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v2]

2025-05-02 Thread Robbin Ehn
On Thu, 27 Mar 2025 17:57:37 GMT, Hamlin Li wrote: >> Robbin Ehn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four addi

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v3]

2025-04-30 Thread Robbin Ehn
On Mon, 31 Mar 2025 10:45:54 GMT, Robbin Ehn wrote: >> Hi, for you to consider. >> >> These tests constantly fails in qemu-user. >> Either the require host to be same arch explicit or implicit (sysroot). >> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Fu

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v4]

2025-04-30 Thread Robbin Ehn
scv.cpp#L250 > > Tested that the require only filters out tests in qemu+riscv64. > > Thanks! > > /Robbin Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v3]

2025-04-10 Thread Robbin Ehn
On Thu, 10 Apr 2025 02:13:46 GMT, Fei Yang wrote: > > qemu-user, "uarch: qemu" in cpuinfo: `[0.084s][info ][os,cpu] CPU: total 28 > > (initial active 28) qemu rv64 rvi rvm rva rvf rvd rvc rvv zba zbb zbs zfh > > zfhmin zvbc zvfh zicond` Hence we know this is qemu-user (only qemu-user > > sets

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v2]

2025-04-09 Thread Robbin Ehn
On Wed, 9 Apr 2025 07:29:01 GMT, Fei Yang wrote: > > > > It's not some intermittently failure. The majority of them can't work > > > > as they use pstack, open core files, use PerfData, etc.. and expected > > > > it to be rv64. But core files, pstack are in host arch as we are > > > > running

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v2]

2025-04-08 Thread Robbin Ehn
On Wed, 9 Apr 2025 03:57:10 GMT, Fei Yang wrote: > > It's not some intermittently failure. The majority of them can't work as > > they use pstack, open core files, use PerfData, etc.. and expected it to be > > rv64. But core files, pstack are in host arch as we are running qemu-user. > > I can

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v3]

2025-04-08 Thread Robbin Ehn
On Mon, 31 Mar 2025 10:45:54 GMT, Robbin Ehn wrote: >> Hi, for you to consider. >> >> These tests constantly fails in qemu-user. >> Either the require host to be same arch explicit or implicit (sysroot). >> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Fu

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v3]

2025-03-31 Thread Robbin Ehn
de: > https://github.com/openjdk/jdk/blob/fa0b18bfde38ee2ffbab33a9eaac547fe8aa3c7c/src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp#L250 > > Tested that the require only filters out tests in qemu+riscv64. > > Thanks! > > /Robbin Robbin Ehn has updated the pull request with a n

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v2]

2025-03-27 Thread Robbin Ehn
On Thu, 27 Mar 2025 17:57:37 GMT, Hamlin Li wrote: > I also feel annoying to see some tests fail interminently. > > Not sure if I understand the goal of this pr, seems it might not be the best > solution to simply disable these tests when running with qemu. My concerns > are: qemu is still one

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v2]

2025-03-27 Thread Robbin Ehn
de: > https://github.com/openjdk/jdk/blob/fa0b18bfde38ee2ffbab33a9eaac547fe8aa3c7c/src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp#L250 > > Tested that the require only filters out tests in qemu+riscv64. > > Thanks! > > /Robbin Robbin Ehn has updated the pull request with a n

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user

2025-03-26 Thread Robbin Ehn
On Wed, 26 Mar 2025 10:20:19 GMT, Alan Bateman wrote: > > One issue with high timeout factor is that make+jtreg only can parallelize > > tests in the same directory. Which means you often end up with just waiting > > for one test to complete before anything else can happen. > > jtreg doesn't r

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user

2025-03-25 Thread Robbin Ehn
On Tue, 25 Mar 2025 14:19:55 GMT, Robbin Ehn wrote: > Hi, for you to consider. > > These tests constantly fails in qemu-user. > Either the require host to be same arch or they are very very slow in > emulation. > E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: F

RFR: 8352730: RISC-V: Disable tests in qemu-user

2025-03-25 Thread Robbin Ehn
Hi, for you to consider. These tests constantly fails in qemu-user. Either the require host to be same arch or they are very very slow in emulation. E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'" for SA tests. This is the initial set of tests, there are many more, b

Re: RFR: 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode

2024-08-21 Thread Robbin Ehn
On Mon, 19 Aug 2024 16:43:02 GMT, Hamlin Li wrote: > Hi, > Can you help to review this simple patch? > > Currently, lineSize linesize for MIME case in macro bench test Base64Decode > is only "4", but in Base64.Encoder default linesize for MIME encoder is 76. > It's helpful to add more linesize,

Re: RFR: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics [v2]

2023-10-16 Thread Robbin Ehn
On Mon, 16 Oct 2023 21:14:39 GMT, Ilya Gavrilin wrote: >> Hi all, please review this changes into risc-v floating point copysign and >> signum intrinsics. >> CopySign - returns first argument with the sign of second. On risc-v we have >> `fsgnj.x` instruction, which can implement this intrinsic

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-02-24 Thread Robbin Ehn
On Fri, 24 Feb 2023 10:12:52 GMT, Martin Doerr wrote: > > > ~I don't think we've done that much testing with UseSystemMemoryBarrier > > > since it was added~. I'm a bit nervous about turning it on by default > > > since it's currently also used for JNI. Let's see what Robbin thinks. > > > > >

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-02-23 Thread Robbin Ehn
On Fri, 24 Feb 2023 07:17:30 GMT, Jorn Vernee wrote: > ~I don't think we've done that much testing with UseSystemMemoryBarrier since > it was added~. I'm a bit nervous about turning it on by default since it's > currently also used for JNI. Let's see what Robbin thinks. For reliability: On eve

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-02-23 Thread Robbin Ehn
On Fri, 24 Feb 2023 04:03:53 GMT, Martin Doerr wrote: > * Since the membar on the return path was mentioned: I think it would be good > to enable UseSystemMemoryBarrier by default on operating systems which > support it. Maybe we should discuss this with @robehn. Changing the default is fine b

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2023-01-04 Thread Robbin Ehn
On Fri, 16 Dec 2022 16:10:10 GMT, Magnus Ihse Bursie wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify logic for including __ubsan_default_options >> >> Signed-off-by: Justin King > > I much also check:

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-13 Thread Robbin Ehn
On Tue, 13 Dec 2022 16:29:59 GMT, Justin King wrote: > I guess the advantage to putting this in the build machinery (as opposed to > using `--with-extra-cflags=-fsanitize=undefined > --with-extra-ldflags=-fsanitize=undefined`) is that we can turn some of these > onn by default once we've fixed

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v3]

2022-12-12 Thread Robbin Ehn
On Mon, 12 Dec 2022 07:02:04 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer

2022-12-09 Thread Robbin Ehn
On Fri, 9 Dec 2022 13:46:07 GMT, Justin King wrote: > What version of GCC are you using? gcc 11.3 with libubsan 11.2 Also it seem to big overlap with -Wcast-align(=strict) for the warnings/errors I see and I do like that warning. Do you have an idea if the coverage are pretty much the same for

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer

2022-12-09 Thread Robbin Ehn
On Fri, 9 Dec 2022 06:53:31 GMT, Justin King wrote: > Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior o

Re: RFR: 8296477: Foreign linker implementation update following JEP 434

2022-11-09 Thread Robbin Ehn
On Mon, 7 Nov 2022 14:34:45 GMT, Jorn Vernee wrote: > Pull in linker implementation changes, that include non-trivial changes to VM > code, from the panama-foreign repo into the main JDK. > > This is split off from the main JEP integration to make reviewing easier. > > This includes the follow

Re: RFR: 8293592: Remove JVM_StopThread, stillborn, and related cleanup [v2]

2022-09-27 Thread Robbin Ehn
On Fri, 23 Sep 2022 21:47:06 GMT, David Holmes wrote: >> Now that Thread.stop has been degraded to throw >> `UnsupportedOperationException` (JDK-8299610) the only direct source of >> async exceptions is from JVMTI `StopThread`. We can remove the >> `JVM_StopThread` code, remove the `stillborn`

Re: RFR: 8290482: Update JNI Specification of DestroyJavaVM for better alignment with JLS, JVMS, and Java SE API Specifications [v4]

2022-09-21 Thread Robbin Ehn
On Tue, 20 Sep 2022 10:37:41 GMT, David Holmes wrote: >> This update is primarily about changes to the JNI Invocation API >> specification, mainly in relation to `DestroyJavaVM`. The motivation for the >> changes is to align with changes being made to the JLS, JVMS and >> `java.lang.Runtime`,

Re: RFR: 8287982: Concurrent implicit attach from native threads crashes VM

2022-06-21 Thread Robbin Ehn
On Thu, 16 Jun 2022 13:34:18 GMT, Alan Bateman wrote: > If several native threads attach to the VM at around the same time, and > before any threads get an automatically generated name are created, then the > VM may crash attempting to access the thread status. The issue exists for > native th