Re: RFR: 8334441: Mark tests in jdk_security_infra group as manual [v2]

2024-06-26 Thread Rajan Halade
On Tue, 25 Jun 2024 17:45:23 GMT, Andrew John Hughes wrote: > Is there still going to be some monitoring of these tests? Making it harder > to run these tests potentially means that genuine failures can go unnoticed > and JDK certificates are not updated when needed. Tracking won’t be any diff

Integrated: 8334441: Mark tests in jdk_security_infra group as manual

2024-06-21 Thread Rajan Halade
On Thu, 20 Jun 2024 18:35:00 GMT, Rajan Halade wrote: > Updated all the tests that depend on external infrastructure services as > manual. These tests may fail with external reasons, for instance - change in > CA test portal, certificate status updates, or network issues. This pul

Re: RFR: 8334441: Mark tests in jdk_security_infra group as manual [v2]

2024-06-21 Thread Rajan Halade
On Fri, 21 Jun 2024 13:10:00 GMT, Christoph Langer wrote: >> Rajan Halade has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix typos > > test/jdk/security/infra/java/security/cert/CertPathValidator/certifica

Re: RFR: 8334441: Mark tests in jdk_security_infra group as manual [v2]

2024-06-21 Thread Rajan Halade
> Updated all the tests that depend on external infrastructure services as > manual. These tests may fail with external reasons, for instance - change in > CA test portal, certificate status updates, or network issues. Rajan Halade has updated the pull request incrementally with one a

RFR: 8334441: Mark tests in jdk_security_infra group as manual

2024-06-20 Thread Rajan Halade
Updated all the tests that depend on external infrastructure services as manual. These tests may fail with external reasons, for instance - change in CA test portal, certificate status updates, or network issues. - Commit messages: - Update comments - comment explaining why these

Re: RFR: 8297955: LDAP CertStore should use LdapName and not String for DNs

2023-03-02 Thread Rajan Halade
On Thu, 23 Feb 2023 16:42:17 GMT, Sean Mullan wrote: > The LDAPCertStore implementation passes Distinguished Names in CRL and > Certificate URLs as Strings to JNDI APIs such as > LdapContext.getAttributes(String), which then treats them as CompositeNames. > This causes issues with URLs that ha

Re: RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only [v5]

2023-02-03 Thread Rajan Halade
On Fri, 3 Feb 2023 00:41:29 GMT, Bill Huang wrote: >> Root.java is changed to a manual test because it requires test to be run >> with the root user privilege, and it requires to modify the user policy file >> in the home director. > > Bill Huang has updated the pull request incrementally with

Re: RFR: JDK-8299994: java/security/Policy/Root/Root.java fails when home directory is read-only

2023-01-31 Thread Rajan Halade
On Tue, 31 Jan 2023 22:35:21 GMT, Bill Huang wrote: > Root.java is changed to a manual test because it requires test to be run with > the root user privilege, and it requires to modify the user policy file in > the home director. test/jdk/java/security/Policy/Root/Root.java line 34: > 32: >

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Wed, 21 Dec 2022 21:37:27 GMT, Bill Huang wrote: >> I have not seen this used in any other tests. It is a good learning, I >> didn't knew that multiple tests in single file are run in parallel. It seems >> like good option. Do you know of any other regression test written this way? > > I did

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Wed, 21 Dec 2022 19:58:18 GMT, Bill Huang wrote: >> test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33: >> >>> 31: >>> 32: /* >>> 33: * @test >> >> Why are these tags duplicated here? > > Multiple "run" in a single test fails the whole test when one test run fails > and all

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-12-21 Thread Rajan Halade
On Wed, 19 Oct 2022 16:49:33 GMT, Mahendra Chhipa wrote: >> Are you saying that we don't need to run the ExtDir2.policy and >> ExtDir3.policy? > > Its fine, ignore my previous comment. you can add multiple run tags under same test tag, no need to repeat tag, bug, and summary tags. ---

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved [v2]

2022-11-09 Thread Rajan Halade
On Wed, 9 Nov 2022 17:36:12 GMT, Mikhailo Seledtsov wrote: >> Trivial change, updated jdk problem list. > > Mikhailo Seledtsov has updated the pull request incrementally with one > additional commit since the last revision: > > Addressed review feedback Marked as reviewed by rhalade (Review

Re: RFR: 8296611: Problemlist several sun/security and java/security tests until JDK-8295343 is resolved [v2]

2022-11-09 Thread Rajan Halade
On Wed, 9 Nov 2022 17:36:12 GMT, Mikhailo Seledtsov wrote: >> Trivial change, updated jdk problem list. > > Mikhailo Seledtsov has updated the pull request incrementally with one > additional commit since the last revision: > > Addressed review feedback Please update the PR commit message i

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling

2022-09-12 Thread Rajan Halade
On Thu, 8 Sep 2022 15:54:03 GMT, Rajan Halade wrote: >> Created two files for testing XPath Axes: XPathAncestors.java tests the >> ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the >> preceding and preceding-sibling axes. > > Please fix

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling

2022-09-08 Thread Rajan Halade
On Thu, 8 Sep 2022 06:19:10 GMT, Rahul Prabhu wrote: > Created two files for testing XPath Axes: XPathAncestors.java tests the > ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the > preceding and preceding-sibling axes. Please fix jcheck issues. Code has trailing white

Re: RFR: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties

2022-08-31 Thread Rajan Halade
On Mon, 29 Aug 2022 21:25:29 GMT, Rahul Prabhu wrote: > Rewrote javatest.maxOutputSize as maxOutputSize in the TEST.properties file > in test/jdk/jdk/lambda to match the same declarations in other > TEST.properties files. The jtreg specification with the correct syntax for > maxOutputSize is a