Re: RFR: 8345292: Improve javadocs for MemorySegment::getStrings defining word boundary cases [v4]

2025-06-11 Thread Per Minborg
> This PR proposes to improve the 'MemorySegment.getString(long offset, Charset > charset)` method documentation with respect to multi-octet concerns. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Impr

Re: RFR: 8345292: Improve javadocs for MemorySegment::getStrings defining word boundary cases [v3]

2025-06-11 Thread Per Minborg
> This PR proposes to improve the 'MemorySegment.getString(long offset, Charset > charset)` method documentation with respect to multi-octet concerns. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base/sh

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v9]

2025-06-10 Thread Per Minborg
g the code. The number of > branches to evaluate is reduced. > > It should be noted that the performance of the fill operation affects the > allocation of new segments (as they are zeroed out before being returned to > the client code). > > This PR passes tier1, tier2, a

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v8]

2025-06-10 Thread Per Minborg
On Tue, 10 Jun 2025 16:37:26 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use a fixed threashold for fill > > src/java.base/share/classes/jdk/internal/fore

Re: RFR: 8345292: Improve javadocs for MemorySegment::getStrings defining word boundary cases [v2]

2025-06-10 Thread Per Minborg
On Tue, 10 Jun 2025 15:50:08 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update after comments > > src/java.base/share/classes/java/lang/foreig

Re: RFR: 8345292: Improve javadocs for MemorySegment::getStrings defining word boundary cases [v2]

2025-06-10 Thread Per Minborg
> This PR proposes to improve the 'MemorySegment.getString(long offset, Charset > charset)` method documentation with respect to multi-octet concerns. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Update aft

RFR: 8345292: Improve javadocs for MemorySegment::getStrings defining word boundary cases

2025-06-10 Thread Per Minborg
This PR proposes to improve the 'MemorySegment.getString(long offset, Charset charset)` method documentation with respect to multi-octet concerns. - Commit messages: - Add info for multi-octet Charsets Changes: https://git.openjdk.org/jdk/pull/25715/files Webrev: https://webrevs.

Integrated: 8358520: Improve lazy computation in BreakIteratorResourceBundle and related classes

2025-06-09 Thread Per Minborg
On Tue, 3 Jun 2025 20:14:31 GMT, Per Minborg wrote: > This PR proposes to simplify lazy computation related to resource bundles. > Previously, some objects were computed lazily using a double-checked locking > algorithm. StableValues offers a more robust and succinct solution. >

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v8]

2025-06-05 Thread Per Minborg
g the code. The number of > branches to evaluate is reduced. > > It should be noted that the performance of the fill operation affects the > allocation of new segments (as they are zeroed out before being returned to > the client code). > > This PR passes tier1, tier2, a

RFR: 8358520: Improve lazy computation in BreakIteratorResourceBundle and related classes

2025-06-05 Thread Per Minborg
This PR proposes to simplify lazy computation related to resource bundles. Previously, some objects were computed lazily using a double-checked locking algorithm. StableValues offers a more robust and succinct solution. This PR passes tier1, tier2, and tier3 on multiple platforms. -

Re: RFR: 8357821: Revert incorrectly named JavaLangAccess::unchecked* methods [v2]

2025-06-05 Thread Per Minborg
On Thu, 5 Jun 2025 06:04:49 GMT, Volkan Yazici wrote: >> Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197) >> (which implements JavaDoc improvement and precautionary naming for certain >> unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are >> found

Re: RFR: 8358426: Improve lazy computation in Locale

2025-06-05 Thread Per Minborg
On Thu, 5 Jun 2025 00:18:34 GMT, Chen Liang wrote: >> Please review this PR which improves occurrences of lazy computation in >> `Locale` and `BaseLocale`. >> >> Existing lazy initialization strategies such as CHM, static nested class, >> and local inner class are replaced with Stable Values.

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v7]

2025-06-04 Thread Per Minborg
g the code. The number of > branches to evaluate is reduced. > > It should be noted that the performance of the fill operation affects the > allocation of new segments (as they are zeroed out before being returned to > the client code). > > This PR passes tier1, tier2, a

Re: RFR: 8357913: Add `@Stable` to BigInteger and BigDecimal [v3]

2025-06-04 Thread Per Minborg
On Fri, 30 May 2025 22:07:06 GMT, Shaojin Wen wrote: >> Some static final arrays of BigInteger and BigDecimal are stable and >> immutable. We should add `@Stable` to give the optimizer more information > > Shaojin Wen has updated the pull request incrementally with one additional > commit since

Re: RFR: 8357821: Revert incorrectly named JavaLangAccess::unchecked* methods

2025-06-04 Thread Per Minborg
On Tue, 3 Jun 2025 09:10:04 GMT, Volkan Yazici wrote: > > I wonder if we should add that implementations of the affected method > > _shall_ do bounds checking to reduce the likelihood of a new/updated native > > implementation miss that? > > @minborg, would you mind elaborating on this a bit,

Re: RFR: 8357798: ReverseOrderListView uses Boolean boxes after JDK-8356080 [v2]

2025-06-04 Thread Per Minborg
On Mon, 2 Jun 2025 13:26:36 GMT, Aleksey Shipilev wrote: >> SonarCloud complains that since >> [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using >> `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> >> `Boolean` was made in >> [JDK-8356080](https://bugs.

Re: RFR: 8357913: Add `@Stable` to BigInteger and BigDecimal [v3]

2025-06-02 Thread Per Minborg
On Fri, 30 May 2025 22:07:06 GMT, Shaojin Wen wrote: >> Some static final arrays of BigInteger and BigDecimal are stable and >> immutable. We should add `@Stable` to give the optimizer more information > > Shaojin Wen has updated the pull request incrementally with one additional > commit since

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v6]

2025-06-02 Thread Per Minborg
On Thu, 29 May 2025 09:52:34 GMT, Andrew Haley wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: 8357821: Revert incorrectly named JavaLangAccess::unchecked* methods

2025-06-02 Thread Per Minborg
On Fri, 30 May 2025 11:57:39 GMT, Volkan Yazici wrote: > Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197) > (which implements JavaDoc improvement and precautionary naming for certain > unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are > found to

Re: RFR: 8357823: Changes in StringBuilder (JDK-8351443) caused a 1-3% regression in biojava

2025-06-02 Thread Per Minborg
On Fri, 30 May 2025 14:01:04 GMT, Roger Riggs wrote: > Comment out assertions added in JDK-8351443 from > AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize, > preventing some inlining, and reducing performance > >assert coder == newCoder || newCoder == UTF16 : "ba

Re: RFR: 8357913: Add `@Stable` to BigInteger and BigDecimal

2025-05-28 Thread Per Minborg
On Sun, 25 May 2025 22:35:56 GMT, Shaojin Wen wrote: > Some static final arrays of BigInteger and BigDecimal are stable and > immutable. We should add `@Stable` to give the optimizer more information src/java.base/share/classes/java/math/BigDecimal.java line 4317: > 4315: }; > 4316: > 431

Integrated: 8357919: Arena::allocate returns segments with address zero if the segment length is zero after JDK-8345687

2025-05-28 Thread Per Minborg
On Wed, 28 May 2025 09:06:57 GMT, Per Minborg wrote: > After https://bugs.openjdk.org/browse/JDK-8345687 was integrated, zero-length > segments always have an address of zero. This may cause problems in certain > native methods that can receive segments and/or buffers derived from

RFR: 8357919: Arena::allocate returns segments with address zero if the segment length is zero after JDK-8345687

2025-05-28 Thread Per Minborg
After https://bugs.openjdk.org/browse/JDK-8345687 was integrated, zero-length segments always have an address of zero. This may cause problems in certain native methods that can receive segments and/or buffers derived from segments. This PR also guards for overflow for extremely large allocation

Re: RFR: 8357145: CRC/Inflater/Deflater/Adler32 methods that take a ByteBuffer throw UOE if backed by shared memory segment

2025-05-27 Thread Per Minborg
On Tue, 20 May 2025 07:37:34 GMT, Per Minborg wrote: > This PR proposes to use ` JavaNioAccess::getBufferAdress` rather than > `DirectBuffer::address` in the package `java.util.zip` so that `Buffer` > instances backed by `MemorySegment` instances can be used. > > This PR pass

Integrated: 8357145: CRC/Inflater/Deflater/Adler32 methods that take a ByteBuffer throw UOE if backed by shared memory segment

2025-05-27 Thread Per Minborg
On Tue, 20 May 2025 07:37:34 GMT, Per Minborg wrote: > This PR proposes to use ` JavaNioAccess::getBufferAdress` rather than > `DirectBuffer::address` in the package `java.util.zip` so that `Buffer` > instances backed by `MemorySegment` instances can be used. > > This PR pass

Re: RFR: 8356706: Foreign tests timeout after passing on linux-x64-zero

2025-05-27 Thread Per Minborg
On Thu, 15 May 2025 09:49:10 GMT, Per Minborg wrote: > This PR improves the robustness of tests on slow machines such as "zero" > variants. The timeout was increased to 10 minutes for both tests. There are > many combinations in `TestAccessModes`, so the test takes some tim

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-27 Thread Per Minborg
On Mon, 26 May 2025 15:06:02 GMT, Per Minborg wrote: > > Can we remove all meaningless `!Architecture.isLittleEndian()` calls and > > use the platform-specific endianness unsafe primitives instead? For > > compensation, we can add a check in each of fill2/fill3/fill4 that

Withdrawn: 8356706: Foreign tests timeout after passing on linux-x64-zero

2025-05-27 Thread Per Minborg
On Thu, 15 May 2025 09:49:10 GMT, Per Minborg wrote: > This PR improves the robustness of tests on slow machines such as "zero" > variants. The timeout was increased to 10 minutes for both tests. There are > many combinations in `TestAccessModes`, so the test takes some tim

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v6]

2025-05-27 Thread Per Minborg
g the code. The number of > branches to evaluate is reduced. > > It should be noted that the performance of the fill operation affects the > allocation of new segments (as they are zeroed out before being returned to > the client code). > > This PR passes tier1, tier2, a

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-26 Thread Per Minborg
On Fri, 23 May 2025 19:52:50 GMT, Chen Liang wrote: > Can we remove all meaningless `!Architecture.isLittleEndian()` calls and use > the platform-specific endianness unsafe primitives instead? For compensation, > we can add a check in each of fill2/fill3/fill4 that `assert value == > Integer/S

Re: RFR: 8357289: Break down the String constructor into smaller methods [v3]

2025-05-26 Thread Per Minborg
On Sun, 25 May 2025 12:54:03 GMT, Chen Liang wrote: >> private String(char[] value, int off, int len, Void sig) { >> if (len == 0) { >> this.value = "".value; >> this.coder = "".coder; >> return; >> } >> if (COMPACT_STRINGS) { >>

Re: RFR: 8357690: Add @Stable and final to java.lang.CharacterDataLatin1 and other CharacterData classes

2025-05-26 Thread Per Minborg
On Sat, 24 May 2025 10:00:56 GMT, Shaojin Wen wrote: > Classes such as java.lang.CharacterDataXXX have multiple static final arrays, > these are immutable, We should add `@Stable` and final to provide information > to the optimizer. We could add '@Stable` to `static final char[][][] charMap` a

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v5]

2025-05-22 Thread Per Minborg
On Tue, 20 May 2025 10:54:44 GMT, He-Pin(kerr) wrote: >> Motivation: >> When a user passes a wrong parameter, the current implementation throws an >> IllegalArgumentException with an error message `null`, which is not helpful. >> >> Modification: >> Add detail error messages. >> >> Result: >>

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 11:52:34 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-22 Thread Per Minborg
g the code. The number of > branches to evaluate is reduced. > > It should be noted that the performance of the fill operation affects the > allocation of new segments (as they are zeroed out before being returned to > the client code). Per Minborg has updated the pull request inc

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v2]

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 08:23:26 GMT, Shaojin Wen wrote: > Here you can use putShort/putInt/putLong to replace > putShortUnaligned/putIntUnaligned/putLongUnaligned The segment might be unaligned. For example, if it was sliced off an aligned segment. - PR Comment: https://git.openjdk.

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v4]

2025-05-22 Thread Per Minborg
g the code. The number of > branches to evaluate is reduced. > > It should be noted that the performance of the fill operation affects the > allocation of new segments (as they are zeroed out before being returned to > the client code). Per Minborg has updated the pull request inc

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v2]

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 08:55:09 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct typo in comment > > src/java.base/share/classes/jdk/internal/foreign/Segm

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v3]

2025-05-22 Thread Per Minborg
g the code. The number of > branches to evaluate is reduced. > > It should be noted that the performance of the fill operation affects the > allocation of new segments (as they are zeroed out before being returned to > the client code). Per Minborg has updated the pull request inc

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 08:56:13 GMT, Maurizio Cimadamore wrote: > > Performance on an M1 Mac (Sequoia 15.4.1) > > Are the "regressions" for very big sizes related to this patch? By default, only segments that are smaller than 32 bytes will use the affected code. - PR Comment: https

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v2]

2025-05-22 Thread Per Minborg
g the code. The number of > branches to evaluate is reduced. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Correct typo in comment - Changes: - all: https://git.openjdk.org/jdk/pull/25383/files - new: https://g

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 07:34:08 GMT, Per Minborg wrote: > This PR builds on a concept John Rose told me about some time ago. Instead of > combining memory operations of various sizes, a single large and skewed > memory operation can be made to clean up the tail of remaining bytes. >

RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps

2025-05-22 Thread Per Minborg
This PR builds on a concept John Rose told me about some time ago. Instead of combining memory operations of various sizes, a single large and skewed memory operation can be made to clean up the tail of remaining bytes. This has the effect of simplifying and shortening the code while improving

Re: RFR: 8357289: Break down the String constructor into smaller methods [v3]

2025-05-20 Thread Per Minborg
On Tue, 20 May 2025 02:11:34 GMT, Shaojin Wen wrote: >> Through JVM Option +PrintInlining, we found that String has a constructor >> codeSize of 852, which is too large. This caused failed to inline. >> >> The following is the output information of PrintInlining: >> >> @ 9 ja

Re: RFR: 8357178: Simplify Class::componentType [v2]

2025-05-19 Thread Per Minborg
On Mon, 19 May 2025 00:22:08 GMT, Chen Liang wrote: >> `isArray` and null return is now redundant when `componentType` is changed >> to an explicit field. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > For parity with MT.de

Re: RFR: 8351230: Collections.synchronizedList returns a list that is not thread-safe [v2]

2025-05-15 Thread Per Minborg
On Mon, 5 May 2025 23:36:35 GMT, Stuart Marks wrote: >> Collections.synchronizedList() returns a List implementation that doesn't do >> proper locking. This PR does the following on the synchronized wrapper: >> >> - overrides and adds locking to SequencedCollection methods; >> - performs instan

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-15 Thread Per Minborg
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The incremen

Re: RFR: 8356706: Foreign tests timeout after passing on linux-x64-zero

2025-05-15 Thread Per Minborg
On Thu, 15 May 2025 09:49:10 GMT, Per Minborg wrote: > This PR improves the robustness of tests on slow machines such as "zero" > variants. The timeout was increased to 10 minutes for both tests. There are > many combinations in `TestAccessModes`, so the test takes some tim

RFR: 8356706: Foreign tests timeout after passing on linux-x64-zero

2025-05-15 Thread Per Minborg
This PR improves the robustness of tests on slow machines such as "zero" variants. The timeout was increased to 10 minutes for both tests. There are many combinations in `TestAccessModes`, so the test takes some time even on a fast machine. In `StdLibTest`, there are numerous native calls, and t

Re: RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory [v6]

2025-05-14 Thread Per Minborg
On Wed, 14 May 2025 10:47:40 GMT, Andrew Haley wrote: >> This intrinsic is generally faster than the current implementation for >> Panama segment operations for all writes larger than about 8 bytes in size, >> increasing to more than 2* the performance on larger memory blocks on >> Graviton 2,

Re: RFR: 8356080: Address post-integration comments for Stable Values [v4]

2025-05-13 Thread Per Minborg
On Tue, 13 May 2025 07:57:15 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Most of the efforts in this PR are to retain "stability" as long as po

Integrated: 8356080: Address post-integration comments for Stable Values

2025-05-13 Thread Per Minborg
On Fri, 2 May 2025 12:13:39 GMT, Per Minborg wrote: > This PR proposes to address comments in the initial PR for Stable Values, > which were deferred until after integration. > > Most of the efforts in this PR are to retain "stability" as long as possible > so that vi

Re: RFR: 8356080: Address post-integration comments for Stable Values [v4]

2025-05-13 Thread Per Minborg
evaluate on > `toString()` for example. > > Unfortunately, this PR shows the total commit history for stable values. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Address comments - Changes: - all: https://gi

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-13 Thread Per Minborg
On Mon, 12 May 2025 07:42:16 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Most of the efforts in this PR are to retain "stability" as long as po

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-12 Thread Per Minborg
On Mon, 12 May 2025 21:12:36 GMT, Luca Kellermann wrote: >> src/java.base/share/classes/java/util/ImmutableCollections.java line 518: >> >>> 516: >>> 517: private boolean allowNulls() { >>> 518: return root instanceof ListN listN && listN.allowNulls; >> >> I think this shou

Integrated: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out

2025-05-12 Thread Per Minborg
On Mon, 12 May 2025 08:57:59 GMT, Per Minborg wrote: > This PR proposes to add a safety net around closing the executor. Apparently, > in some rare configuration, the VT is not run/notified correctly. > > Not completing the test for such a configuration is unlikely to mask > p

Re: RFR: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out [v6]

2025-05-12 Thread Per Minborg
On Mon, 12 May 2025 14:41:27 GMT, Per Minborg wrote: >> This PR proposes to add a safety net around closing the executor. >> Apparently, in some rare configuration, the VT is not run/notified correctly. >> >> Not completing the test for such a configuration is unlike

Re: RFR: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out [v6]

2025-05-12 Thread Per Minborg
> This PR proposes to add a safety net around closing the executor. Apparently, > in some rare configuration, the VT is not run/notified correctly. > > Not completing the test for such a configuration is unlikely to mask > potential issues that this test is supposed to reveal.

Re: RFR: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out [v5]

2025-05-12 Thread Per Minborg
On Mon, 12 May 2025 12:34:29 GMT, Alan Bateman wrote: > I assume the changes to switch this from wait/notify to CountDownLatch aren't > needed. A carrier can't terminate with a mounted virtual thread. It's okay to > change the test but I think the original issue is about Zero or running with >

Re: RFR: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out [v5]

2025-05-12 Thread Per Minborg
> This PR proposes to add a safety net around closing the executor. Apparently, > in some rare configuration, the VT is not run/notified correctly. > > Not completing the test for such a configuration is unlikely to mask > potential issues that this test is supposed to reveal.

Re: RFR: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out [v4]

2025-05-12 Thread Per Minborg
> This PR proposes to add a safety net around closing the executor. Apparently, > in some rare configuration, the VT is not run/notified correctly. > > Not completing the test for such a configuration is unlikely to mask > potential issues that this test is supposed to reveal.

Re: RFR: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out [v3]

2025-05-12 Thread Per Minborg
> This PR proposes to add a safety net around closing the executor. Apparently, > in some rare configuration, the VT is not run/notified correctly. > > Not completing the test for such a configuration is unlikely to mask > potential issues that this test is supposed to reveal.

Re: RFR: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out [v2]

2025-05-12 Thread Per Minborg
> This PR proposes to add a safety net around closing the executor. Apparently, > in some rare configuration, the VT is not run/notified correctly. > > Not completing the test for such a configuration is unlikely to mask > potential issues that this test is supposed to reveal.

RFR: 8356658: java/foreign/TestBufferStackStress2.java failed again with junit action timed out

2025-05-12 Thread Per Minborg
This PR proposes to add a safety net around closing the executor. Apparently, in some rare configuration, the VT is not run/notified correctly. Not completing the test for such a configuration is unlikely to mask potential issues that this test is supposed to reveal. - Commit messa

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v4]

2025-05-12 Thread Per Minborg
On Fri, 9 May 2025 08:31:35 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-12 Thread Per Minborg
> This PR proposes to address comments in the initial PR for Stable Values, > which were deferred until after integration. > > Unfortunately, this PR shows the total commit history for stable values. Per Minborg has updated the pull request with a new target base due to a merge

Re: RFR: 8356080: Address post-integration comments for Stable Values [v2]

2025-05-12 Thread Per Minborg
On Fri, 9 May 2025 14:55:06 GMT, Chen Liang wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 384 commits: >> >> - Fix an issue with toString on nested constructs >> - Mer

Integrated: 8356486: ReverseOrderListView should override reversed() to return `base`

2025-05-12 Thread Per Minborg
On Thu, 8 May 2025 14:30:28 GMT, Per Minborg wrote: > This PR proposed to let `ReverseOrderListView::reversed` directly return > `base` instead of going though a more complicated code path. This pull request has now been integrated. Changeset: 43008b42 Author: Per Minbor

Integrated: 8347408: Create an internal method handle adapter for system calls with errno

2025-05-12 Thread Per Minborg
On Mon, 5 May 2025 16:53:58 GMT, Per Minborg wrote: > As we advance, converting older JDK code to use the relatively new FFM API > requires system calls that can provide `errno` and the likes to explicitly > allocate a MemorySegment to capture potential error states. This ca

Re: RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory [v2]

2025-05-11 Thread Per Minborg
On Fri, 9 May 2025 15:39:35 GMT, Andrew Haley wrote: >> This intrinsic is generally faster than the current implementation for >> Panama segment operations for all writes larger than about 8 bytes in size, >> increasing to more than 2* the performance on larger memory blocks on >> Graviton 2,

Re: RFR: 8356080: Address post-integration comments for Stable Values [v2]

2025-05-09 Thread Per Minborg
> This PR proposes to address comments in the initial PR for Stable Values, > which were deferred until after integration. > > Unfortunately, this PR shows the total commit history for stable values. Per Minborg has updated the pull request with a new target base due to a merge

Re: RFR: 8356080: Address post-integration comments for Stable Values

2025-05-09 Thread Per Minborg
On Thu, 8 May 2025 16:08:24 GMT, Stuart Marks wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Unfortunately, this PR shows the total commit history for stable values. > > src/java.base/share/classes/java/u

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v10]

2025-05-09 Thread Per Minborg
On Thu, 8 May 2025 15:28:20 GMT, David Beaumont wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add composition of functions and MHs > > test/jdk/java/lang/StableValue/StableFieldUp

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v11]

2025-05-09 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request with a new target base due to a merge or a reba

Re: RFR: 8356486: ReverseOrderListView should override reversed() to return `base` [v2]

2025-05-09 Thread Per Minborg
> This PR proposed to let `ReverseOrderListView::reversed` directly return > `base` instead of going though a more complicated code path. Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Remove spurious class - Address co

Re: RFR: 8356486: ReverseOrderListView should override reversed() to return `base`

2025-05-09 Thread Per Minborg
On Fri, 9 May 2025 06:24:50 GMT, Per Minborg wrote: >> This should already be covered by the testDoubleReverse() test in >> test/jdk/java/util/SequencedCollection/Basic.java. > > There are some new collections (such as StableList) that are not covered in > Basic. But m

Re: RFR: 8356486: ReverseOrderListView should override reversed() to return `base`

2025-05-08 Thread Per Minborg
On Thu, 8 May 2025 16:13:19 GMT, Stuart Marks wrote: >> test/jdk/java/util/Collection/MOAT.java line 507: >> >>> 505: private static void testImmutableSeqColl(final >>> SequencedCollection c, T t) { >>> 506: SequencedCollection r = c.reversed(); >>> 507: if (r instanceof Li

RFR: 8356486: ReverseOrderListView::reversed should return `base`

2025-05-08 Thread Per Minborg
This PR proposed to let `ReverseOrderListView::reversed` return `base` so that nested reversed views are avoided. - Commit messages: - Let ReverseOrderListView::reversed return base Changes: https://git.openjdk.org/jdk/pull/25120/files Webrev: https://webrevs.openjdk.org/?repo=jd

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-08 Thread Per Minborg
On Wed, 7 May 2025 18:33:11 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v10]

2025-05-08 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v10]

2025-05-08 Thread Per Minborg
ead-local cache of memory regions to > allide allocations. Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Revert more incidental changes - Revert incidental change - Changes: - all: https://git.openjdk.org

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v9]

2025-05-08 Thread Per Minborg
On Thu, 8 May 2025 09:21:42 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address comments > > src/java.desktop/share/classes/javax/swing/plaf/nimbus/sk

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v8]

2025-05-08 Thread Per Minborg
ead-local cache of memory regions to > allide allocations. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove class - Changes: - all: https://git.openjdk.org/jdk/pull/25043/files - new: https://git.openj

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v8]

2025-05-08 Thread Per Minborg
On Thu, 8 May 2025 08:47:50 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove class > > src/java.base/share/classes/jdk/internal/foreign/CaptureStateUt

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v9]

2025-05-08 Thread Per Minborg
ead-local cache of memory regions to > allide allocations. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Address comments - Changes: - all: https://git.openjdk.org/jdk/pull/25043/files - new: https://git.openj

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v7]

2025-05-08 Thread Per Minborg
On Thu, 8 May 2025 07:40:44 GMT, Per Minborg wrote: >> As we advance, converting older JDK code to use the relatively new FFM API >> requires system calls that can provide `errno` and the likes to explicitly >> allocate a MemorySegment to capture potential error states

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v7]

2025-05-08 Thread Per Minborg
ead-local cache of memory regions to > allide allocations. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Clean up and remove unrelated changed - Changes: - all: https://git.openjdk.org/jdk/pull/25043/files - n

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v9]

2025-05-08 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v8]

2025-05-08 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit sinc

Integrated: 8356114: java/foreign/TestBufferStackStress2.java failed with junit action timed out

2025-05-07 Thread Per Minborg
On Wed, 7 May 2025 07:52:22 GMT, Per Minborg wrote: > This PR proposes to skip a stress test if the `main` thread is a virtual > thread. This pull request has now been integrated. Changeset: 1bdff3cc Author: Per Minborg URL: https://git.openjdk.org/jdk/

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v7]

2025-05-07 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v6]

2025-05-07 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v5]

2025-05-07 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request with a new target base due to a merge or a reba

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v4]

2025-05-07 Thread Per Minborg
On Wed, 7 May 2025 11:54:09 GMT, David Beaumont wrote: >> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Reformat >> - Revert changes in public classes >

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v4]

2025-05-07 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with two additional commits sinc

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v4]

2025-05-07 Thread Per Minborg
On Tue, 6 May 2025 12:23:44 GMT, Chen Liang wrote: >> This would require another implementation to be written. Maybe we can add >> that later? > > I feel like declaring a function is declaring redundant classes when we can > just reuse a DirectMethodHandle pointing to an actual method. Also the

Re: RFR: 8356114: java/foreign/TestBufferStackStress2.java failed with junit action timed out [v3]

2025-05-07 Thread Per Minborg
> This PR proposes to skip a stress test if the `main` thread is a virtual > thread. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Cleanup merges - Changes: - all: https://git.openjdk.org/jdk/pull/25084

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v2]

2025-05-07 Thread Per Minborg
On Tue, 6 May 2025 15:34:11 GMT, Daniel Fuchs wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix raw long updater under 32-bit mode > > src/java.base/share/classes/java/net/URI.jav

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v6]

2025-05-07 Thread Per Minborg
ead-local cache of memory regions to > allide allocations. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Simplify - Changes: - all: https://git.openjdk.org/jdk/pull/25043/files - new: https://git.openjdk.org/jdk

Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v4]

2025-05-07 Thread Per Minborg
On Wed, 7 May 2025 03:19:53 GMT, Shaojin Wen wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address comments > > src/java.base/share/classes/jdk/internal/foreign/CaptureState

  1   2   3   4   5   6   7   8   9   10   >