Re: Casting gatherer

2025-04-28 Thread Nir Lisker
Java Platform Group > Oracle > -- > *From:* core-libs-dev on behalf of Nir > Lisker > *Sent:* Saturday, 26 April 2025 20:55 > *To:* core-libs-dev@openjdk.org > *Subject:* Casting gatherer > > Hi, > > instanceof has been refitted to incl

Casting gatherer

2025-04-26 Thread Nir Lisker
Hi, instanceof has been refitted to include an auto-cast ("pattern matching on instanceof"). Unfortunately, doing this as an intermediate operation on a stream requires first to filter via instanceof and then map via a cast. This is because x instanceof MyClass myClass returns a boolean, not

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option [v2]

2024-05-31 Thread Nir Lisker
On Thu, 30 May 2024 22:54:12 GMT, Alexander Matveev wrote: >> This issue is reproducible with and without `--mac-sign`. jpackage will >> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by >> using pseudo-identity "_-_". This is why jpackage tries to sign added files >> a

Re: RFR: 8332110: [macos] jpackage tries to sign added files without the --mac-sign option

2024-05-31 Thread Nir Lisker
On Sat, 25 May 2024 01:12:56 GMT, Alexander Matveev wrote: > > For your example. This almost seems like an Apple bug if you can add a > > directory to the Contents directory but not a file? > > Not sure if it is an Apple bug. Can this be reported to Apple somehow? - PR Comment:

Re: RFR: 8266571: Sequenced Collections [v8]

2023-04-22 Thread Nir Lisker
On Fri, 21 Apr 2023 22:14:58 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/util/SequencedMap.java line 152: >> >>> 150: var it = entrySet().iterator(); >>> 151: return it.hasNext() ? Map.Entry.copyOf(it.next()) : null; >>> 152: } >> >> Would is be better to fi

Re: RFR: 8266571: Sequenced Collections [v8]

2023-04-20 Thread Nir Lisker
On Thu, 20 Apr 2023 04:19:55 GMT, Stuart Marks wrote: >> PR for Sequenced Collections implementation. > > Stuart Marks has updated the pull request incrementally with four additional > commits since the last revision: > > - Add missing @throws and @since tags. > - Convert code samples to snip

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-20 Thread Nir Lisker
On Wed, 19 Apr 2023 18:22:28 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/util/SequencedMap.java line 110: >> >>> 108: * {@code Entry} thus obtained will update a mapping in the underlying >>> map, or whether >>> 109: * it will throw an exception, or whether changes to the und

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-20 Thread Nir Lisker
On Wed, 19 Apr 2023 14:41:59 GMT, Nir Lisker wrote: >> Stuart Marks has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove unnecessary 'final' from a couple places. >> - Clarify ordering

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Nir Lisker
On Wed, 19 Apr 2023 03:37:05 GMT, Stuart Marks wrote: >> PR for Sequenced Collections implementation. > > Stuart Marks has updated the pull request incrementally with three additional > commits since the last revision: > > - Remove unnecessary 'final' from a couple places. > - Clarify orderin