On Tue, 22 Apr 2025 11:08:15 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which proposes to improve
>> the debuggability of `com/sun/jndi/ldap/LdapPoolTimeoutTest.java`?
>>
>> This test has been failing intermittently in our CI for several years.
>> Detailed a
On Tue, 22 Apr 2025 09:05:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which proposes to improve
> the debuggability of `com/sun/jndi/ldap/LdapPoolTimeoutTest.java`?
>
> This test has been failing intermittently in our CI for several years.
> Detailed are no
On Tue, 22 Apr 2025 09:05:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which proposes to improve
> the debuggability of `com/sun/jndi/ldap/LdapPoolTimeoutTest.java`?
>
> This test has been failing intermittently in our CI for several years.
> Detailed are no
On Wed, 16 Apr 2025 00:42:22 GMT, Brian Burkhalter wrote:
>> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for
>> file path validity with a sufficient test for file path invalidity. Also,
>> add a new test.
>
> Brian Burkhalter has updated the pull request incrementally
On Fri, 14 Mar 2025 09:17:06 GMT, KIRIYAMA Takuya wrote:
> The current test program for the logging feature added in JDK-8301627 does
> not fully check some important cases.
>
> Issue Details:
> The test does not properly check cases where logging might not happen due to
> different logging le
On Fri, 21 Mar 2025 09:01:01 GMT, KIRIYAMA Takuya wrote:
>> test/jdk/java/lang/RuntimeTests/RuntimeExitLogTest.java line 52:
>>
>>> 50: private static final String TEST_JDK =
>>> System.getProperty("test.jdk");
>>> 51: private static final String TEST_SRC =
>>> System.getProperty("test
On Tue, 25 Mar 2025 11:56:37 GMT, Mikhail Yankelevich
wrote:
> Updating `jdk.test.lib.SecurityTools` class to have jar method accept
> `List` parameter similar to `keytool` methods.
> Currently this only accept String parameter, which is error prone with
> missing space
This pull
Updating `jdk.test.lib.SecurityTools` class to have jar method accept
`List` parameter similar to `keytool` methods.
Currently this only accept String parameter, which is error prone with missing
space
-
Commit messages:
- Update jdk.test.lib.SecurityTools jar method to accept List
On Thu, 20 Mar 2025 22:35:23 GMT, Brent Christian wrote:
> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
> up the intermittent failures:
>
> * run with `othervm`: this test blocks the (global) finalizer thread, and
> also requires the (global) finalizer thread to
On Fri, 14 Mar 2025 18:35:12 GMT, Joe Wang wrote:
> Thanks for review. Updated the test.
Thank you!
-
PR Comment: https://git.openjdk.org/jdk/pull/24039#issuecomment-2729299732
On Thu, 13 Mar 2025 19:01:03 GMT, Joe Wang wrote:
> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
> Shema 1.0 DTDs.
Looks good to me, just a few very minor questions. Thank you
test/jaxp
On Mon, 3 Mar 2025 20:24:54 GMT, Vladimir Ivanov wrote:
> test setup was updated to generate data of requested size.
Looks good. Just 1 minor question
test/micro/org/openjdk/bench/java/lang/foreign/ToCStringTest.java line 100:
> 98: mollit anim id est laborum.
> 99:
On Tue, 25 Feb 2025 23:50:01 GMT, Chen Liang wrote:
> Core reflection's generic signature parsing system is used for many aspects,
> including annotations and enclosing methods, yet it is under-tested. It is
> better for us to set up tests to ensure that sensitive error behaviors of
> core ref
13 matches
Mail list logo
