On Wed, 4 Jan 2023 01:19:52 GMT, Jaikiran Pai wrote:
>> Michael Ernst has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge ../jdk-openjdk into typos-typos
>> - Reinstat
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8299563: Fix typos
This pull request has now been integrated.
Changeset: 7dcc6899
Author: Michael Ernst
Committer: Alexey Ivanov
URL:
https://git.openjdk.org/jdk/commit/7dcc689932ea276586282e0917f2efc10a598eb7
Stats:
> 8299563: Fix typos
Michael Ernst has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains ten commits:
- Address review feedback
- Merge ../jdk-openjdk into typos-typos
- Merge ../jdk-openjdk into typos-typos
- Reinstate typos in Apa
On Mon, 28 Nov 2022 09:00:09 GMT, Jaikiran Pai wrote:
>> Could someone who knows the undocumented ins and outs of creating JDK pull
>> requests could split this pull request up into multiple PRs? Then it can be
>> merged, rather than wasting all the effort that went into it.
>
>> Could someone
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
Michael Ernst has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains seven commits:
- Merge ../jdk-openjdk into typos-typos
- Reinstate typos in Apache c
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
&g
On Wed, 28 Sep 2022 15:26:13 GMT, Alexey Ivanov wrote:
> The title says under `test/jdk/*`, yet there are lots of files changed in
> `src/*`.
The title was edited by someone other than me, as you can see from the PR
history.
-
PR: https://git.openjdk.org/jdk/pull/10029
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
&g
On Mon, 26 Sep 2022 19:36:02 GMT, Lance Andersen wrote:
> Thank you for your efforts on the cleaning up these typos
>
> I would suggest breaking these changes into separate PRs by team as there
> seems to be changes to hotspot, core-libs, and client to make it easier to
> review.
>
> I realiz
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
Michael Ernst has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains six commits:
- Reinstate typos in Apache code that is copied into the JDK
- Merge ../
On Tue, 30 Aug 2022 09:55:18 GMT, Lance Andersen wrote:
>> src/java.base/share/native/libzip/zlib/zlib.h line 756:
>>
>>> 754:If this is done, the old level and strategy will be applied to the
>>> data
>>> 755:compressed before deflateParams(), and the new level and strategy
>>> will b
On Sun, 25 Sep 2022 16:51:27 GMT, SWinxy wrote:
> Oh no what happened
Oops! Thanks for pointing out the goof. It seems to be fixed now.
It has now been a month since I opened the pull request, and I have responded
to each substantive comment promptly. It would be great to merge this pull
r
On Sat, 24 Sep 2022 10:41:05 GMT, Jaikiran Pai wrote:
> Splitting these changes into smaller PRs instead of one big one that touches
> several different areas of the JDK and 108 files, will help reviewers.
OK. I'll repeat my comment from before:
> Feel free to split up the pull request, if yo
On Mon, 5 Sep 2022 06:32:44 GMT, Jaikiran Pai wrote:
> these changes are mostly fine.
Can you be specific about the exact problems that you noticed that prevented
you from saying "these changes are fine"? It doesn't seem useful to make a
pull request with known deficiencies.
> we usually spl
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
> If you already are an OpenJDK
> [Author](https://openjdk.java.net/bylaws#author),
> [Committer](https://openjdk.java.net/bylaws#committer) or
8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
-
Commit messages:
- Remove file that was removed upstream
- Fix inconsistency in capitalization
- Undo change in zlip
- Fix typos
Changes: https://git.openjdk.org/jdk/pull/10029/files
Webrev: https://we
16 matches
Mail list logo
