RFR: 8351354: Enhance java -XshowSettings:security:tls to show enabled TLS groups and signature algorithms

2025-04-03 Thread Matthew Donovan
In this PR I added TLS groups and signature algorithms to the output of the show settings flag. The values are printed in a single column, like the cipher suites. There can be a lot of values so putting on a single line is ugly. I tried putting them in columns, but it is hard to read. -

Integrated: 8319648: java/lang/SecurityManager tests ignore vm flags

2024-03-01 Thread Matthew Donovan
On Thu, 15 Feb 2024 17:06:25 GMT, Matthew Donovan wrote: > In this PR I updated the tests to use the newer > ProcessTools.createTestJavaProcessBuilder methods to pass VM options to child > processes. This pull request has now been integrated. Changeset: 437cf354 Author: Matthe

Re: RFR: 8319648: java/lang/SecurityManager tests ignore vm flags [v2]

2024-02-27 Thread Matthew Donovan
> In this PR I updated the tests to use the newer > ProcessTools.createTestJavaProcessBuilder methods to pass VM options to child > processes. Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: removed unused import

RFR: 8319648: java/lang/SecurityManager tests ignore vm flags

2024-02-15 Thread Matthew Donovan
In this PR I updated the tests to use the newer ProcessTools.createTestJavaProcessBuilder methods to pass VM options to child processes. - Commit messages: - 8319648: java/lang/SecurityManager tests ignore vm flags Changes: https://git.openjdk.org/jdk/pull/17878/files Webrev: htt

Integrated: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java

2023-10-23 Thread Matthew Donovan
On Wed, 19 Jul 2023 12:03:40 GMT, Matthew Donovan wrote: > This PR refactors the SSLSocketParametersTest by removing > redundant/unnecessary classes and cleans up the logic around expected > exceptions. This pull request has now been integrated. Changeset: 704c6ea1 Author: Matthe

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java [v5]

2023-10-18 Thread Matthew Donovan
> This PR refactors the SSLSocketParametersTest by removing > redundant/unnecessary classes and cleans up the logic around expected > exceptions. Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: added reachability fenc

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java [v4]

2023-10-18 Thread Matthew Donovan
> This PR refactors the SSLSocketParametersTest by removing > redundant/unnecessary classes and cleans up the logic around expected > exceptions. Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: reworked assertThrows an

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java [v3]

2023-10-17 Thread Matthew Donovan
On Mon, 16 Oct 2023 23:56:24 GMT, Stuart Marks wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> retained a reference to the RMI server and improved naming > > test/lib/jdk/

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java [v3]

2023-10-16 Thread Matthew Donovan
> This PR refactors the SSLSocketParametersTest by removing > redundant/unnecessary classes and cleans up the logic around expected > exceptions. Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: retained a reference t

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java [v2]

2023-10-11 Thread Matthew Donovan
> This PR refactors the SSLSocketParametersTest by removing > redundant/unnecessary classes and cleans up the logic around expected > exceptions. Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java

2023-09-17 Thread Matthew Donovan
On Wed, 19 Jul 2023 12:03:40 GMT, Matthew Donovan wrote: > This PR refactors the SSLSocketParametersTest by removing > redundant/unnecessary classes and cleans up the logic around expected > exceptions. Hi, I'm still looking for a reviewer for this PR. Thanks! ---

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java

2023-08-16 Thread Matthew Donovan
On Wed, 19 Jul 2023 12:03:40 GMT, Matthew Donovan wrote: > This PR refactors the SSLSocketParametersTest by removing > redundant/unnecessary classes and cleans up the logic around expected > exceptions. I'm still looking for a reviewer for this PR. Thanks! - PR

Integrated: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList

2023-07-20 Thread Matthew Donovan
On Wed, 19 Jul 2023 12:58:43 GMT, Matthew Donovan wrote: > This PR removes javax/rmi/ssl/SSLSocketParametersTest.sh from the > ProblemList. The script was removed in JDK-8298939 and the Java code > refactored to be a jtreg test. This pull request has now been integrated. Changeset:

RFR: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList

2023-07-19 Thread Matthew Donovan
This PR removes javax/rmi/ssl/SSLSocketParametersTest.sh from the ProblemList. The script was removed in JDK-8298939 and the Java code refactored to be a jtreg test. - Commit messages: - 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList Changes: https://git

RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java

2023-07-19 Thread Matthew Donovan
This PR refactors the SSLSocketParametersTest by removing redundant/unnecessary classes and cleans up the logic around expected exceptions. - Commit messages: - added javadocs to new methods - 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java Chan

Integrated: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test

2023-03-06 Thread Matthew Donovan
On Mon, 9 Jan 2023 19:54:24 GMT, Matthew Donovan wrote: > Removed SSLSocketParametersTest.sh script (which just called a Java file) and > configured the java code to run directly with jtreg This pull request has now been integrated. Changeset: ccfe1675 Author:Matthew Donovan Com

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v6]

2023-03-02 Thread Matthew Donovan
On Wed, 1 Mar 2023 15:25:07 GMT, Matthew Donovan wrote: >> Removed SSLSocketParametersTest.sh script (which just called a Java file) >> and configured the java code to run directly with jtreg > > Matthew Donovan has updated the pull request with a new target base due to a &

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v6]

2023-03-01 Thread Matthew Donovan
> Removed SSLSocketParametersTest.sh script (which just called a Java file) and > configured the java code to run directly with jtreg Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brou

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v3]

2023-02-27 Thread Matthew Donovan
On Tue, 21 Feb 2023 18:59:35 GMT, Stuart Marks wrote: >> I don't think all of those code paths ever executed. If `System.exit()` is >> called, regardless of the exit code, `make` treats it as an error: >> >> `TEST RESULT: Failed. Unexpected exit from test [exit code: 0]` >> >> I added a try/ca

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v4]

2023-02-27 Thread Matthew Donovan
On Tue, 21 Feb 2023 19:06:02 GMT, Stuart Marks wrote: >> Matthew Donovan has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request conta

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v5]

2023-02-27 Thread Matthew Donovan
> Removed SSLSocketParametersTest.sh script (which just called a Java file) and > configured the java code to run directly with jtreg Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: cleaned up exception ha

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v4]

2023-02-17 Thread Matthew Donovan
On Fri, 17 Feb 2023 15:17:59 GMT, Roger Riggs wrote: >> Matthew Donovan has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request conta

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v3]

2023-02-17 Thread Matthew Donovan
On Fri, 17 Feb 2023 19:57:18 GMT, Roger Riggs wrote: >> test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 211: >> >>> 209: throw exc; >>> 210: } >>> 211: } >> >> Having exception handling in the run() method and also in this swi

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v3]

2023-02-17 Thread Matthew Donovan
On Fri, 17 Feb 2023 19:33:04 GMT, Stuart Marks wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added exceptions for cases 4 and 5 > > test/jdk/javax/rmi/ssl/SSLSocketParameter

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v4]

2023-02-17 Thread Matthew Donovan
> Removed SSLSocketParametersTest.sh script (which just called a Java file) and > configured the java code to run directly with jtreg Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brou

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v3]

2023-02-17 Thread Matthew Donovan
On Fri, 17 Feb 2023 15:27:04 GMT, Roger Riggs wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added exceptions for cases 4 and 5 > > test/jdk/javax/rmi/ssl/SSLSocketParamet

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v3]

2023-02-07 Thread Matthew Donovan
> Removed SSLSocketParametersTest.sh script (which just called a Java file) and > configured the java code to run directly with jtreg Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: added exceptions for cases 4

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v2]

2023-02-07 Thread Matthew Donovan
On Tue, 7 Feb 2023 20:10:47 GMT, Daniel Fuchs wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> clarified cases 4 and 5 > > test/jdk/javax/rmi/ssl/SSLSocketParameter

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v2]

2023-02-07 Thread Matthew Donovan
On Tue, 7 Feb 2023 16:13:40 GMT, Daniel Fuchs wrote: >> The expected result of cases 4 and 5 is that an IllegalArgumentException is >> thrown because of the unsupported ciphersuite. The original code just caught >> `Exception` which would hide a problem in the test e.g., if >> `SSLContext.getD

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v2]

2023-02-07 Thread Matthew Donovan
> Removed SSLSocketParametersTest.sh script (which just called a Java file) and > configured the java code to run directly with jtreg Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: clarified cases 4 and 5 - C

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test

2023-02-07 Thread Matthew Donovan
On Tue, 7 Feb 2023 15:54:06 GMT, Daniel Fuchs wrote: >> Removed SSLSocketParametersTest.sh script (which just called a Java file) >> and configured the java code to run directly with jtreg > > test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 192: > >> 190: throw

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test

2023-02-07 Thread Matthew Donovan
On Mon, 9 Jan 2023 19:54:24 GMT, Matthew Donovan wrote: > Removed SSLSocketParametersTest.sh script (which just called a Java file) and > configured the java code to run directly with jtreg Can someone take a look at this? Thanks! - PR: https://git.openjdk.org/jdk/pull/11910

RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTestsh to jtreg java test

2023-01-09 Thread Matthew Donovan
Removed SSLSocketParametersTest.sh script (which just called a Java file) and configured the java code to run directly with jtreg - Commit messages: - 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test Changes: https://git.openjdk.org/jdk/p