Re: RFR: 8342938: Problem list java/io/IO/IO.java test on Linux ppc64le

2024-10-25 Thread Lutz Schmidt
On Thu, 24 Oct 2024 09:08:09 GMT, Matthias Baesken wrote: > Test java/io/IO/IO.java fails on Linux ppc64le because of issues with > 'expect' . LGTM. - Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21678#pullrequestreview-2392339879

Re: RFR: 8340801: Disable ubsan checks in some awt/2d coding [v4]

2024-10-14 Thread Lutz Schmidt
On Fri, 11 Oct 2024 18:05:58 GMT, Kim Barrett wrote: >> Matthias Baesken has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> comm

Re: RFR: 8340801: Disable ubsan checks in some awt/2d coding [v4]

2024-10-14 Thread Lutz Schmidt
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote: >> There is some old awt/2d coding where warnings occur when running with ubsan >> enabled binaries. >> However at most of these locations the coding should work (at least on our >> supported platform set) so the warnings can be disabled

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-09 Thread Lutz Schmidt
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > Matthias Baesken has

Re: RFR: 8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java

2024-09-18 Thread Lutz Schmidt
On Thu, 12 Sep 2024 05:12:18 GMT, Amit Kumar wrote: > This PR will ProblemList `jdk/java/util/zip/CloseInflaterDeflaterTest.java` > on s390x. This change should be reverted while fixing > [JDK-8339216](https://bugs.openjdk.org/browse/JDK-8339216). Looks good. And trivial. - Marke

Re: RFR: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message [v4]

2024-09-09 Thread Lutz Schmidt
On Mon, 9 Sep 2024 07:06:22 GMT, Matthias Baesken wrote: >> When running jtreg test java/lang/ProcessHandle/PermissionTest.java on >> macOS, a few times this error occurs : >> >> java.lang.RuntimeException: Cannot allocate memory >>at java.base/java.lang.ProcessHandleImpl.getProcessPids

Re: RFR: 8339487: ProcessHandleImpl native exceptions - include message text and last error information

2024-09-04 Thread Lutz Schmidt
On Tue, 3 Sep 2024 14:09:23 GMT, Matthias Baesken wrote: > When running jtreg test java/lang/ProcessHandle/PermissionTest.java on macOS, > a few times this error occurs : > > java.lang.RuntimeException: Cannot allocate memory >at java.base/java.lang.ProcessHandleImpl.getProcessPids0(Nat

Re: RFR: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN

2024-04-24 Thread Lutz Schmidt
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote: > In the hashN usages of readCen from zip_util.c we see a lot of signed integer > overflows. > For example in the java/util jtreg tests those are easily reproducable when > compiling with -ftrapv (clang/gcc toolchains). > While those ove

Re: [jdk22] RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64

2024-01-24 Thread Lutz Schmidt
On Tue, 23 Jan 2024 10:21:42 GMT, Goetz Lindenmaier wrote: > I backport this to fix this issue in 22. We see it failing there in our CI. Looks good. - Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/95#pullrequestreview-1841351221

Re: RFR: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java

2023-10-24 Thread Lutz Schmidt
On Tue, 24 Oct 2023 09:51:20 GMT, Goetz Lindenmaier wrote: > …tipleRegistries.java > > The test fails in our CI with the message listed here. We see both, aarch and > x86_64. It happens rarely, but a long time back. LGTM. - Marked as reviewed by lucy (Reviewer). PR Review: https

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v10]

2023-10-20 Thread Lutz Schmidt
On Fri, 20 Oct 2023 08:38:22 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and the

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v6]

2023-10-19 Thread Lutz Schmidt
On Wed, 18 Oct 2023 17:04:52 GMT, Sidraya Jayagond wrote: >> Jorn Vernee has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - add PPC impl >> - add missing file > > Add s390x port from here > [S390x_Panama_heap_segments.txt](https://githu

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v7]

2023-10-19 Thread Lutz Schmidt
On Wed, 18 Oct 2023 17:38:24 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and the

Re: RFR: JDK-8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le

2023-09-07 Thread Lutz Schmidt
On Wed, 6 Sep 2023 14:47:20 GMT, Matthias Baesken wrote: > The test RandomTestBsi1999 fails often with timeouts on Linux ppc64le; even > when it succeeds the test takes a lot of time and is close to timing out. > Probably we should increase the timeout value for this test. Looks good. ---

Re: RFR: JDK-8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8

2023-09-05 Thread Lutz Schmidt
On Fri, 1 Sep 2023 07:22:12 GMT, Matthias Baesken wrote: > on some RHEL Linux 8.X machines , we run into errors in test > tools/jpackage/share/RuntimePackageTest.java#id0 , error can be seen below. > It looks like these errors occur when running the jtreg tests with higher > concurrency, I did

Re: RFR: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work

2023-06-21 Thread Lutz Schmidt
On Tue, 20 Jun 2023 13:23:16 GMT, Matthias Baesken wrote: > Currently, a number of tests fail on macOS because they miss the core file > (e.g. serviceability/sa/TestJmapCore.java). > The reason is that configure detects on some setups that codesign does not > work ("checking if debug mode codes

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v10]

2023-04-12 Thread Lutz Schmidt
On Wed, 12 Apr 2023 03:44:45 GMT, Amit Kumar wrote: > Another remark: Old JDK on s390 used "os.arch = zArch_64", current one > "os.arch = s390x". @offamitkumar: You probably want to take a look. zArch_64 is not relevant/not used in the OpenJDK port to IBM System z. As noted elsewhere in the PR

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Lutz Schmidt
On Fri, 7 Apr 2023 11:21:33 GMT, Thomas Stuefe wrote: >> Hello Thomas, that change was based on the review comment here >> https://github.com/openjdk/jdk/pull/13357#discussion_r1159810942 > > Okay, Lutz is the expert here. Sorry for the noise. Just to let my voice be heard directly after being

Re: RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details [v2]

2022-09-21 Thread Lutz Schmidt
On Fri, 16 Sep 2022 07:27:44 GMT, Matthias Baesken wrote: >> When trying to load a x64 lib on macOS aarch64 one got previously this >> detailed message before >> [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): >> >> java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.