On Thu, 2 Oct 2025 16:17:32 GMT, Roger Riggs wrote:
>> Code cleanup in java.lang.StringLatin1 and StringUTF16.
>> Remove the `public` qualifier from methods where it is not needed.
>> Remove an unused toBytes method.
>> Remove unused codePointXXX methods.
>> Remove unnecessary casts of primitive
On Wed, 1 Oct 2025 17:45:41 GMT, Roger Riggs wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing
>> of streams and ensuring the termination of the process is the responsibility
>> of the caller. The `Process.close()` method provides a clear and obvious way
>>
Can I please get a review of this change to a jtreg failure handler configured
in the JDK?
The change proposes to generate a thread dump much sooner than previously
whenever a test times out. This should thus capture a much more accurate state
of the test process when the test is considered tim
On Mon, 29 Sep 2025 15:08:14 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
On Mon, 29 Sep 2025 15:08:14 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
On Mon, 22 Sep 2025 22:25:59 GMT, Roger Riggs wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing
>> of streams and ensuring the termination of the process is the responsibility
>> of the caller. The `Process.close()` method provides a clear and obvious way
>>
On Mon, 22 Sep 2025 22:25:59 GMT, Roger Riggs wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing
>> of streams and ensuring the termination of the process is the responsibility
>> of the caller. The `Process.close()` method provides a clear and obvious way
>>
On Wed, 10 Sep 2025 19:46:12 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
On Mon, 22 Sep 2025 19:07:43 GMT, Roger Riggs wrote:
>> 8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception:
>> Stack trace
>> With MacOsX Sequoia 15.7 the command environment contains a new TMPDIR
>> variable.
>> The ProcessBuild/Basic test checks for a small set of vari
On Thu, 14 Aug 2025 11:44:44 GMT, Kieran Farrell wrote:
>> Kieran Farrell has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update note to @api note
>
> Hi All, Would it be possible to progress review with this?
That sounds reasonable to
On Wed, 10 Sep 2025 19:46:12 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
On Tue, 23 Sep 2025 14:18:27 GMT, Jaikiran Pai wrote:
> Given all this, I think the API we provide must try and achieve these primary
> motivations. That would then mean, not allowing arbitrary values to be passed
> by applications for generating a UUIDv7 UUID instance.
To ph
On Tue, 23 Sep 2025 14:08:35 GMT, Roger Riggs wrote:
>> 8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception:
>> Stack trace
>> With MacOsX Sequoia 15.7 the command environment contains a new TMPDIR
>> variable.
>> The ProcessBuild/Basic test checks for a small set of vari
On Mon, 22 Sep 2025 13:26:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to a test library class which
> proposes to remove the calls to `MessageDigest` from the static initializer
> of `jdk.test.lib.Utils`?
>
> The `Utils` test library class cons
Can I please get a review of this change to a test library class which proposes
to remove the calls to `MessageDigest` from the static initializer of
`jdk.test.lib.Utils`?
The `Utils` test library class constructs a random generator which can be used
in tests. Back in JDK 16, we updated this cl
On Mon, 22 Sep 2025 13:26:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to a test library class which
> proposes to remove the calls to `MessageDigest` from the static initializer
> of `jdk.test.lib.Utils`?
>
> The `Utils` test library class cons
On Mon, 22 Sep 2025 14:57:34 GMT, Roger Riggs wrote:
> Problem list test/jdk/java/lang/ProcessBuilder/Basic.java#id0 until it can be
> fixed.
> It is likely due to an upgrade in macosx but need to be addressed.
>
> See: [JDK-8368192 Test java/lang/ProcessBuilder/Basic.java#id0 fails with
> Exc
On Wed, 17 Sep 2025 12:50:56 GMT, SendaoYan wrote:
> Hi all,
>
> After [JDK-8260555](https://bugs.openjdk.org/browse/JDK-8260555) changed the
> default TIMEOUT_FACTOR from 4 to 1, test java/io/FileDescriptor/Sync.java
> intermittent timed out when run with other test simultancely.
>
> If I ru
On Mon, 22 Sep 2025 08:13:55 GMT, Alan Bateman wrote:
> The no-arg Thread.stop has been deprecated since JDK 1.2, deprecated for
> removal since JDK 18, and re-specified to throw UOE unconditionally since JDK
> 20. It is time to finally remove the method. Its more evil sibling
> Thread.stop(Th
On Sun, 21 Sep 2025 09:10:54 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Sat, 13 Sep 2025 08:47:21 GMT, Alan Bateman wrote:
> On second thoughts, Shutdown.exit might be better place, meaning only attempt
> to log if the VM is full initialized.
That's fine too. Right now `logRuntimeExit()` is only invoked from
`Shutdown.exit()` and I don't expect additional place
On Fri, 12 Sep 2025 12:08:35 GMT, David Beaumont wrote:
>> Summary: Add two new methods to ImageReader to make SystemModuleReader more
>> performant.
>>
>> Analysis of benchmarks shows that when the vast majority of resources
>> (~11,000 in the Perfstartup-SwingSet-G1 benchmark) tested for in
On Thu, 11 Sep 2025 10:42:31 GMT, Daniel Fuchs wrote:
>> There were two `@run` lines, one without a timeout (which is now removed),
>> and a later one with a timeout of 400.
>> IIUC, this means that the test was executed 2 times, one with a default
>> timeout, and another with the explicit time
On Tue, 9 Sep 2025 15:31:40 GMT, David Beaumont wrote:
>> The writer field of the handler needs to be re-checked for null inside the
>> locked region before use.
>
> David Beaumont has updated the pull request incrementally with one additional
> commit since the last revision:
>
> License fi
On Wed, 17 Sep 2025 16:58:04 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
er1, tier2 and tier3 tests continue to pass with this change. I've marked
> the fix version of this issue for 26 and I don't plan to push this for 25.
Jaikiran Pai has updated the pull request incrementally with two additional
commits since the last revision:
- move the new te
On Thu, 18 Sep 2025 05:52:07 GMT, Christian Stein wrote:
>> Please review the change to update to using jtreg 8.
>>
>> The primary change is to the `jib-profiles.js` file, which specifies the
>> version of jtreg to use, for those systems that rely on this file. In
>> addition, the requiredVers
On Mon, 26 May 2025 12:28:16 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8357708?
>
> As noted in the issue, the current code in
> `com.sun.jndi.ldap.Connection.
On Tue, 5 Aug 2025 16:04:08 GMT, Chen Liang wrote:
>> Provide a general facility for our null check APIs like
>> Objects::requireNonNull or future Checks::nullCheck (void), converting the
>> existing infrastructure to start tracking from a given stack site (depth
>> offset) and a given stack s
On Thu, 11 Sep 2025 17:22:27 GMT, David Beaumont wrote:
>> Summary: Add two new methods to ImageReader to make SystemModuleReader more
>> performant.
>>
>> Analysis of benchmarks shows that when the vast majority of resources
>> (~11,000 in the Perfstartup-SwingSet-G1 benchmark) tested for in
On Fri, 12 Sep 2025 12:08:35 GMT, David Beaumont wrote:
>> Summary: Add two new methods to ImageReader to make SystemModuleReader more
>> performant.
>>
>> Analysis of benchmarks shows that when the vast majority of resources
>> (~11,000 in the Perfstartup-SwingSet-G1 benchmark) tested for in
On Sat, 13 Sep 2025 09:35:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses the issue noted in
>> https://bugs.openjdk.org/browse/JDK-8367597?
>>
>> As noted in that issue, on certain occasions, during shutdown of the JVM,
>>
On Sat, 13 Sep 2025 07:10:42 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8367597?
>
> As noted in that issue, on certain occasions, during shutdown of the JVM, the
> logging i
Can I please get a review of this change which removes the `jrunscript` tool?
This addresses https://bugs.openjdk.org/browse/JDK-8367157.
`jrunscript` is an experimental and unsupported tool which was deprecated for
removal in Java 24. The commits in this PR remove the tool, its man pages and
a
with this change completed without any related issues and
> additional tier testing is currently in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
move the check to Shutdown.exit()
-
Changes:
- all
On Sat, 13 Sep 2025 07:25:50 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan's review - move the VM.isBooted() check outside try block
>
> src/java.base/sh
with this change completed without any related issues and
> additional tier testing is currently in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Alan's review - move the VM.isBooted() check outside try block
---
Can I please get a review of this change which addresses the issue noted in
https://bugs.openjdk.org/browse/JDK-8367597?
As noted in that issue, on certain occasions, during shutdown of the JVM, the
logging in `Runtime.exit()` generates a `NullPointerException`. The issue is
due to the JVM not
On Fri, 12 Sep 2025 16:04:59 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8357708?
>>
>> As noted in the issue, the current code in
>> `com.sun.jndi.l
On Fri, 12 Sep 2025 16:04:59 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8357708?
>>
>> As noted in the issue, the current code in
>> `com.sun.jndi.l
On Fri, 12 Sep 2025 11:50:16 GMT, David Beaumont wrote:
> I'll just add the empty path case and leave it at that.
That's fine with me. More as a FYI though - I had a typo in my original
CsvSource comment/example, which I later modified. So I don't know if that is
what is causing this error.
-
On Thu, 11 Sep 2025 17:22:27 GMT, David Beaumont wrote:
>> Summary: Add two new methods to ImageReader to make SystemModuleReader more
>> performant.
>>
>> Analysis of benchmarks shows that when the vast majority of resources
>> (~11,000 in the Perfstartup-SwingSet-G1 benchmark) tested for in
On Wed, 10 Sep 2025 15:18:25 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six addi
er1, tier2 and tier3 tests continue to pass with this change. I've marked
> the fix version of this issue for 26 and I don't plan to push this for 25.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
er1, tier2 and tier3 tests continue to pass with this change. I've marked
> the fix version of this issue for 26 and I don't plan to push this for 25.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrela
On Thu, 11 Sep 2025 08:55:02 GMT, Raffaello Giulietti
wrote:
> This PR
> * Moves sqrt() and nthRoot() tests to a new subset.
> * Removes a leftover `@run` tag without a timeout.
> * Increases the explicit timeout from 400 to 480.
> * Sorts the jtreg tags according to standard conventions.
The r
On Wed, 10 Sep 2025 18:08:20 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Wed, 10 Sep 2025 21:03:32 GMT, Roger Riggs wrote:
> JNI exception pending in os_getCmdlineAndUserInfo of
> ProcessHandleImpl_macosx.c:306
> Minor cleanup of a missing check for exception pending.
Marked as reviewed by jpai (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pu
On Wed, 6 Aug 2025 05:15:46 GMT, Shaojin Wen wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four addi
On Tue, 9 Sep 2025 07:18:25 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes the `jrunscript` tool?
> This addresses https://bugs.openjdk.org/browse/JDK-8367157.
>
> `jrunscript` is an experimental and unsupported tool which was deprecated for
On Thu, 4 Sep 2025 15:47:33 GMT, Aleksey Shipilev wrote:
> GetStackTraceALotWhenPinned test times out every so often in GHA.
>
> The last sightings are on macos-aarch64:
>
>
> 2025-09-04T10:41:29.357879Z => 87894 of 10
> 2025-09-04T10:41:30.365534Z => 88105 of 10
> Timeout signalled af
On Fri, 29 Aug 2025 14:33:03 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which addresses a failure
> in `test/jdk/java/util/zip/ZipFile/ZipSourceCache.java` test?
>
> As noted in the description of https://bugs.openjdk.org/browse/JDK-8366439,
On Wed, 3 Sep 2025 07:32:19 GMT, Sean Coffey wrote:
> I'm still thinking the inner ZIpFile logic might have an issue if it can't
> detect an update to a ZipFile. The inner Source class will return an
> incorrect mapping and CEN calculation if a new Source isn't created.
It's true that until a
On Mon, 1 Sep 2025 05:31:43 GMT, Amit Kumar wrote:
> Originally Reported in OpenJ9, fix by @AditiS11 present here:
> https://github.com/ibmruntimes/openj9-openjdk-jdk25/pull/32
>
> These test failure were reported in OpenJ9 (x86), I can't reproduce on my
> system (s390x):
>
> java/foreign/Te
On Mon, 1 Sep 2025 05:31:43 GMT, Amit Kumar wrote:
> Originally Reported in OpenJ9, fix by @AditiS11 present here:
> https://github.com/ibmruntimes/openj9-openjdk-jdk25/pull/32
>
> These test failure were reported in OpenJ9 (x86), I can't reproduce on my
> system (s390x):
>
> java/foreign/Te
On Fri, 29 Aug 2025 14:33:03 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which addresses a failure
> in `test/jdk/java/util/zip/ZipFile/ZipSourceCache.java` test?
>
> As noted in the description of https://bugs.openjdk.org/browse/JDK-8366439,
On Mon, 1 Sep 2025 19:22:50 GMT, Philippe Marschall wrote:
>> Use `JavaLangAccess::uncheckedNewStringNoRepl` in `MemorySegment::getString`
>> to avoid byte[] allocation in the String constructor.
>>
>> Fall back to the old code in the case of malformed input to get replacement
>> characters as
On Tue, 2 Sep 2025 16:50:27 GMT, Henry Jen wrote:
>> Create a jar directly from the memory instead of real file, this should
>> reduce the I/O overhead which likely the reason for the time out.
>> The issue is not reproducible locally, and fails intermittently, so we
>> simply trying to reduce
On Tue, 2 Sep 2025 14:27:28 GMT, Henry Jen wrote:
>> Create a jar directly from the memory instead of real file, this should
>> reduce the I/O overhead which likely the reason for the time out.
>> The issue is not reproducible locally, and fails intermittently, so we
>> simply trying to reduce
On Tue, 2 Sep 2025 13:11:04 GMT, Volkan Yazici wrote:
> Recently merged JDK-8356439, renaming `JavaLangAccess::*NoRepl` methods, has
> conflicting changes with JDK-8362893 slightly preceding it. Back out
> JDK-8356439 by reverting eea50fbc1b2.
I've verified that this is a clean "git revert" of
On Mon, 18 Aug 2025 08:01:58 GMT, Johny Jose wrote:
> Increasing the count value of available objects to 6 (which is half the
> number of objects created). The failures were reported in macos which seems
> to take more time to clear the objects. Though majority runs has less values
> for objec
On Mon, 1 Sep 2025 05:31:43 GMT, Amit Kumar wrote:
> Originally Reported in OpenJ9, fix by @AditiS11 present here:
> https://github.com/ibmruntimes/openj9-openjdk-jdk25/pull/32
>
> These test failure were reported in OpenJ9 (x86), I can't reproduce on my
> system (s390x):
>
> java/foreign/Te
On Tue, 2 Sep 2025 05:38:22 GMT, Amit Kumar wrote:
> but couldn't reproduce the failure on openjdk.
Not being able to generate a JVM crash or a test failure from that test is
understandable and OK. Such memory access issues aren't always reproducible in
a deterministic manner. So yes, it's OK
On Mon, 28 Jul 2025 17:10:13 GMT, Philippe Marschall wrote:
>> Use `JavaLangAccess::uncheckedNewStringNoRepl` in `MemorySegment::getString`
>> to avoid byte[] allocation in the String constructor.
>>
>> Fall back to the old code in the case of malformed input to get replacement
>> characters a
On Mon, 1 Sep 2025 05:31:43 GMT, Amit Kumar wrote:
> Originally Reported in OpenJ9, fix by @AditiS11 present here:
> https://github.com/ibmruntimes/openj9-openjdk-jdk25/pull/32
>
> These test failure were reported in OpenJ9 (x86), I can't reproduce on my
> system (s390x):
>
> java/foreign/Te
On Fri, 1 Aug 2025 18:03:52 GMT, Henry Jen wrote:
>> Create a jar directly from the memory instead of real file, this should
>> reduce the I/O overhead which likely the reason for the time out.
>> The issue is not reproducible locally, and fails intermittently, so we
>> simply trying to reduce
On Fri, 29 Aug 2025 20:12:42 GMT, Francesco Andreuzzi wrote:
> [JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
> rather than removing it. The code can be removed safely, as pointed out in
> the PR review: #21654.
Looks OK to me.
-
Marked as reviewed
Can I please get a review of this test-only change which addresses a failure in
`test/jdk/java/util/zip/ZipFile/ZipSourceCache.java` test?
As noted in the description of https://bugs.openjdk.org/browse/JDK-8366439,
this test fails if the underlying file system's timestamp granularity doesn't
al
On Mon, 25 Aug 2025 13:19:29 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change to the
> `ModuleDescriptor.packages()` method's specification?
>
> The change here clarifies that this method returns all packages that belong
> to the module and not
On Tue, 26 Aug 2025 05:37:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change to the
>> `ModuleDescriptor.packages()` method's specification?
>>
>> The change here clarifies that this method returns all packages that belong
>> to
On Tue, 26 Aug 2025 11:22:57 GMT, Per Minborg wrote:
>> ### Description
>> This PR proposes to update the `ClassLoader` implementation to properly
>> guard access to the provided `ByteBuffer` when defining a class using
>> `defineClass(String, ByteBuffer, ...)`. Specifically, calls to
>> `Shar
On Mon, 25 Aug 2025 13:34:51 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Mon, 25 Aug 2025 13:34:51 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Tue, 26 Aug 2025 05:39:43 GMT, Johny Jose wrote:
> Problem listing the test case till the fix for JDK-8365398 approved and
> integrated
This looks OK to me.
-
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26937#pullrequestreview-3155175149
On Tue, 26 Aug 2025 05:37:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change to the
>> `ModuleDescriptor.packages()` method's specification?
>>
>> The change here clarifies that this method returns all packages that belong
>> to
On Tue, 26 Aug 2025 05:37:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change to the
>> `ModuleDescriptor.packages()` method's specification?
>>
>> The change here clarifies that this method returns all packages that belong
>> to
On Tue, 26 Aug 2025 05:18:00 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Chen's and Alan's review
>
> src/java.base/share/classes/java/lang/module/Mod
will require a CSR, which I'll create shortly.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Alan's review
-
Changes:
- all: https://git.openjdk.org/jdk/pull/26928/files
- new: https://git.openjdk.org/j
will require a CSR, which I'll create shortly.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Chen's and Alan's review
-
Changes:
- all: https://git.openjdk.org/jdk/pull/26928/files
- new: https://git
On Mon, 25 Aug 2025 16:50:18 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Chen's and Alan's review
>
> src/java.base/share/classes/java/lang/module/Mod
Can I please get a review of this trivial change to the
`ModuleDescriptor.packages()` method's specification?
The change here clarifies that this method returns all packages that belong to
the module and not just those that are exported or open. This clarification
should help avoid any confusio
On Sun, 24 Aug 2025 07:59:05 GMT, Alan Bateman wrote:
> Under load conditions, testVirtualThreadStartAndEnd can fail because the JFR
> recording doesn't have a VirtualThreadEndEvent recorded for all virtual
> threads. This is a test issue. ExecutorService::close waits for all tasks
> (not thre
On Fri, 22 Aug 2025 14:11:18 GMT, Jaikiran Pai wrote:
> I will build this PR locally and give it a try soon to make sure the crash
> no longer reproduces.
I tested this change locally with the reproducer and with `libgmalloc`. The
crash no longer happens.
-
PR Review C
On Mon, 11 Aug 2025 12:35:07 GMT, Per Minborg wrote:
>> ### Description
>> This PR proposes to update the `ClassLoader` implementation to properly
>> guard access to the provided `ByteBuffer` when defining a class using
>> `defineClass(String, ByteBuffer, ...)`. Specifically, calls to
>> `Shar
On Mon, 11 Aug 2025 11:33:19 GMT, Per Minborg wrote:
> ### Description
> This PR proposes to update the `ClassLoader` implementation to properly guard
> access to the provided `ByteBuffer` when defining a class using
> `defineClass(String, ByteBuffer, ...)`. Specifically, calls to
> `SharedSec
On Thu, 26 Jun 2025 18:06:03 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java
On Tue, 19 Aug 2025 07:51:29 GMT, Matthias Baesken wrote:
> The jtreg test tools/jar/JarNoFileArgOperations.java seems to create files
> like /tmp/tmpJar12065714313154611400.jar in the file system and keeps them
> there after the test finishes (also in case of SUCCESS) .
> This has been observe
On Mon, 18 Aug 2025 06:45:27 GMT, Jaikiran Pai wrote:
> > In addition, `PreviewFeature.Feature` enum has a few obsolete entries ...
> > Now the boot JDK is min 24, and a few of the features are already permanent
> > in 24.
>
> I'll file a separate issue to cl
On Thu, 14 Aug 2025 10:34:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of these change which removes the outdated use of
> `jdk.internal.javac.ParticipatesInPreview` and the qualified export of
> `jdk.internal.javac` package? This addresses
> https://bugs.openjdk.or
On Mon, 18 Aug 2025 04:49:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of these change which removes the outdated use of
>> `jdk.internal.javac.ParticipatesInPreview` and the qualified export of
>> `jdk.internal.javac` package? This addresses
>> https://bug
he `jdk.internal.javac` package to these modules.
>
> tier1, tier2 and tier3 testing of this change completed without any related
> failures.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- m
On Thu, 14 Aug 2025 10:34:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of these change which removes the outdated use of
> `jdk.internal.javac.ParticipatesInPreview` and the qualified export of
> `jdk.internal.javac` package? This addresses
> https://bugs.openjdk.or
On Thu, 3 Jul 2025 08:47:20 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version.
Can I please get a review of these change which removes the outdated use of
`jdk.internal.javac.ParticipatesInPreview` and the qualified export of
`jdk.internal.javac` package? This addresses
https://bugs.openjdk.org/browse/JDK-8365533.
These qualified exports in `java.base` were added in
http
On Wed, 13 Aug 2025 18:47:37 GMT, Phil Race wrote:
> Now that Scoped Values is no longer preview, the desktop module does not need
> the entry in the base module-info.java
Marked as reviewed by jpai (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26765#pullrequestreview-
On Fri, 27 Jun 2025 13:20:35 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc-only change which proposes to clarify
> the current implementation of the `java.util.Properties.list(...)` methods?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8360575,
On Mon, 30 Jun 2025 06:01:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to clarify
>> the current implementation of the `java.util.Properties.list(...)` methods?
>>
>> As noted in https://bugs.openjdk.org/browse/
On Mon, 11 Aug 2025 17:30:08 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Mon, 11 Aug 2025 17:30:08 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Wed, 6 Aug 2025 20:25:38 GMT, David Beaumont wrote:
>>> "is completed" is a non-directory type, "getLocation() failing" is a
>>> non-resource type.
>>
>> If getLocation() by default throws a `IllegalStateException` stating that
>> the `Node` is not a resource type, then I think it would be
1 - 100 of 1702 matches
Mail list logo
