On Fri, 29 Jul 2022 18:02:46 GMT, Harold Seigel wrote:
> Please review this change to fix JDK-8291360. This fix adds entry points
> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
> The new entry points return the current class's class file version
On Thu, 4 Aug 2022 12:51:33 GMT, Harold Seigel wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's cla
On Thu, 4 Aug 2022 12:28:51 GMT, David Holmes wrote:
>> I think it seems more natural to display the major version first, but I can
>> change it if you prefer.
>
> I think it should match the underlying representation else it may cause
> someone trying to debug a failure to look at the wrong pa
tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows,
> and Mach5 tiers 1-3 on Linux x64. Additionally, the JCK lang, vm, and api
> tests and new regression tests were run locally on Linux x64.
>
> Thanks, Harold
Harold Seigel has updated the pull request incrementally wi
On Tue, 2 Aug 2022 06:36:54 GMT, David Holmes wrote:
>> No particular reason for choosing 59 other than it's different and less than
>> 64. Test case Version64_65535 has a non-zero minor version.
>
> I think we should be testing for other real classfile versions that may be
> encountered, such
On Tue, 2 Aug 2022 06:24:10 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improved tests, added mulit-dimensional array tests, simplified new
>> java.lang.Class
tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows,
> and Mach5 tiers 1-3 on Linux x64. Additionally, the JCK lang, vm, and api
> tests and new regression tests were run locally on Linux x64.
>
> Thanks, Harold
Harold Seigel has updated the pull request incrementally wi
On Tue, 2 Aug 2022 06:51:46 GMT, David Holmes wrote:
>> Changed to display as major:minor version.
>
> Seems odd to display as major:minor when it is stored as minor:major
I think it seems more natural to display the major version first, but I can
change it if you prefer.
-
PR: ht
On Fri, 29 Jul 2022 21:08:43 GMT, Roger Riggs wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improved tests, added mulit-dimensional array tests, simplified new
>> java.lang.Clas
On Sun, 31 Jul 2022 22:02:11 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improved tests, added mulit-dimensional array tests, simplified new
>> java.lang.Cla
On Mon, 1 Aug 2022 18:51:10 GMT, Harold Seigel wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's cla
tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows,
> and Mach5 tiers 1-3 on Linux x64. Additionally, the JCK lang, vm, and api
> tests and new regression tests were run locally on Linux x64.
>
> Thanks, Harold
Harold Seigel has updated the pull request incrementally wi
On Mon, 1 Aug 2022 14:04:22 GMT, Roger Riggs wrote:
>> Though in this case the Java code has defined behaviour for array types so
>> it is correct for the VM to assume this is not an array type and to assert
>> if it is.
>
> My companion question was whether the native code can for efficiently
On Fri, 29 Jul 2022 21:21:43 GMT, Roger Riggs wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's class file version and its
>> ra
On Sun, 31 Jul 2022 22:22:24 GMT, David Holmes wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's class file version and its
>> r
On Sun, 31 Jul 2022 22:05:15 GMT, David Holmes wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's class file version and its
>> r
On Fri, 29 Jul 2022 18:12:22 GMT, Joe Darcy wrote:
>> Please review this change to fix JDK-8291360. This fix adds entry points
>> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
>> The new entry points return the current class's class file version and its
>> raw
Please review this change to fix JDK-8291360. This fix adds entry points
getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class.
The new entry points return the current class's class file version and its raw
access flags.
The fix was tested by running Mach5 tiers 1-2 on L
On Thu, 30 Jun 2022 18:39:58 GMT, Harold Seigel wrote:
> Please review this small fix to change range constrained JVM runtime options
> from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux,
> Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>
>
On Fri, 1 Jul 2022 12:28:35 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix copyright date
>
> src/hotspot/share/runtime/perfMemory.cpp line 2:
>
>>
On Thu, 30 Jun 2022 18:39:58 GMT, Harold Seigel wrote:
> Please review this small fix to change range constrained JVM runtime options
> from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux,
> Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>
>
> Please review this small fix to change range constrained JVM runtime options
> from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux,
> Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
Harold Seigel has updated the pull reques
Please review this small fix to change range constrained JVM runtime options
from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux,
Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
Thanks, Harold
-
Commit messages:
- 8289534: Change 'uncomplicated' hots
23 matches
Mail list logo
