Re: RFR: 8337217: Port VirtualMemoryTracker to use VMATree

2024-11-08 Thread Gerard Ziemski
On Wed, 14 Aug 2024 19:11:58 GMT, Gerard Ziemski wrote: >> - `VMATree` is used instead of `SortedLinkList` in new class >> `VirtualMemoryTrackerWithTree`. >> - A wrapper/helper `RegionTree` is made around VMATree to make some calls >> easier. >> - Both old

Re: RFR: 8337217: Port VirtualMemoryTracker to use VMATree

2024-11-08 Thread Gerard Ziemski
On Wed, 14 Aug 2024 19:13:49 GMT, Gerard Ziemski wrote: >> src/hotspot/share/nmt/memReporter.cpp line 467: >> >>> 465: >>> 466: if (reserved_and_committed) >>> 467: return; >> >> This looks better, but now that I got more c

Re: RFR: 8337217: Port VirtualMemoryTracker to use VMATree

2024-11-08 Thread Gerard Ziemski
On Fri, 27 Sep 2024 16:05:33 GMT, Afshin Zafari wrote: > > Rather than having 2 implementations, I'd like to see us aiming for > > integration for JDK-25 after forking 24, so integration in December. That > > would give us 6 months of ensuring stability of the new implementation > > before it

Re: RFR: 8337217: Port VirtualMemoryTracker to use VMATree

2024-11-08 Thread Gerard Ziemski
On Mon, 26 Aug 2024 11:03:25 GMT, Johan Sjölen wrote: > It's tedious to have to write return true; if you never return false; in the > function. I looked into fixing this with some metaprogramming, and I found > two C++14 solutions and one C++17 one. Here's the Godbolt I'd like the lambdas wit

Re: RFR: 8337217: Port VirtualMemoryTracker to use VMATree

2024-11-08 Thread Gerard Ziemski
On Mon, 26 Aug 2024 07:16:39 GMT, Afshin Zafari wrote: > > Is the plan to check-in the fix with both paths? Or are we going to remove > > the linked-list based one after the review? > > The plan is to have both versions available at run-time. In this plan, we > will add JVM options to let the

Re: RFR: 8337217: Port VirtualMemoryTracker to use VMATree

2024-11-08 Thread Gerard Ziemski
On Thu, 1 Aug 2024 15:44:32 GMT, Afshin Zafari wrote: > - `VMATree` is used instead of `SortedLinkList` in new class > `VirtualMemoryTrackerWithTree`. > - A wrapper/helper `RegionTree` is made around VMATree to make some calls > easier. > - Both old and new versions exist in the code and ca

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-09-25 Thread Gerard Ziemski
On Tue, 5 Sep 2023 07:53:36 GMT, Afshin Zafari wrote: > A new benchmark for measuring the NMT overhead in `summary` and `detail` > modes. > The tests are run using: > > make CONF=debug test TEST="micro:java.util.NMTBenchmark" > MICRO="RESULTS_FORMAT=json" > > The results are written to a JS

Re: Proposal: track zlib native memory usage with NMTThomas Stüfe thomas.stuefe at gmail.com

2023-03-22 Thread Gerard Ziemski
> Hi all, > > I am currently working on https://bugs.openjdk.org/browse/JDK-8296360; I > was preparing the final PR [1], but then Alan did ask me to discuss this on > core-libs first. > > Backstory: > > NMT tracks hotspot native allocations but does not cover the JDK libraries > (small exception