Integrated: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea

2025-03-07 Thread Eric Caspole
On Wed, 5 Mar 2025 15:16:03 GMT, Eric Caspole wrote: > The normal SQE process runs all the repo JMH with -ea to get the last bit of > extra testing. This DremFrem JMH contained some asserts that would always > fire on the correct answer, disturbing this normal SQE process. I removed

Re: RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea [v2]

2025-03-07 Thread Eric Caspole
On Thu, 6 Mar 2025 19:51:46 GMT, Eric Caspole wrote: >> The normal SQE process runs all the repo JMH with -ea to get the last bit of >> extra testing. This DremFrem JMH contained some asserts that would always >> fire on the correct answer, disturbing this normal SQE pr

Re: RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea

2025-03-06 Thread Eric Caspole
On Wed, 5 Mar 2025 16:40:55 GMT, Chen Liang wrote: >> The normal SQE process runs all the repo JMH with -ea to get the last bit of >> extra testing. This DremFrem JMH contained some asserts that would always >> fire on the correct answer, disturbing this normal SQE process. I removed a >> lot

Re: RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea [v2]

2025-03-06 Thread Eric Caspole
make it more of a SQE test > than a benchmark. We would prefer to keep benchmarks as benchmarks as much as > possible and not creep into tests. Eric Caspole has updated the pull request incrementally with one additional commit since the last revision: Fix header and remov

RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea

2025-03-05 Thread Eric Caspole
The normal SQE process runs all the repo JMH with -ea to get the last bit of extra testing. This DremFrem JMH contained some asserts that would always fire on the correct answer, disturbing this normal SQE process. I removed a lot more asserts from this JMH which seemed to make it more of a SQE

Re: RFR: 8342958: Use jvmArgs consistently in microbenchmarks

2024-10-24 Thread Eric Caspole
On Thu, 24 Oct 2024 13:52:57 GMT, Claes Redestad wrote: > Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM > reasonable or necessary flags, but when deploying and running micros we often > want to add or replace flags to tune to the machine, test different GCs, etc. > The i

Re: RFR: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state

2023-10-03 Thread Eric Caspole
On Thu, 10 Aug 2023 15:30:19 GMT, Swati Sharma wrote: > In addition to the issue > [JDK-8311178](https://bugs.openjdk.org/browse/JDK-8311178), logically fixing > the scope from benchmark to thread for below benchmark files having shared > state, also which fixes few of the benchmarks scalabili

Re: RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-05 Thread Eric Caspole
On Sat, 1 Jul 2023 07:53:17 GMT, Swati Sharma wrote: > The below benchmark files have scaling issues due to cache contention and > leads to poor scaling when run on multiple threads. The patch sets the scope > from benchmark level to thread level to fix the issue: > - org/openjdk/bench/java/io/

Integrated: 8307483: New micros for j.u.c.LockSupport

2023-05-17 Thread Eric Caspole
On Thu, 4 May 2023 20:17:11 GMT, Eric Caspole wrote: > These micros were developed while investigating JDK-8305670 by myself and > Sergey Kuksenko. The order of thread creation was important in that bug, so > there are 2 JMH for creating sleepers before and after the worker threads.

Re: RFR: 8307483: New micros for j.u.c.LockSupport [v4]

2023-05-17 Thread Eric Caspole
> These micros were developed while investigating JDK-8305670 by myself and > Sergey Kuksenko. The order of thread creation was important in that bug, so > there are 2 JMH for creating sleepers before and after the worker threads. Eric Caspole has updated the pull request incrementally

Re: RFR: 8307483: New micros for j.u.c.LockSupport [v3]

2023-05-16 Thread Eric Caspole
On Tue, 9 May 2023 19:13:42 GMT, Eric Caspole wrote: >> These micros were developed while investigating JDK-8305670 by myself and >> Sergey Kuksenko. The order of thread creation was important in that bug, so >> there are 2 JMH for creating sleepers before and after

Re: RFR: 8307483: New micros for j.u.c.LockSupport [v3]

2023-05-09 Thread Eric Caspole
> These micros were developed while investigating JDK-8305670 by myself and > Sergey Kuksenko. The order of thread creation was important in that bug, so > there are 2 JMH for creating sleepers before and after the worker threads. Eric Caspole has updated the pull request incrementally

Re: RFR: 8307483: New micros for j.u.c.LockSupport [v2]

2023-05-09 Thread Eric Caspole
> These micros were developed while investigating JDK-8305670 by myself and > Sergey Kuksenko. The order of thread creation was important in that bug, so > there are 2 JMH for creating sleepers before and after the worker threads. Eric Caspole has updated the pull request incrementally

RFR: 8307483: New micros for j.u.c.LockSupport

2023-05-04 Thread Eric Caspole
These micros were developed while investigating JDK-8305670 by myself and Sergey Kuksenko. The order of thread creation was important in that bug, so there are 2 JMH for creating sleepers before and after the worker threads. - Commit messages: - 8307483: New micros for j.u.c.LockSu

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark

2023-02-28 Thread Eric Caspole
On Tue, 28 Feb 2023 15:59:26 GMT, Eirik Bjorsnos wrote: > This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text >

Re: RFR: JDK-8301092 - Add benchmark for CRC32

2023-01-25 Thread Eric Caspole
On Wed, 25 Jan 2023 15:03:05 GMT, Scott Gibbons wrote: > Adding a performance benchmark test for CRC32. This does exactly the same > test as for CRC32C. Looks good to me, thanks! - Marked as reviewed by ecaspole (Committer). PR: https://git.openjdk.org/jdk/pull/12199

Integrated: 8292623: Reduce runtime of java.io microbenchmarks

2022-08-22 Thread Eric Caspole
On Fri, 19 Aug 2022 14:16:32 GMT, Eric Caspole wrote: > These changes reduce the run time from about 3h15m to about 2h5m. This pull request has now been integrated. Changeset: e5619339 Author: Eric Caspole URL: https://git.openjdk.org/jdk/com

RFR: 8292623: Reduce runtime of java.io microbenchmarks

2022-08-19 Thread Eric Caspole
These changes reduce the run time from about 3h15m to about 2h5m. - Commit messages: - 8292623: Reduce runtime of java.io microbenchmarks Changes: https://git.openjdk.org/jdk/pull/9942/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9942&range=00 Issue: https://bugs.openjd

Integrated: 8291828: Reduce runtime of java.util.stream microbenchmarks

2022-08-17 Thread Eric Caspole
On Wed, 3 Aug 2022 16:28:31 GMT, Eric Caspole wrote: > These changes reduce the default run time from about 1 day 22 hours to about > 6 hours with good stability we can use in weekly testing. This pull request has now been integrated. Changeset: 0fc92637 Author: Eric Caspol

Re: RFR: 8291828: Reduce runtime of java.util.stream microbenchmarks [v2]

2022-08-17 Thread Eric Caspole
On Tue, 16 Aug 2022 14:35:14 GMT, Eric Caspole wrote: >> These changes reduce the default run time from about 1 day 22 hours to about >> 6 hours with good stability we can use in weekly testing. > > Eric Caspole has updated the pull request incrementally with one additional

Re: RFR: 8291828: Reduce runtime of java.util.stream microbenchmarks [v2]

2022-08-16 Thread Eric Caspole
On Mon, 15 Aug 2022 14:34:58 GMT, Roger Riggs wrote: >> Eric Caspole has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clean up imports and shorten run time preserving result stability > > test/micro/org/open

Re: RFR: 8291828: Reduce runtime of java.util.stream microbenchmarks [v2]

2022-08-16 Thread Eric Caspole
On Tue, 16 Aug 2022 14:35:14 GMT, Eric Caspole wrote: >> These changes reduce the default run time from about 1 day 22 hours to about >> 6 hours with good stability we can use in weekly testing. > > Eric Caspole has updated the pull request incrementally with one additional

Re: RFR: 8291828: Reduce runtime of java.util.stream microbenchmarks [v2]

2022-08-16 Thread Eric Caspole
> These changes reduce the default run time from about 1 day 22 hours to about > 6 hours with good stability we can use in weekly testing. Eric Caspole has updated the pull request incrementally with one additional commit since the last revision: Clean up imports and shorten ru

Re: RFR: 8291828: Reduce runtime of java.util.stream microbenchmarks

2022-08-15 Thread Eric Caspole
On Mon, 15 Aug 2022 14:32:51 GMT, Roger Riggs wrote: >> These changes reduce the default run time from about 1 day 22 hours to about >> 6 hours with good stability we can use in weekly testing. > > test/micro/org/openjdk/bench/java/util/stream/ops/value/SizedCount.java line > 30: > >> 28: impo

Integrated: 8292196: Reduce runtime of java.util.regex microbenchmarks

2022-08-15 Thread Eric Caspole
On Fri, 12 Aug 2022 18:20:04 GMT, Eric Caspole wrote: > These changes reduce the run time to 45 minutes from about 1h40m with > stability good enough for weekly promo build testing. This pull request has now been integrated. Changeset: b5707b03 Author: Eric Caspole URL:

RFR: 8292196: Reduce runtime of java.util.regex microbenchmarks

2022-08-12 Thread Eric Caspole
These changes reduce the run time to 45 minutes from about 1h40m with stability good enough for weekly promo build testing. - Commit messages: - 8292196: Reduce runtime of java.util.regex microbenchmarks Changes: https://git.openjdk.org/jdk/pull/9861/files Webrev: https://webrevs.

RFR: 8291828: Reduce runtime of java.util.stream microbenchmarks

2022-08-03 Thread Eric Caspole
These changes reduce the default run time from about 1 day 22 hours to about 6 hours with good stability we can use in weekly testing. - Commit messages: - 8291828: Reduce runtime of java.util.stream microbenchmarks Changes: https://git.openjdk.org/jdk/pull/9733/files Webrev: http

Integrated: 8290894: Reduce runtime of vm.lang microbenchmarks

2022-07-26 Thread Eric Caspole
On Fri, 22 Jul 2022 20:48:22 GMT, Eric Caspole wrote: > Adds fork and iterations controls. This reduces the runtime from 4h26m to > about 21m and still seems stable enough for weekly testing. This pull request has now been integrated. Changeset: f0f78a91 Author: Eric Caspol

Re: RFR: 8290894: Reduce runtime of vm.lang microbenchmarks [v2]

2022-07-26 Thread Eric Caspole
On Mon, 25 Jul 2022 21:13:48 GMT, Eric Caspole wrote: >> Adds fork and iterations controls. This reduces the runtime from 4h26m to >> about 21m and still seems stable enough for weekly testing. > > Eric Caspole has updated the pull request with a new target base due to a &

Re: RFR: 8290894: Reduce runtime of vm.lang microbenchmarks [v2]

2022-07-25 Thread Eric Caspole
> Adds fork and iterations controls. This reduces the runtime from 4h26m to > about 21m and still seems stable enough for weekly testing. Eric Caspole has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brou

RFR: 8290894: Reduce runtime of vm.lang microbenchmarks

2022-07-22 Thread Eric Caspole
Adds fork and iterations controls. This reduces the runtime from 4h26m to about 21m and still seems stable enough for weekly testing. - Commit messages: - 8290894: Reduce runtime of vm.lang microbenchmarks Changes: https://git.openjdk.org/jdk/pull/9619/files Webrev: https://webrev

Re: RFR: 8290115: ArrayCopyObject JMH has wrong package

2022-07-21 Thread Eric Caspole
On Tue, 12 Jul 2022 17:04:47 GMT, Eric Caspole wrote: > This JMH was accidentally committed with package vm.compiler but it is in the > path bench/java/lang. I renamed the package so as to more easily run it with > the other ArrayCopy JMH. Thanks Roger! -

Integrated: 8290115: ArrayCopyObject JMH has wrong package

2022-07-21 Thread Eric Caspole
On Tue, 12 Jul 2022 17:04:47 GMT, Eric Caspole wrote: > This JMH was accidentally committed with package vm.compiler but it is in the > path bench/java/lang. I renamed the package so as to more easily run it with > the other ArrayCopy JMH. This pull request has now been integrated.

Integrated: 8290391: Reduce runtime of java.util package microbenchmarks

2022-07-19 Thread Eric Caspole
On Fri, 15 Jul 2022 18:41:09 GMT, Eric Caspole wrote: > Adds Warmup, Measurement and Fork annotations to reduce the run time from 1 > day 16 hours to 8 hours for this set. This pull request has now been integrated. Changeset: 2cb659e7 Author: Eric Caspole URL:

Re: RFR: 8290391: Reduce runtime of java.util package microbenchmarks [v2]

2022-07-18 Thread Eric Caspole
On Mon, 18 Jul 2022 17:11:08 GMT, Eric Caspole wrote: >> Adds Warmup, Measurement and Fork annotations to reduce the run time from 1 >> day 16 hours to 8 hours for this set. > > Eric Caspole has updated the pull request incrementally with one additional > commit si

Re: RFR: 8290391: Reduce runtime of java.util package microbenchmarks [v2]

2022-07-18 Thread Eric Caspole
> Adds Warmup, Measurement and Fork annotations to reduce the run time from 1 > day 16 hours to 8 hours for this set. Eric Caspole has updated the pull request incrementally with one additional commit since the last revision: Apply @cl4es comments - Changes: - all:

RFR: 8290391: Reduce runtime of java.util package microbenchmarks

2022-07-15 Thread Eric Caspole
Adds Warmup, Measurement and Fork annotations to reduce the run time from 1 day 16 hours to 8 hours for this set. - Commit messages: - 8290391: Reduce runtime of java.util package microbenchmarks Changes: https://git.openjdk.org/jdk/pull/9523/files Webrev: https://webrevs.openjdk.

Re: RFR: 8288732: Reduce runtime of java.util.concurrent microbenchmarks

2022-06-29 Thread Eric Caspole
On Mon, 20 Jun 2022 10:47:35 GMT, Claes Redestad wrote: > - Refactor so that various baseline micros are not run repeatedly with > different parameter values that does not affect the baseline > - Tune iteration times, counts, forks.. > > Reduces runtime of java.util.concurrent micros from an es