Re: RFR: 8351593: [JMH] test PhoneCode.Bulk reports NPE exception [v3]

2025-03-24 Thread Derek White
On Mon, 24 Mar 2025 19:34:55 GMT, Vladimir Ivanov wrote: >> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently >> these tests using empty data set that looks bad. > > Vladimir Ivanov has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8351593: [JMH] test PhoneCode.Bulk reports NPE exception [v2]

2025-03-24 Thread Derek White
On Thu, 20 Mar 2025 23:39:24 GMT, Vladimir Ivanov wrote: >> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently >> these tests using empty data set that looks bad. > > Vladimir Ivanov has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8350909: [JMH] test ThreadOnSpinWaitShared failed for 2 threads config

2025-03-07 Thread Derek White
On Fri, 28 Feb 2025 01:20:44 GMT, Vladimir Ivanov wrote: > The scope was updated to support multithread configuration (jmh option '-t > 2') . No other changes needed. Looks good! - Marked as reviewed by drwhite (Committer). PR Review: https://git.openjdk.org/jdk/pull/23834#pullre

Re: RFR: 8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024

2025-02-28 Thread Derek White
On Tue, 25 Feb 2025 19:06:05 GMT, Vladimir Ivanov wrote: > Array initialization by parameter was added. Extra constant was used to align > cycle step with used arrays. Marked as reviewed by drwhite (Committer). - PR Review: https://git.openjdk.org/jdk/pull/23783#pullrequestreview-

Re: RFR: 8350701: [JMH] test foreign.AllocFromSliceTest failed with Exception for size>1024

2025-02-27 Thread Derek White
On Tue, 25 Feb 2025 21:35:22 GMT, Vladimir Ivanov wrote: > The 'size' parameters was used instead of hardcoded constant to improve > support for different sizes. looks good! - PR Comment: https://git.openjdk.org/jdk/pull/23785#issuecomment-2689055310