Re: RFR: 8354897: Support Soft/Weak Reference in AOT cache [v4]

2025-04-25 Thread Dan Heidinga
On Fri, 25 Apr 2025 05:56:15 GMT, Ioi Lam wrote: >> This PR contains 2 parts >> >> - Upstream of Soft/Weak Reference support authored by @macarte from [the >> Leyden >> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5) >> - New C++ class `AOTReferenceObjS

Re: RFR: 8346567: Make Class.getModifiers() non-native

2025-02-03 Thread Dan Heidinga
On Wed, 11 Dec 2024 15:06:54 GMT, Viktor Klang wrote: >> I don't think this needs to be stable - finals in java.lang is trusted by >> the JIT compiler. > > Yeah, I was just thinking whether something set from inside the VM which is > marked @Stable is constant-folded :) @viktorklang-ora `@Stab

Re: RFR: 8346567: Make Class.getModifiers() non-native

2025-02-03 Thread Dan Heidinga
On Mon, 9 Dec 2024 19:26:53 GMT, Coleen Phillimore wrote: > The Class.getModifiers() method is implemented as a native method in > java.lang.Class to access a field that we've calculated when creating the > mirror. The field is final after that point. The VM doesn't need it anymore, > so ther

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v6]

2024-11-04 Thread Dan Heidinga
On Mon, 4 Nov 2024 03:08:02 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/aotClassInitializer.cpp line 348: >> >>> 346: } >>> 347: JavaValue result(T_VOID); >>> 348: JavaCalls::call_static(&result, ik, >> >> Based on the discussions in JDK-8342283, do we need a memory fence after the

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v6]

2024-10-31 Thread Dan Heidinga
On Thu, 31 Oct 2024 02:23:24 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v3]

2024-10-24 Thread Dan Heidinga
On Wed, 23 Oct 2024 04:46:51 GMT, Ioi Lam wrote: >> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://openjdk.org/jeps/483). >> >> >> Note: this is a combined PR of the following individual PRs >> - https://github.com/openjdk/jdk/pull/20516 >> - https

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v4]

2024-10-18 Thread Dan Heidinga
On Fri, 18 Oct 2024 15:33:09 GMT, Chen Liang wrote: >> I looked at the InnerClassLambdaMetaFactory and it only generates >> MHs.Lookup.ClassOption::STRONG classes that live as long as their >> corresponding loaders. Given that, do we want an assert here that we are >> only dealing with strong

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v4]

2024-10-18 Thread Dan Heidinga
On Fri, 18 Oct 2024 04:24:31 GMT, Ioi Lam wrote: >> We only resolve indys for the boot/platform/app class loaders, so there's no >> need to support class unloading. I've added a comment and tightened up the >> code with asserts. See version >> [382446d](https://github.com/openjdk/jdk/pull/2114

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v5]

2024-10-15 Thread Dan Heidinga
On Tue, 15 Oct 2024 05:21:53 GMT, Ioi Lam wrote: >> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> This PR implements the AOT-linking of invokedynamic callsites: >> - We only link lambda expressions (`Lamb

Re: RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v4]

2024-10-15 Thread Dan Heidinga
On Sun, 13 Oct 2024 21:07:51 GMT, Ioi Lam wrote: >> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> This PR implements the AOT-linking of invokedynamic callsites: >> - We only link lambda expressions (`Lamb

Re: RFR: 8330465: Stable Values and Collections (Internal)

2024-05-14 Thread Dan Heidinga
On Tue, 23 Apr 2024 12:22:25 GMT, Per Minborg wrote: >> src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 193: >> >>> 191: * final fields declared in a {@linkplain Class#isHidden() >>> hidden class} >>> 192: * final fields declared in a {@linkplain Class#isRecor

Re: RFR: 8330465: Stable Values and Collections (Internal)

2024-05-14 Thread Dan Heidinga
On Tue, 16 Apr 2024 11:47:23 GMT, Per Minborg wrote: > # Stable Values & Collections (Internal) > > ## Summary > This PR proposes to introduce an internal _Stable Values & Collections_ API, > which provides immutable value holders where elements are initialized _at > most once_. Stable Values

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v5]

2023-08-25 Thread Dan Heidinga
On Thu, 24 Aug 2023 18:44:14 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per fr

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes [v3]

2022-11-18 Thread Dan Heidinga
On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy wrote: >> Update the spec of Class.getModifiers to match long-standing behavior for >> primitive and array classes. Remove unneeded implementation flexibility with >> regard to setting other bit positions. This work was prompted to better >> support

Re: RFR: JDK-8296743: Tighten Class.getModifiers spec for array classes

2022-11-18 Thread Dan Heidinga
On Fri, 18 Nov 2022 03:26:38 GMT, Joe Darcy wrote: > Update the spec of Class.getModifiers to match long-standing behavior for > primitive and array classes. Remove unneeded implementation flexibility with > regard to setting other bit positions. This work was prompted to better > support anti