On Fri, 25 Apr 2025 16:33:59 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/MacPathTest.java line 28:
>>
>>> 26: * @summary Tests paths on macOS
>>> 27: * @requires (os.family == "mac")
>>> 28: */
>>
>> The missing `@t
> Use the `@requires` tag instead of obtaining the operating system name from
> the `os.name` property and then exiting if the test is not run on that
> operating system.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 25 Apr 2025 07:19:32 GMT, Jaikiran Pai wrote:
>> Use the `@requires` tag instead of obtaining the operating system name from
>> the `os.name` property and then exiting if the test is not run on that
>> operating system.
>
> test/jdk/java/io/File/MacPathTest.java line 28:
>
>> 26: * @s
On Fri, 25 Apr 2025 10:18:37 GMT, Mark Sheppard wrote:
> When running test locally that's fine, this is easily seen in the jtreg
> report, but when run in the test frameworks CI pipeline, this "not run "
> visibility is obscured. Thus when doing test run audit of a jobs, requires a
> bit more
On Thu, 24 Apr 2025 17:22:15 GMT, Naoto Sato wrote:
>> Sounds like a different issue needs to be filed.
>
> Yeah, that sounds better.
See https://bugs.openjdk.org/browse/JDK-838
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24838#discussion_r2060508271
Use the `@requires` tag instead of obtaining the operating system name from the
`os.name` property and then exiting if the test is not run on that operating
system.
-
Commit messages:
- 8355444: [java.io] Use @requires tag instead of exiting based on os.name
property value
Change
On Thu, 24 Apr 2025 17:07:15 GMT, Naoto Sato wrote:
>> So do you think that this test should be removed? If so, I think that would
>> be a different PR. Thanks.
>
> IIUC, the test tries to create double byte path directory, so in recent jdk
> it should check `sun.jnu.encoding==MS932` (it still
On Thu, 24 Apr 2025 16:41:27 GMT, Naoto Sato wrote:
>> For tests of the `java.io` package, instead of doing this
>>
>> public static void main(String[] args) throws Exception {
>> if (File.separatorChar != '\') {
>> /* This test is only valid on win32 systems */
>>
For tests of the `java.io` package, instead of doing this
public static void main(String[] args) throws Exception {
if (File.separatorChar != '\') {
/* This test is only valid on win32 systems */
return;
}
do this
@requires (os.family == "windows")
On Wed, 23 Apr 2025 18:06:27 GMT, Johannes Graham wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Improve test per reviewer comments
>
> src/java.base/share/classe
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Fix readAllChars gaffe in Reader returned by Readed.of and account
for it in test
-
Chan
> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for
> file path validity with a sufficient test for file path invalidity. Also, add
> a new test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 23 Apr 2025 18:06:27 GMT, Johannes Graham wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Improve test per reviewer comments
>
> src/java.base/share/classe
On Wed, 23 Apr 2025 16:06:54 GMT, Johannes Döbler wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Add missing toList(), tweak verbiage; update test
>
> test/jdk/java/
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Improve test per reviewer comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24728/fi
On Wed, 23 Apr 2025 15:58:41 GMT, Johannes Döbler wrote:
>>> The test will fail if the default Charset is not UTF-8
>>
>> When does that happen (cf. [JEP 400)](https://openjdk.org/jeps/400)?
>
> The default charset is not UTF-8 when you specify JVM param -Dfile.encoding,
> which of course is un
On Wed, 23 Apr 2025 14:58:16 GMT, Johannes Döbler wrote:
> The test will fail if the default Charset is not UTF-8
When does that happen (cf. [JEP 400)](https://openjdk.org/jeps/400)?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2056340354
On Tue, 22 Apr 2025 17:12:52 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Add missing toList(), t
On Tue, 22 Apr 2025 17:12:52 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Add missing toList(), t
On Tue, 22 Apr 2025 16:53:30 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Reader.java line 426:
>>
>>> 424: */
>>> 425: public List readAllLines() throws IOException {
>>> 426: return readAllChars().lines();
>&g
On Tue, 22 Apr 2025 17:46:04 GMT, Brian Burkhalter wrote:
>> src/java.base/windows/classes/java/io/WinNTFileSystem.java line 376:
>>
>>> 374: return true;
>>> 375: theFile = theFile.getParentFile();
>>> 376: } while
On Tue, 22 Apr 2025 15:56:10 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354450: Account for spaces in directory elements; update test
>
> src/jav
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Add missing toList(), tweak verbiage; update test
-
Changes:
- all: https://git.openjdk.org/
On Tue, 22 Apr 2025 16:48:43 GMT, Alan Bateman wrote:
> I assume you are missing toList() here.
Yes, that was stupid. The `make jdk` caught it but I somehow missed the error
message.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2054494622
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Add Reader.readAllLines; test not yet updated
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Tue, 22 Apr 2025 15:34:43 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Reader.java line 401:
>>
>>> 399: * Reads all remaining characters into a string.
>>> 400: *
>>> 401: * This method reads all conten
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Add some more dangling "remaining"s
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Tue, 22 Apr 2025 10:16:48 GMT, Alan Bateman wrote:
> Again, just to say that it's all remaining rather than "all content" as some
> characters may have been consumed before this method is invoked.
Thanks, that was inadvertently overlooked. See 42e6f3b.
> Now that you have readAllChars, I th
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Add overlooked "remaining"s to Reader.readAllChars
-
Changes:
- all: https://git.op
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Change "lines" to "characters" in spec of Reader.readAllChars, where
appropriate
On Fri, 18 Apr 2025 15:10:02 GMT, Chen Liang wrote:
>> Maybe it can be implemented by referring to `InputStream::readNBytes(int)`
>> (The default implementation of `InputStream::readAllBytes()` is based on it):
>>
>> https://github.com/openjdk/jdk/blob/22e8a97a1ce4e1c781fbc6f1e271c477fe95f069/s
On Mon, 21 Apr 2025 08:17:30 GMT, Andrey Turbanov wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Remove unused import
>
> test/jdk/java/io/BufferedReader/ReadAll.java
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: readString -> readAllChars; update test
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Fri, 18 Apr 2025 19:11:15 GMT, Roger Riggs wrote:
> Without over-rotating on performance concerns, [...]
Or just for the sake of silliness:
public List readAllLines() throws IOException {
String regex = "(?:\n)|(?:\r)|\r(?=\n)";
return Arrays.asList(readString().split(reg
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Remove unused import
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24728/files
- new: ht
On Fri, 18 Apr 2025 19:02:26 GMT, Alan Bateman wrote:
> I don't think a readLine would make sense for Reader
If there were a `readLine` I would expect it not to be exposed in the API.
-
PR Comment: https://git.openjdk.org/jdk/pull/24728#issuecomment-2816085214
> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for
> file path validity with a sufficient test for file path invalidity. Also, add
> a new test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 18 Apr 2025 08:11:28 GMT, Alan Bateman wrote:
>> From experimentation with C++ code is VS, it appears that `CreateDirectoryW`
>> will create a directory with either a leading or trailing space in its name,
>> whereas `createFileW` will create a file with a leading space in its name,
>>
On Fri, 18 Apr 2025 17:35:00 GMT, Stuart Marks wrote:
> There's logic in readLine() that terminates the current line if a CR is
> encountered, and it _also_ sets a `skipLF` flag which skips the LF if it's
> the very next character.
I will also point out here that, based on a somewhat cursory s
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Modify specification verbiage more or less as suggested
-
Changes:
- all: https://git.openjdk.
On Thu, 17 Apr 2025 23:07:35 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8354724: Increment cop
On Fri, 18 Apr 2025 14:46:08 GMT, Alan Bateman wrote:
> I don't think it would be too bad to have Reader define a method to read the
> remaining characters as a sequence of lines.
So you are suggesting moving `readAllLines` up from `BufferedReader` to
`Reader`?
-
PR Comment: http
On Thu, 17 Apr 2025 22:43:59 GMT, Roger Riggs wrote:
> I'm fine with moving `readString` to `Reader`.
Given that
[Reader.read(char[])](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/io/Reader.html#read(char[]))
exists, this should be a trivial change, implementation-wise.
-
On Wed, 16 Apr 2025 17:43:58 GMT, Alan Bateman wrote:
>> I am not sure what you mean here as file paths _can_ contain (s) space(s).
>
> The question is about directories in the path that end with space. So yes,
> the file path may contain spaces but the proposed check is only looking at
> the e
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with two additional
commits since the last revision:
- 8354724: Increment copyright year in Reader
- 8354724: Move readString from BufferedReader to Rea
On Thu, 17 Apr 2025 22:13:06 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Change the test to re
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Change the test to reuse a ByteBuffer when writing the file
-
Changes:
- all: ht
On Thu, 17 Apr 2025 19:08:52 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Address all PR comments to now
>
> src/java.base/share/classes/java/i
On Thu, 17 Apr 2025 17:30:06 GMT, Johannes Graham wrote:
>> test/jdk/java/io/BufferedReader/ReadAll.java line 34:
>>
>>> 32:
>>> 33: import java.io.BufferedReader;
>>> 34: import java.io.File;
>>
>> Cosmetic thought - I think this could all be done with Path, avoiding File
>> and friends.
>
>
On Thu, 17 Apr 2025 17:05:54 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Address all PR comments to now
>
> src/java.base/share/classes/java/i
On Thu, 17 Apr 2025 17:19:03 GMT, Chen Liang wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Address all PR comments to now
>
> src/java.base/share/classes/java/i
On Thu, 17 Apr 2025 16:42:54 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/BufferedReader.java line 459:
>>
>>> 457: * @since 25
>>> 458: */
>>> 459: public String readString() throws IOException {
>>
>&
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Address all PR comments to now
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24728/fi
On Thu, 17 Apr 2025 17:20:57 GMT, Chen Liang wrote:
> Is there a particular reason that these methods should exist only on
> `BufferedReader` but not the base `Reader`?
Good question. Perhaps @RogerRiggs could comment on that.
-
PR Comment: https://git.openjdk.org/jdk/pull/24728#i
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote:
> Implement the requested methods and add a test thereof.
> /csr needed
I was going to do that _after_ consensus had been achieved here. It's extra
work to create a CSR before that point, especially as that point might not
On Thu, 17 Apr 2025 16:36:53 GMT, Hendrik Schick wrote:
>> Implement the requested methods and add a test thereof.
>
> src/java.base/share/classes/java/io/BufferedReader.java line 459:
>
>> 457: * @since 25
>> 458: */
>> 459: public String readString() throws IOException {
>
> Su
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote:
> Implement the requested methods and add a test thereof.
A CSR will be filed if the discussion in this request converges to consensus.
-
PR Comment: https://git.openjdk.org/jdk/pull/24728#issuecomment-2813488383
Implement the requested methods and add a test thereof.
-
Commit messages:
- 8354724: BufferedReader readAllLines and readString methods
Changes: https://git.openjdk.org/jdk/pull/24728/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24728&range=00
Issue: https://bugs.open
On Wed, 16 Apr 2025 09:21:41 GMT, Mikhail Yankelevich
wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354450: Add specific conditional for trailing space; adjust test
&
On Wed, 16 Apr 2025 07:33:54 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354450: Add specific conditional for trailing space; adjust test
>
> src/jav
> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for
> file path validity with a sufficient test for file path invalidity. Also, add
> a new test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 15 Apr 2025 13:03:03 GMT, Alan Bateman wrote:
> I don't think we should couple these two, meaning the ADS configuration
> shouldn't influence whether trailing spaces are allowed. I think we can still
> fat path when the input doesn't contain a space, just might need a slower
> path whe
In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for file
path validity with a sufficient test for file path invalidity. Also, add a new
test.
-
Commit messages:
- 8354450: Using a File with a path containing a trailing space should fail
when alternative data
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase.
John,
You may of course do as you like, but as a matter of personal preference I
usually find it more expedient not to file a CSR until the discussion about
what it will contain has become quiescent in the PR itself.
Cheers,
Brian
On Apr 8, 2025, at 5:51 AM, Engebretson, John wrote:
Are we
I did not notice that Alan’s comment below, about adding a hint as to the
maximum expected size, has been specifically addressed anywhere in this
discussion. It might not be all that pertinent to the main thread of
discussion, however, but it would certainly be useful for the issue [1], which
I
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Wed, 26 Mar 2025 20:57:47 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Wed, 26 Mar 2025 18:57:37 GMT, Naoto Sato wrote:
> Those system property values on Windows were derived from Windows'
> `GetConsoleCP()` call, but they should have been taken from
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
> won't change any behavior, as bot
On Mon, 10 Mar 2025 18:06:43 GMT, Roger Riggs wrote:
> Remove misleading/invalid diagnostic output from the JAR manifest test
> ValueUtf8Coding.java.
>
> The Manifest binary stream is not a well formed UTF-8 string due to the
> inserted continuation characters used for lines longer than 70 cha
On Thu, 5 Dec 2024 18:44:06 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has
On Thu, 19 Dec 2024 00:36:44 GMT, Brian Burkhalter wrote:
> Modify the implementation of `java.io.File` so that it correctly handles the
> empty path `""`.
This pull request has now been integrated.
Changeset: 9477c705
Author:Brian Burkhalter
URL:
https://git
On Fri, 21 Feb 2025 19:00:32 GMT, Brian Burkhalter wrote:
>> Modify the implementation of `java.io.File` so that it correctly handles the
>> empty path `""`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since th
> Modify the implementation of `java.io.File` so that it correctly handles the
> empty path `""`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8024695: Check only that space is positive
-
Changes
On Fri, 21 Feb 2025 17:14:24 GMT, Alan Bateman wrote:
>> I don't recall asserting any relationship between the allocated and free
>> space. Initially I had this simply checking that each returned space value
>> was positive. Do you think that that is enough?
>
> My comment is about the tests ge
On Fri, 21 Feb 2025 07:42:32 GMT, Alan Bateman wrote:
>> So changed in a3b7977.
>
> Thanks, that is better replace for this. In time it may be a good candidate
> to be a stable value.
It was a bad idea in the first place that I put that in `File` itself. I also
thought of this being a stable v
On Fri, 21 Feb 2025 07:41:35 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - 8024695: Move getCWD to holder; remove Order from test
&
On Fri, 21 Feb 2025 11:10:43 GMT, Daniel Fuchs wrote:
> Looks like the [description of the
> PR](https://github.com/openjdk/jdk/pull/22821#issue-2749006501) should be
> updated now
You are correct, thanks: I have updated it. Note that I still need to change
the CSR similarly.
> src/java.base
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase.
On Thu, 20 Feb 2025 07:51:44 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8024695: Extend and clean up test
>
> test/jdk/java/io/File/Empt
On Thu, 20 Feb 2025 16:21:16 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/EmptyPath.java line 67:
>>
>>> 65:
>>> 66: @Test
>>> 67: @Order(1)
>>
>> What is the reason for use `@Order` in these tests, is there a dependency?
On Thu, 20 Feb 2025 17:21:53 GMT, Alan Bateman wrote:
>> Why not just down into `FileSystem`? It's not OS-dependent.
>
> That would be okay too, just need to avoid circular initialization.
So changed in a3b7977.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/22821#discussion
On Thu, 20 Feb 2025 07:54:28 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8024695: Extend and clean up test
>
> src/java.base/share/classes/java/io
On Thu, 20 Feb 2025 07:52:43 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8024695: Extend and clean up test
>
> test/jdk/java/io/File/EmptyPath.java line 6
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since
On Thu, 5 Dec 2024 18:44:06 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has
On Fri, 7 Feb 2025 20:17:47 GMT, Brian Burkhalter wrote:
>> Update the specification of `java.io.File.exists()` to match its behavior,
>> which seems correct in the context of how the empty abstract pathname is
>> documented elsewhere in the class.
>
> Brian Burkhal
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase.
On Fri, 31 Jan 2025 00:19:02 GMT, Brian Burkhalter wrote:
> On Windows, for `File.getFreeSpace` return the same value as returned by
> `File.getUsableSpace`.
This pull request has now been integrated.
Changeset: 1a74ee64
Author: Brian Burkhalter
URL:
https://git.openjdk.o
On Thu, 30 Jan 2025 15:41:41 GMT, Brian Burkhalter wrote:
> The change made for
> [JDK-8003887](https://bugs.openjdk.org/browse/JDK-8003887) updated
> `File.getCanonicalPath` to resolve symbolic links on Windows, but its
> specification was not modified to reflect this. Here it is
On Thu, 6 Feb 2025 16:23:16 GMT, Naoto Sato wrote:
>> On Windows, for `File.getFreeSpace` return the same value as returned by
>> `File.getUsableSpace`.
>
> LGTM
Thanks, @naotoj.
I should note that the test passed on Linux and macOS, and JCK CI tiers 1-3
passed on Windows.
-
PR
On Thu, 6 Feb 2025 16:19:31 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8349006: Fix copyright year gaffe
>
> Marked as reviewed by naoto (Reviewer).
Thank
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since
On Fri, 31 Jan 2025 00:19:38 GMT, Justin Lu wrote:
> New changes and CSR looks good.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/23371#issuecomment-2626013516
On Windows, for `File.getFreeSpace` return the same value as returned by
`File.getUsableSpace`.
-
Commit messages:
- 8349092: File.getFreeSpace violates specification if quotas are in effect
(win)
Changes: https://git.openjdk.org/jdk/pull/23377/files
Webrev: https://webrevs.open
> The change made for
> [JDK-8003887](https://bugs.openjdk.org/browse/JDK-8003887) updated
> `File.getCanonicalPath` to resolve symbolic links on Windows, but its
> specification was not modified to reflect this. Here it is proposed to
> correct that omission.
Brian Burkhalter
On Thu, 30 Jan 2025 18:06:51 GMT, Justin Lu wrote:
> [...], but the copyright year bump looks backwards.
You're correct: that's lame. I didn't search far enough for `4,`. Thanks, will
fix.
-
PR Comment: https://git.openjdk.org/jdk/pull/23371#issuecomment-2625227664
> The change made for
> [JDK-8003887](https://bugs.openjdk.org/browse/JDK-8003887) updated
> `File.getCanonicalPath` to resolve symbolic links on Windows, but its
> specification was not modified to reflect this. Here it is proposed to
> correct that omission.
Brian Burkhalter
The change made for [JDK-8003887](https://bugs.openjdk.org/browse/JDK-8003887)
updated `File.getCanonicalPath` to resolve symbolic links on Windows, but its
specification was not modified to reflect this. Here it is proposed to correct
that omission.
-
Commit messages:
- 8349006:
1 - 100 of 1030 matches
Mail list logo
