Re: RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27

2023-10-19 Thread Ao Qi
On Tue, 17 Oct 2023 07:03:50 GMT, yaqsun wrote: >> `%define _build_id_links none` must be added to a spec file in >> LinuxResourceTest.java file. not on `rpmbuild` command line > >> `%define _build_id_links none` must be added to a spec file in >> LinuxResourceTest.java file. not on `rpmbuild`

Re: RFR: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files [v2]

2023-07-22 Thread Ao Qi
On Mon, 17 Jul 2023 01:08:15 GMT, yaqsun wrote: >> The fix with `%{_builddir}` looks better. Did it resolve the issue? > >> The fix with `%{_builddir}` looks better. Did it resolve the issue? > > Yes, it solved. The root of intermediate files changed to > /tmp/jdk.jpackage16701381473798822/BUIL

Re: RFR: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files [v2]

2023-07-22 Thread Ao Qi
On Fri, 14 Jul 2023 21:58:33 GMT, Alexey Semenyuk wrote: >> yaqsun has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, >> Permission denied for writing /var/tmp/*.files

Integrated: 8310105: LoongArch64 builds are broken after JDK-8304913

2023-06-19 Thread Ao Qi
On Thu, 15 Jun 2023 04:40:59 GMT, Ao Qi wrote: > LoongArch64 Zero builds are broken after > [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913): > > jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum > constant jdk.internal.util.Architecture.L

Re: RFR: 8310105: LoongArch64 builds are broken after JDK-8304913 [v2]

2023-06-19 Thread Ao Qi
s.jlink.plugin.PluginException: ModuleTarget is malformed: No > enum constant jdk.internal.util.Architecture.LOONGARCH64 > > > Builds tested: LoongArch64 Zero, both release and fastdebug. > > If this patch conflicts with #14471, I will rebase after #14471 is integrated. Ao

Re: RFR: 8310105: LoongArch64 builds are broken after JDK-8304913

2023-06-15 Thread Ao Qi
On Thu, 15 Jun 2023 08:12:45 GMT, Aleksey Shipilev wrote: >> LoongArch64 Zero builds are broken after >> [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913): >> >> jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum >> constant jdk.internal.util.Architecture.LOONG

Re: RFR: 8310019: MIPS builds are broken after JDK-8304913 [v3]

2023-06-15 Thread Ao Qi
On Thu, 15 Jun 2023 17:44:01 GMT, Roger Riggs wrote: >> Add mipsel and mips64el to the Architecture enum. >> (Later to be backported to JDK 21) > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Correct mps64el test case Thank

Re: RFR: 8310019: MIPS builds are broken after JDK-8304913 [v2]

2023-06-15 Thread Ao Qi
On Wed, 14 Jun 2023 15:50:19 GMT, Roger Riggs wrote: >> Add mipsel and mips64el to the Architecture enum. >> (Later to be backported to JDK 21) > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Add tests for MIPSEL and MIPS64E

Re: RFR: 8310019: MIPS builds are broken after JDK-8304913 [v2]

2023-06-15 Thread Ao Qi
On Wed, 14 Jun 2023 15:56:49 GMT, Aleksey Shipilev wrote: > Looks fine. We want/need the original reporter to confirm it works now? Native build `linux-mips64el-zero-release` passed after the fix. I'm not the original reporter. - PR Comment: https://git.openjdk.org/jdk/pull/14471#

RFR: 8310105: LoongArch64 builds are broken after JDK-8304913

2023-06-14 Thread Ao Qi
LoongArch64 Zero builds are broken after [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913): jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum constant jdk.internal.util.Architecture.LOONGARCH64 at jdk.jlink/jdk.tools.jlink.builder.DefaultImageBuilder.storeFiles

Integrated: 8292362: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on some platforms

2022-08-17 Thread Ao Qi
On Mon, 15 Aug 2022 12:23:41 GMT, Ao Qi wrote: > For example, java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 > failed on LoongArch64 (probably other platforms unsupported in > src/java.base/share/classes/jdk/internal/foreign/CABI.java might have the >

Re: RFR: 8292362: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on some platforms [v2]

2022-08-16 Thread Ao Qi
On Mon, 15 Aug 2022 14:49:09 GMT, Alan Bateman wrote: >>> > Shouldn't we throw a SkippedException in this case? >>> >>> It's the child VM that skips so throwing SkippedException would require >>> special handling in the parent. >> >> Like this? >> >> diff --git >> a/test/jdk/java/lang/Thread

Re: RFR: 8292362: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on some platforms [v2]

2022-08-15 Thread Ao Qi
On Mon, 15 Aug 2022 13:30:15 GMT, Alan Bateman wrote: > > Shouldn't we throw a SkippedException in this case? > > It's the child VM that skips so throwing SkippedException would require > special handling in the parent. Like this? diff --git a/test/jdk/java/lang/Thread/jni/AttachCurrentThread

Re: RFR: 8292362: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on some platforms

2022-08-15 Thread Ao Qi
On Mon, 15 Aug 2022 12:59:59 GMT, Alan Bateman wrote: > Linker.nativeLinker is currently specified to throw UOE so you might find the > following will avoid ports needing to change the test less often: > > ``` > --- a/test/jdk/java/lang/Thread/jni/AttachCurrentThread/ImplicitAttach.java > +++ b

Re: RFR: 8292362: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on some platforms [v2]

2022-08-15 Thread Ao Qi
a.lang.foreign.Linker.nativeLinker(Linker.java:198) > at ImplicitAttach.main(ImplicitAttach.java:48) Ao Qi has updated the pull request incrementally with one additional commit since the last revision: Test skipped, when no native linker on this platform - Changes: - all: ht

RFR: 8292362: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on some platforms

2022-08-15 Thread Ao Qi
For example, java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on LoongArch64 (probably other platforms unsupported in src/java.base/share/classes/jdk/internal/foreign/CABI.java might have the same issue): Exception in thread "main" java.lang.UnsupportedOperationException: U

Integrated: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations"

2022-08-03 Thread Ao Qi
On Thu, 28 Jul 2022 16:11:12 GMT, Ao Qi wrote: > `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and > `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java` > are added or modified by > [JDK-8284161](https://bugs.openjdk.or

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-02 Thread Ao Qi
On Tue, 2 Aug 2022 17:25:19 GMT, Alan Bateman wrote: > Just an FYI that the [ORDER OF > TAGS](https://openjdk.org/jtreg/tag-spec.html#ORDER) section of the tag > language spec recommends putting the `@requires` before the `@modules` and > `@library` tags. Done. Didn't know that. Thank you for

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v5]

2022-08-02 Thread Ao Qi
f Loom or JVMTI is not supported. > > The issue could be reproduced by zero. Ao Qi has updated the pull request incrementally with one additional commit since the last revision: update tags order - Changes: - all: https://git.openjdk.org/jdk/pull/9677/files - new: https:

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-01 Thread Ao Qi
f Loom or JVMTI is not supported. > > The issue could be reproduced by zero. Ao Qi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional c

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations"

2022-08-01 Thread Ao Qi
On Mon, 1 Aug 2022 15:54:47 GMT, Alan Bateman wrote: > > Since these two kinds (`jvmti` and `XMLDecoder` tests) of the fix are a > > little different, should I split this issue into two? > > I think it would be better to split them. XMLDecoder tests are filed: https://bugs.openjdk.org/browse/J

Re: RFR: 8291508: Fix some tests with "requires vm.continuations" [v3]

2022-08-01 Thread Ao Qi
ressRedefineVirtual.java` > need "requires vm.jvmti". > > The issue could be reproduced by zero. Ao Qi has updated the pull request incrementally with one additional commit since the last revision: XMLDecoder tests are filed in JDK-8291640 - Changes: - all:

Re: RFR: 8291508: Fix some tests with "requires vm.continuations"

2022-08-01 Thread Ao Qi
On Mon, 1 Aug 2022 07:18:52 GMT, Alan Bateman wrote: >> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java`, >> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`, >> `java/beans/XMLDecoder/8028054/TestConstructorFinder.java` and >> `java/b

Re: RFR: 8291508: Fix some tests with "requires vm.continuations" [v2]

2022-08-01 Thread Ao Qi
ressRedefineVirtual.java` > need "requires vm.jvmti". > > The issue could be reproduced by zero. Ao Qi has updated the pull request incrementally with one additional commit since the last revision: XMLDecoder update Co-authored-by: Alan Bateman - Changes