Integrated: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails

2023-04-28 Thread Antonios Printezis
On Thu, 27 Apr 2023 17:57:05 GMT, Antonios Printezis wrote: > Fix is to exclude hsdis when building the buildjdk. This pull request has now been integrated. Changeset: 83a98c66 Author: Antonios Printezis URL: https://git.openjdk.org/jdk/com

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-28 Thread Antonios Printezis
On Thu, 27 Apr 2023 21:31:09 GMT, Erik Joelsson wrote: >> Marked as reviewed by erikj (Reviewer). > >> @erikj79 Thanks! I assume the integrate command will actually squash the >> three commits and rebase them on top of master as one commit? > > Yes, all you need to do is to issue the integrate

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 21:04:42 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated > > Marked as reviewed by erikj (Reviewer). @erikj79 Thanks! I ass

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 20:37:11 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes based on Erik's feedback > > make/autoconf/buildjdk-spec.gmk.in

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v3]

2023-04-27 Thread Antonios Printezis
> Fix is to exclude hsdis when building the buildjdk. Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision: updated - Changes: - all: https://git.openjdk.org/jdk/pull/13697/files - new: https://git.openjdk.org/

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
> Fix is to exclude hsdis when building the buildjdk. Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision: changes based on Erik's feedback - Changes: - all: https://git.openjdk.org/jdk/pull/13697/files

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes based on Erik's feedback > > This looks like it should work, but I

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson wrote: > This looks like it should work, but I would like to avoid sprinkling any more > CREATING_BUILDJDK conditionals throughout the build than absolutely > necessary. I think it would be better to just override `HSDIS_BACKEND` and > `ENABLE_HS

RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails

2023-04-27 Thread Antonios Printezis
Fix is to exclude hsdis when building the buildjdk. - Commit messages: - JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails Changes: https://git.openjdk.org/jdk/pull/13697/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13697&range=00 Issue: ht