On Tue, 15 Apr 2025 23:30:35 GMT, Alex Menkov wrote:
> The change is a preparation step to enable attach streaming output by default.
> The fix updates a number of tests which fail with timeout in tier1..tier7
> when attach streaming output is enabled.
> Details in the first commen
The change is a preparation step to enable attach streaming output by default.
The fix updates a number of tests which fail with timeout in tier1..tier7 when
attach streaming output is enabled.
Details in the first comment.
Testing: tier1..7 with enabled attach streaming output
-
Com
On Fri, 13 Dec 2024 02:21:42 GMT, Alex Menkov wrote:
> In some circumstances ClassFileTransformer.transform can get
> ClassCircularityError or LinkageError concatenating strings (see JDK-8264667,
> JDK-8262002).
> VerifyLocalVariableTableOnRetransformTest fails sometimes on Orac
information for analysis.
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
copyright update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22727/files
- new: https://git.openjdk.org/jdk/pull/22727/files/2cbdc9b9..01
On Fri, 13 Dec 2024 20:49:22 GMT, Chris Plummer wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback
>
> test/jdk/java/lang/instrument/VerifyLocalVariableTableOnRetransformTe
information for analysis.
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22727/files
- new: https://git.openjdk.org/jdk/pull/22727/files/7665ba02..2cbdc9b9
W
In some circumstances ClassFileTransformer.transform can get
ClassCircularityError or LinkageError concatenating strings (see JDK-8264667,
JDK-8262002).
VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI.
The fix adds handling of the errors to get information for analysis.
--
s can just be inlined directly
>> into the code that uses them.
>>
>> Testing:
>> - GHA
>> - Tiers 1-4 sanity
>> -
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote:
> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was
> integrated, the handling of certain symbol lookup code can be simplified. The
> old code needed to support 32-bit Windows, where names had a trailing
> `@`. W
On Fri, 8 Nov 2024 05:29:05 GMT, David Holmes wrote:
> > In the page you mentioned:
>
> @alexmenkov that is for C functions, not C++.
And also for `extern "C"` (AFAIU we export all C++ functions as extern "C")
-
PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-24642
On Fri, 8 Nov 2024 02:13:09 GMT, David Holmes wrote:
> Can someone confirm that use of `__stdcall` has no affect on name
> decorations, as there is no mention here about anything being ignored:
>
> https://learn.microsoft.com/en-us/cpp/build/reference/decorated-names?view=msvc-170
>
> I would
On Wed, 6 Nov 2024 00:58:10 GMT, David Holmes wrote:
> I think you may be throwing the baby out with the bath water when it comes to
> `__stdcall`. It may be that 32-bit requires `__stdcall` but I don't see
> anything that states `__stdcall` is ONLY for 32-bit!
https://learn.microsoft.com/en-u
On Tue, 29 Oct 2024 08:35:27 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Sun, 27 Oct 2024 21:45:08 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Fri, 25 Oct 2024 20:52:29 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Thu, 24 Oct 2024 14:52:27 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Wed, 9 Oct 2024 22:58:33 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - Ma
On Wed, 9 Oct 2024 22:58:33 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - Ma
s.
>
> Testing:
> - tier1,tier2,hs-tier5-svc;
> - redefineClasses/retransformClasses tests:
>- test/jdk/java/lang/instrument
>- test/hotspot/jtreg/serviceability/jvmti/RedefineClasses
>- test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses
>- test/hotspot/
On Sat, 9 Mar 2024 03:29:26 GMT, Guoxiong Li wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> typo
>
> test/jdk/java/lang/instrument/RetransformRecordAnnotation.java line 27:
>
t/hotspot/jtreg/serviceability/jvmti/RedefineClasses
>- test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses
>- test/hotspot/jtreg/vmTestbase/nsk/jvmti/RetransformClasses
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
ty
RecordComponent class has _attributes_count field.
The only user of the field is JvmtiClassFileReconstituter. Incorrect value of
the field causes producing incorrect data for Record attribute.
Parsing Record attribute ClassFileParser skips unknown attributes and may skip
RuntimeInvisibleAnnotatio
The change updates the test to throw an exception if expected
AgentLoadException is not thrown
-
Commit messages:
- fix
Changes: https://git.openjdk.org/jdk/pull/17971/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17971&range=00
Issue: https://bugs.openjdk.org/browse/JD
sage.
> Walking through the code, fixed some other minor things in attach listener
> and attach API implementation (commented in the code)
>
> Testing:
> - test/jdk/com/sun/tools;
> - tier1,tier2,tier5-svc
Alex Menkov has updated the pull request incrementally with one additional
On Wed, 21 Feb 2024 21:16:46 GMT, Alex Menkov wrote:
>> VirtualMachine.loadAgentPath/loadAgentLibrary can fail with
>> AgentLoadException in 2 cases:
>> - attach listener returns error; in the case the exception is thrown from
>> HotSpotVirtualMachine.processCompl
On Wed, 21 Feb 2024 21:13:36 GMT, Alex Menkov wrote:
> VirtualMachine.loadAgentPath/loadAgentLibrary can fail with
> AgentLoadException in 2 cases:
> - attach listener returns error; in the case the exception is thrown from
> HotSpotVirtualMachine.processCompletionStatus
VirtualMachine.loadAgentPath/loadAgentLibrary can fail with AgentLoadException
in 2 cases:
- attach listener returns error; in the case the exception is thrown from
HotSpotVirtualMachine.processCompletionStatus (called from
HotSpotVirtualMachine.execute);
- attach listener returns success, but r
On Fri, 2 Jun 2023 21:30:46 GMT, Chris Plummer wrote:
> Normally when a virtual thread wrapper is used to run a test, the main thread
> is renamed to "old-m-a-i-n" and the new virtual thread that will act as the
> main thread is named "main". Neither is being done by `ProcessTools.main()`.
> T
On Thu, 8 Dec 2022 12:37:17 GMT, Sergey Tsypanov wrote:
> Newer version of IntelliJ IDEA introduces new
> [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases)
> detecting redundant array length check in snippets like
>
Test failure is a duplicate of
[JDK-8284777](https://bugs.openjdk.org/browse/JDK-8284777), but the test needs
to be updated:
- the test instruments all loaded classes, so need to updated ASM version to
support records and permits;
Instrumentor.addNativeMethodTrackingInjection is used only by t
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote:
> It's a bit shorter and clearer.
Marked as reviewed by amenkov (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9816
31 matches
Mail list logo
