On Tue, 22 Apr 2025 23:28:38 GMT, Chen Liang wrote:
> A few pattern matching switches exist in the core parts of ClassFile API
> responsible for transformations and parsing. They are likely to be used in
> early bootstrap, and pattern matching switches require bootstrap methods,
> which depend
On Fri, 14 Mar 2025 18:31:38 GMT, Roger Riggs wrote:
> Cleanup the single use of JavaLangAccess.exit() it is no longer necessary;
> System.exit() can be called directly.
Marked as reviewed by abdelhak-za...@github.com (no known OpenJDK username).
-
PR Review: https://git.openjdk.o
On Fri, 10 Jan 2025 21:23:22 GMT, Alexey Semenyuk wrote:
> Added a test case to JLinkOptionsTest to test that jpackage doesn't bind
> services in app's runtime by default.
>
> The test builds two app images for the same app. One with the default jlink
> options and another with `--bind-service
On Mon, 3 Feb 2025 16:37:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which backs out the commit that was
>> introduced for https://bugs.openjdk.org/browse/JDK-8333893?
>>
>> The comment in the PR review of that issue
>> https://github.com/openjdk/jdk/pull/19626#issu
On Sat, 1 Feb 2025 00:11:31 GMT, Brent Christian wrote:
> 3 finalizers in RMI code can be removed, as they do not perform meaningful
> cleanup.
>
> **`jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext`**
>
> `RegistryContext.finalize()` just calls `close()`. The `close()`
n extraneous whitespace
> - [x] Commit message must refer to an issue
>
>
>
> ### Reviewers without OpenJDK IDs
> * @abdelhak-zaaim (no known openjdk.org user name / role)
>
> ### Reviewing
> Using git
>
> Checkout this PR locally: \
> `$ git fetch https://git.o
On Tue, 26 Nov 2024 22:38:14 GMT, Roger Riggs wrote:
>> The `java.lang.Sytem.security` field no longer exists; remove it from the
>> filterMap.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright
Marked as rev
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote:
>> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
>> #22132.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8344659: System.getPropert
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote:
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> sc
On Tue, 5 Nov 2024 18:29:52 GMT, Chen Liang wrote:
> After the ClassFile API migration, when serializable lambdas are requested
> for hidden class callers, illegal class name is generated for the
> serialization methods, which previously had legal yet unusable class names,
> as hidden classes
On Fri, 11 Oct 2024 05:39:20 GMT, Chen Liang wrote:
> Patch a tableswitch instruction's low value to be greater than a high value,
> previously, javap will not print any previous instruction and report
> problematic address/bci to be 0. This is because the iteration of bound
> models require f
On Fri, 27 Sep 2024 17:05:25 GMT, Shaojin Wen wrote:
> A small optimization to reduce the write operations of trimAndCompress
I think there's no significant performance impact with this change, or it's
negligible, because the condition is replaced by an assignment. While the
condition check wo
On Fri, 27 Sep 2024 17:05:25 GMT, Shaojin Wen wrote:
> A small optimization to reduce the write operations of trimAndCompress
We can improve performance by avoiding repeated array access in the loop.
Instead of accessing types[i] multiple times, we cache it in a local variable.
Here's the opti
On Tue, 24 Sep 2024 14:18:58 GMT, Tobias Hartmann wrote:
> When investigating an intermittent NPE with an Oracle internal test on
> AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by
> `MethodHandles::jump_to_lambda_form` when trying to load the
> `MemberName::method`
On Tue, 3 Sep 2024 07:52:44 GMT, Per Minborg wrote:
> This PR proposes to handle smaller FFM copy operations with Java code rather
> than transitioning to native code. This will improve performance. In this PR,
> copy operations involving zero to 63 bytes will be handled by Java code.
>
> Here
On Thu, 29 Aug 2024 21:46:52 GMT, Chen Liang wrote:
>> `CodeBuilder::loadConstant(Opcode, ConstantDesc)` is error-prone and
>> confusing. Users should almost always use `loadConstant(ConstantDesc)` for
>> optimized instructions, or use specific factories `iconst_0` etc. or
>> `bipush` with arg
On Tue, 27 Aug 2024 10:42:08 GMT, Per Minborg wrote:
> This trivial PR proposes to fix a typo in the `MemorySegment` docs.
Marked as reviewed by abdelhak-za...@github.com (no known OpenJDK username).
-
PR Review: https://git.openjdk.org/jdk/pull/20727#pullrequestreview-2263831754
On Tue, 23 Jul 2024 17:28:02 GMT, Justin Lu wrote:
> As discussed in
> https://github.com/openjdk/jdk/pull/19513#discussion_r1684957942, there is
> code within java.text.NumberFormat (and subclasses) that can use the pattern
> match switch to improve readability.
>
> As this is simply cleanup
18 matches
Mail list logo
