On Tue, 3 Jun 2025 06:35:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8358456?
>
> In Java 24, through https://bugs.openjdk.org/browse/JDK-8341597 we did a
> change which started using the "compr
On Tue, 3 Jun 2025 06:35:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8358456?
>
> In Java 24, through https://bugs.openjdk.org/browse/JDK-8341597 we did a
> change which started using the "compr
On Wed, 4 Jun 2025 06:24:57 GMT, Stuart Marks wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve t
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their behavior.
> * Update to `@implSpec` clauses to reflect t
On Mon, 2 Jun 2025 13:26:36 GMT, Aleksey Shipilev wrote:
>> SonarCloud complains that since
>> [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using
>> `Boolean` boxes in `ReverseOrderListView`. This change `boolean` ->
>> `Boolean` was made in
>> [JDK-8356080](https://bugs.
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote:
>> The documentation suggests that --linux-package-deps is a boolean option,
>> while in fact it is a string option with dependencies separated by comma and
>> space
>>
>> You can tell that this option is supposed to have an argument
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote:
> SonarCloud complains that since
> [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using
> `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> `Boolean`
> was made in [JDK-8356080](https://bugs.openjdk
On Tue, 3 Jun 2025 20:14:13 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/util/SequencedMap.java line 296:
>>
>>> 294: return view().hashCode();
>>> 295: }
>>> 296: public void addFirst(K k) { throw new
>>> UnsupportedOperationException();
On Tue, 20 May 2025 10:54:44 GMT, He-Pin(kerr) wrote:
>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an
>> IllegalArgumentException with an error message `null`, which is not helpful.
>>
>> Modification:
>> Add detail error messages.
>>
>> Result:
>>
On Tue, 20 May 2025 10:54:44 GMT, He-Pin(kerr) wrote:
>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an
>> IllegalArgumentException with an error message `null`, which is not helpful.
>>
>> Modification:
>> Add detail error messages.
>>
>> Result:
>>
On Mon, 2 Jun 2025 18:23:25 GMT, Per Minborg wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> BigInteger::mag remove Stable
>
> A general comment with respect to `@Stable` is that it asserts the
> field/elements wil
On Tue, 3 Jun 2025 16:59:18 GMT, Naoto Sato wrote:
>> Fixing a regression caused by the fix to JDK-8356985. Although the fix in
>> `CharsetTest` was a clean-up and not the gist of the original issue, the
>> change seem to have caused not finding `SkippedException` at runtime in
>> certain case
On Mon, 2 Jun 2025 21:48:04 GMT, Naoto Sato wrote:
> Fixing a regression caused by the fix to JDK-8356985. Although the fix in
> `CharsetTest` was a clean-up and not the gist of the original issue, the
> change seem to have caused not finding `SkippedException` at runtime in
> certain cases. C
On Tue, 3 Jun 2025 16:59:18 GMT, Naoto Sato wrote:
>> Fixing a regression caused by the fix to JDK-8356985. Although the fix in
>> `CharsetTest` was a clean-up and not the gist of the original issue, the
>> change seem to have caused not finding `SkippedException` at runtime in
>> certain case
On Fri, 14 Feb 2025 15:01:35 GMT, Stefan Lobbenmeier wrote:
> The documentation suggests that --linux-package-deps is a boolean option,
> while in fact it is a string option with dependencies separated by comma and
> space
>
> You can tell that this option is supposed to have an argument here:
On Tue, 3 Jun 2025 17:42:37 GMT, Magnus Ihse Bursie wrote:
>> I found a few other places in the code that can be cleaned up after the
>> conversion to UTF-8.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to
> a merge or a rebase. The incremental webrev excludes
On Tue, 3 Jun 2025 07:55:06 GMT, Volkan Yazici wrote:
>> Passes the `Charset` read from the `stdin.encoding` system property while
>> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>>
>> `stdin.encoding` is a recently added property for Java 25 in
>> [JDK-8350703](https:/
On Mon, 2 Jun 2025 20:41:41 GMT, Joe Darcy wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak nsee() declaration; adjust specs per suggestion; update copyrights.
>
> src/java.base/share/classes/java/util/Sequenc
On Mon, 2 Jun 2025 13:26:36 GMT, Aleksey Shipilev wrote:
>> SonarCloud complains that since
>> [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using
>> `Boolean` boxes in `ReverseOrderListView`. This change `boolean` ->
>> `Boolean` was made in
>> [JDK-8356080](https://bugs.
On Tue, 3 Jun 2025 07:55:06 GMT, Volkan Yazici wrote:
>> Passes the `Charset` read from the `stdin.encoding` system property while
>> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>>
>> `stdin.encoding` is a recently added property for Java 25 in
>> [JDK-8350703](https:/
On Tue, 3 Jun 2025 16:35:01 GMT, Weijun Wang wrote:
> I’m just not sure if we’ll end up changing the rule again in the future.
> Hardcoding the system property name makes me a bit uneasy, and the default
> fallback being hardcoded as well adds to that concern.
Thanks so much for the review @wa
On Tue, 3 Jun 2025 18:17:17 GMT, Naoto Sato wrote:
>> Please review this trivial doc correction to
>> `Locale.getISOCountries(Locale.IsoCountryCode type)` which makes it apparent
>> that the returned Set is unmodifiable. Associated CSR filed.
>
> Looks good. Reviewed the CSR too, but not sure i
On Tue, 3 Jun 2025 17:13:45 GMT, Justin Lu wrote:
> Please review this trivial doc correction to
> `Locale.getISOCountries(Locale.IsoCountryCode type)` which makes it apparent
> that the returned Set is unmodifiable. Associated CSR filed.
Looks good. Reviewed the CSR too, but not sure it would
On Tue, 3 Jun 2025 17:52:13 GMT, Justin Lu wrote:
>> Please review this PR which modifies the
>> test/jdk/java/util/TimeZone/Bug8167143.java "testCompat" case to be
>> repurposed to check the implicit locales for the FALLBACK BreakIterator and
>> Collator providers. (FALLBACK is the primary pr
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote:
>> The documentation suggests that --linux-package-deps is a boolean option,
>> while in fact it is a string option with dependencies separated by comma and
>> space
>>
>> You can tell that this option is supposed to have an argument
On Mon, 26 May 2025 08:20:19 GMT, Magnus Ihse Bursie wrote:
>> I found a few other places in the code that can be cleaned up after the
>> conversion to UTF-8.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Restore
On Tue, 3 Jun 2025 17:40:19 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review - var rename
>
> test/jdk/java/util/TimeZone/Bug8167143.java line 239:
>
>> 237: */
>> 238: private static v
> I found a few other places in the code that can be cleaned up after the
> conversion to UTF-8.
Magnus Ihse Bursie has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull requ
On Tue, 3 Jun 2025 17:46:11 GMT, Justin Lu wrote:
>> Please review this PR which modifies the
>> test/jdk/java/util/TimeZone/Bug8167143.java "testCompat" case to be
>> repurposed to check the implicit locales for the FALLBACK BreakIterator and
>> Collator providers. (FALLBACK is the primary pr
> Please review this PR which modifies the
> test/jdk/java/util/TimeZone/Bug8167143.java "testCompat" case to be
> repurposed to check the implicit locales for the FALLBACK BreakIterator and
> Collator providers. (FALLBACK is the primary provider in those cases.) Since
> the method is corrected
On Tue, 3 Jun 2025 16:59:18 GMT, Naoto Sato wrote:
>> Fixing a regression caused by the fix to JDK-8356985. Although the fix in
>> `CharsetTest` was a clean-up and not the gist of the original issue, the
>> change seem to have caused not finding `SkippedException` at runtime in
>> certain case
On Tue, 3 Jun 2025 16:59:18 GMT, Naoto Sato wrote:
>> Fixing a regression caused by the fix to JDK-8356985. Although the fix in
>> `CharsetTest` was a clean-up and not the gist of the original issue, the
>> change seem to have caused not finding `SkippedException` at runtime in
>> certain case
On Tue, 3 Jun 2025 05:48:30 GMT, SendaoYan wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use of OutputAnalyzer.shouldHaveExitValue() where appropriate
>
> test/jdk/java/io/Console/StdoutEncodingTest.java line 41:
>
Please review this trivial doc correction to
`Locale.getISOCountries(Locale.IsoCountryCode type)` which makes it apparent
that the returned Set is unmodifiable. Associated CSR filed.
-
Commit messages:
- init
Changes: https://git.openjdk.org/jdk/pull/25622/files
Webrev: https://
On Tue, 3 Jun 2025 06:13:35 GMT, Johannes Döbler wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use of OutputAnalyzer.shouldHaveExitValue() where appropriate
>
> test/jdk/java/io/Console/StdoutEncodingTest.java line
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote:
>> The documentation suggests that --linux-package-deps is a boolean option,
>> while in fact it is a string option with dependencies separated by comma and
>> space
>>
>> You can tell that this option is supposed to have an argument
On Tue, 3 Jun 2025 06:35:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8358456?
>
> In Java 24, through https://bugs.openjdk.org/browse/JDK-8341597 we did a
> change which started using the "compr
> Fixing a regression caused by the fix to JDK-8356985. Although the fix in
> `CharsetTest` was a clean-up and not the gist of the original issue, the
> change seem to have caused not finding `SkippedException` at runtime in
> certain cases. Changing the test to JUnit based so that the offending
Please review this PR which modifies the
test/jdk/java/util/TimeZone/Bug8167143.java "testCompat" case to be repurposed
to check the implicit locales for the FALLBACK BreakIterator and Collator
providers. (FALLBACK is the primary provider in those cases.) Since the method
is corrected, it can b
On Fri, 30 May 2025 13:59:06 GMT, Volkan Yazici wrote:
> > Have you thought about creating a helper method for this purpose even if
> > it's internal? At least, for the tests you can create one in `/test/lib`.
>
> Required changes are pretty minimal – passing
> `System.getProperty("stdin.encod
On Mon, 14 Apr 2025 20:57:17 GMT, Brian Burkhalter wrote:
> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for
> file path validity with a sufficient test for file path invalidity. Also, add
> a new test.
This pull request has now been integrated.
Changeset: 57862005
Au
On Fri, 30 May 2025 17:02:12 GMT, Justin Lu wrote:
>> Please review this PR which cleans up some i18n tests.
>>
>> There are some i18n related tests that set the locale provider to CLDR (and
>> only CLDR). Since JDK9, this is redundant and equivalent to the default.
>> Thus, occurrences of "-D
On Thu, 29 May 2025 21:59:30 GMT, Justin Lu wrote:
> Please review this PR which cleans up some i18n tests.
>
> There are some i18n related tests that set the locale provider to CLDR (and
> only CLDR). Since JDK9, this is redundant and equivalent to the default.
> Thus, occurrences of "-Djava.
On Tue, 3 Jun 2025 06:35:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8358456?
>
> In Java 24, through https://bugs.openjdk.org/browse/JDK-8341597 we did a
> change which started using the "compr
On Thu, 6 Mar 2025 10:24:13 GMT, Michael McMahon wrote:
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enh
On Tue, 3 Jun 2025 14:23:54 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enabl
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Tue, 3 Jun 2025 12:50:49 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Tue, 3 Jun 2025 08:14:48 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enabl
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request increment
Hello David,
On 03/06/25 5:17 am, David Alayachew wrote:
...
I would much prefer to just use varargs, and list them all up front,
as opposed to having to call resolve over and over.
rootPath.resolve("src", "main", "java");
This is already possible since Java 22
https://docs.oracle.com/en/j
On Tue, 3 Jun 2025 10:09:44 GMT, Nizar Benalla wrote:
> Please review this patch to add a new test to check `@since` tags in the
> `jdk.editpad` module.
>
> TIA
I realize there are no classfiles in `jdk.editpad` but the test can also check
the `@since` information in the `module-info.java` fi
> Get JDK 26 underway.
Nizar Benalla has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 20 commits:
- Merge branch 'master' into jdk.8355746
- Problemlist JavaBaseCheckSince
- Revert "feedback: never bump ASM version"
This reve
On Mon, 2 Jun 2025 14:46:15 GMT, Nizar Benalla wrote:
>> Get JDK 26 underway.
>
> Nizar Benalla has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 18 commits:
>
> - Revert "feedback: never bump ASM version"
>
>This reverts co
Please review this patch to add a new test to check `@since` tags in the
`jdk.editpad` module.
TIA
-
Commit messages:
- add new `@since` test
Changes: https://git.openjdk.org/jdk/pull/25613/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25613&range=00
Issue: https://bu
On Tue, 3 Jun 2025 06:35:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8358456?
>
> In Java 24, through https://bugs.openjdk.org/browse/JDK-8341597 we did a
> change which started using the "compr
On Tue, 3 Jun 2025 06:35:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8358456?
>
> In Java 24, through https://bugs.openjdk.org/browse/JDK-8341597 we did a
> change which started using the "compr
The general feedback received thus far has been primarily positive. There have
been a few behavior-related enhancements over the previews to better handle
interruption (there's still room to improve there, as per our concurrent
conversation) as well as some improvements to work-in-progress track
On Fri, 30 May 2025 11:57:39 GMT, Volkan Yazici wrote:
> Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197)
> (which implements JavaDoc improvement and precautionary naming for certain
> unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are
> found to
On Thu, 22 May 2025 02:09:08 GMT, He-Pin(kerr) wrote:
>> @He-Pin Just pinging you here, in case the notification from my most recent
>> comments got lost in transit.
>
> @viktorklang-ora @liach, I think we need a contribution guide that explains
> how to set up the work in the IDE, how to perfo
On Mon, 2 Jun 2025 13:26:36 GMT, Aleksey Shipilev wrote:
>> SonarCloud complains that since
>> [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using
>> `Boolean` boxes in `ReverseOrderListView`. This change `boolean` ->
>> `Boolean` was made in
>> [JDK-8356080](https://bugs.
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
> Passes the `Charset` read from the `stdin.encoding` system property while
> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>
> `stdin.encoding` is a recently added property for Java 25 in
> [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it
> throug
Heh, I forgot that my Javadoc was set to 21. Thank you for the correction.
On Mon, Jun 2, 2025, 11:58 PM Jaikiran Pai wrote:
> Hello David,
>
> On 03/06/25 5:17 am, David Alayachew wrote:
> > ...
> >
> > I would much prefer to just use varargs, and list them all up front,
> > as opposed to havin
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote:
>> The documentation suggests that --linux-package-deps is a boolean option,
>> while in fact it is a string option with dependencies separated by comma and
>> space
>>
>> You can tell that this option is supposed to have an argument
65 matches
Mail list logo
