Re: RFR: 8355563: VectorAPI: Refactor current implementation of subword gather load API

On Fri, 9 May 2025 07:35:41 GMT, Xiaohong Gong wrote: > JDK-8318650 introduced hotspot intrinsification of subword gather load APIs > for X86 platforms [1]. However, the current implementation is not optimal for > AArch64 SVE platform, which natively supports vector instructions for subword >

Re: RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null

On Fri, 23 May 2025 16:05:08 GMT, Steffen Nießing wrote: > `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the > specified argument is `null`. This PR adds the missing `throws` declaration > for the NPE. The change looks OK to me. Please update the copyright year on the

Re: [External] : Re: mapConcurrent() with InterruptedException

Thanks Viktor! Sorry, I was giving myself more time to read the code, but then I lost track. If I'm reading the code right, the current behavior is that if the current thread is interrupted, the mapConcurrent() would suppress the interruption until all elements are processed? (It will then restor

Add @Stable to BigInteger and BigDecimal

Some static final arrays of BigInteger and BigDecimal are stable and immutable. We should add @Stable to give the optimizer more information - Shaojin Wen

Integrated: 8357685: Change the type of Integer::digits from char[] to byte[]

On Sat, 24 May 2025 02:30:16 GMT, Shaojin Wen wrote: > Integer::digits type can use byte[] instead of char[], which can reduce the > conversion from char to byte in the process of Integer.toString. Using byte[] > can also save memory. This pull request has now been integrated. Changeset: 4a42

Re: Add @Stable to java.lang.CharacterDataLatin1 and other CharacterData classes

On second thought, we should just focus on adding stable and final as you recommend - we should fix stylistic things with no semantic impact later. From: core-libs-dev on behalf of Chen Liang Sent: Saturday, May 24, 2025 6:16 PM To: core-libs-dev ; wenshao Sub

Integrated: 8356629: Incorrect use of {@linkplain} in java.sql

On Sat, 17 May 2025 17:21:01 GMT, Nizar Benalla wrote: > Please review this trivial patch to fix a javadoc bug. > > TIA This pull request has now been integrated. Changeset: b034710b Author:Nizar Benalla URL: https://git.openjdk.org/jdk/commit/b034710b2ae5fbfbe619abba86fef3b5a2d685

Re: RFR: 8356629: Incorrect use of {@linkplain} in java.sql

On Sat, 17 May 2025 17:21:01 GMT, Nizar Benalla wrote: > Please review this trivial patch to fix a javadoc bug. > > TIA Thanks for the review - PR Comment: https://git.openjdk.org/jdk/pull/25286#issuecomment-2907810545

Re: RFR: 8357289: Break down the String constructor into smaller methods [v3]

On Sun, 25 May 2025 06:27:14 GMT, Shaojin Wen wrote: >> src/java.base/share/classes/java/lang/String.java line 703: >> >>> 701: throw new Error(x); >>> 702: } >>> 703: if (COMPACT_STRINGS) { >> >> Now we can call other constructors of String, so instead o

Re: RFR: 8357146: ForkJoinPool:schedule(*) does not throw RejectedExecutionException when pool is shutdown

On Sat, 24 May 2025 15:57:17 GMT, Alan Bateman wrote: >> Method startDelayScheduler should trap the ISE thrown by >> SharedThreadContainer.start and possibly re-try termination before >> eventually throwing RejectedExecutionException. > > src/java.base/share/classes/java/util/concurrent/ForkJoi

Re: RFR: 8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close() [v3]

> Hi, please consider the following patch. > > This patch replaces the existing close-file-descriptors-logic we follow > before exec'ing a target binary: instead of explicitly closing the file > descriptors, we mark them as CLOEXEC. That simplifies the logic: it gets rid > of the awkward tiptoe