Re: Integer::digits should be defined as byte[]

I have one concern with byte conversion - now the arguments to StringUTF16.putChar is sign extended instead of zero extended. We need to ensure sign extension does not affect the intrinsics, maybe need static asserts to ensure all elements of the digit byte arrays are positive so we won't run i

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v12]

On Fri, 23 May 2025 23:25:59 GMT, Xueming Shen wrote: > Looks like I'm late to the party :-) My apologies if this has already been > discussed a long time ago. My question is whether it's really necessary to > restrict the 'read-only' flag to existing ZIP files only. I don't see any > issue wi

RFR: 8357683: (process) SIGQUIT still blocked after JDK-8234262 with jdk.lang.Process.launchMechanism=FORK or VFORK

See bug description. We now unblock all signals in both FORK and POSIX_SPAWN launch modes. This fixes the problem and makes the behavior consistent across these two modes. I left the VFORK mode alone since I believe the signal state is still shared with the parent. One more reason to get rid of

Re: RFR: 8352565: Add native method implementation of Reference.get() [v6]

On Fri, 23 May 2025 23:01:02 GMT, Vladimir Ivanov wrote: >> See review thread slightly above here, specifically >> https://github.com/openjdk/jdk/pull/24315/files#r2094884157. >> I've looked at the intrinsics for Object.clone() and Object.hashCode(), but >> only enough to decide I >> understand

Integer::digits should be defined as byte[]

Now Integer/Long uses Integer::digits to convert to byte, so we should define Integer::digits as byte[], which can avoid the conversion. - Shaojin Wen

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. This change looks reasonabl

RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

When debugging getLong/getDouble/getDecimal of DigitList, the debugger will call the DigitList::toString method. At this time, DigitList::toString will modify tempBuilder, which will cause incorrect results. - Commit messages: - minimal change - remove tempBuilder Changes: https:

Re: DigitList::toString method causing incorrect results during debugging

Thanks for this report. This code is indeed very old - and probably back then, people thought sharing StringBuffer (which has since been migrated to StringBuilder) was a great idea. I checked the use site of the temp buffer - it appears to me that in the lifecycle of a DigitList, that buffer is

Re: RFR: 8354799: ZipInputStream doesn't verify CRC for ZIP entry with empty file data [v3]

On Mon, 12 May 2025 11:27:35 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which addresses the issue noted in >> https://bugs.openjdk.org/browse/JDK-8354799? >> >> `java.util.zip.ZipInputStream` when dealing with a `STORED` entry of zero >> size was missing a CRC check f

DigitList::toString method causing incorrect results during debugging

When debugging getLong/getDouble/getDecimal of java.text.DigitList, the debugger will call the DigitList::toString method. At this time, DigitList::toString will modify tempBuilder, which will cause incorrect results. - Shaojin Wen

RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps

This is first (hotspot) part of the update for `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to include lock information in thread dumps (JDK-8356870). The update has been split into parts to simplify reviewing. The fix contains an implementation of `jdk.internal.vm.ThreadS

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v12]

On Wed, 21 May 2025 23:30:18 GMT, David Beaumont wrote: >> Adding read-only support to ZipFileSystem. >> >> The new `accessMode` environment property allows for readOnly and readWrite >> values, and ensures that the requested mode is consistent with what's >> returned. >> >> This involved a l

Re: RFR: 8352565: Add native method implementation of Reference.get() [v6]

On Tue, 20 May 2025 22:14:42 GMT, Kim Barrett wrote: >> src/java.base/share/classes/java/lang/ref/Reference.java line 366: >> >>> 364: >>> 365: /* Implementation of unintrinsified get(). Making get() native >>> may lead >>> 366: * C2 to sometimes prefer the native implementation over

Integrated: 8357178: Simplify Class::componentType

On Sat, 17 May 2025 02:15:42 GMT, Chen Liang wrote: > `isArray` and null return is now redundant when `componentType` is changed to > an explicit field. This pull request has now been integrated. Changeset: 070c84cd Author:Chen Liang URL: https://git.openjdk.org/jdk/commit/070c84cd

Re: RFR: 8357178: Simplify Class::componentType [v2]

On Mon, 19 May 2025 00:22:08 GMT, Chen Liang wrote: >> `isArray` and null return is now redundant when `componentType` is changed >> to an explicit field. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > For parity with MT.de

Re: RFR: 8356995: Provide default methods min(T, T) and max(T, T) in Comparator interface [v4]

On Fri, 23 May 2025 12:28:36 GMT, Tagir F. Valeev wrote: >> Implementation of Comparator.min and Comparator.max methods. Preliminary >> discussion is in this thread: >> https://mail.openjdk.org/pipermail/core-libs-dev/2025-May/145638.html >> The specification is mostly composed of Math.min/max a

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

On Thu, 22 May 2025 11:52:34 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining bytes. >> >> This h

Re: RFR: 8354450: A File should be invalid if an element of its name sequence ends with a space [v4]

On Wed, 23 Apr 2025 21:50:46 GMT, Brian Burkhalter wrote: >> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for >> file path validity with a sufficient test for file path invalidity. Also, >> add a new test. > > Brian Burkhalter has updated the pull request incrementally

Re: RFR: 8356995: Provide default methods min(T, T) and max(T, T) in Comparator interface [v4]

On Fri, 23 May 2025 12:28:36 GMT, Tagir F. Valeev wrote: >> Implementation of Comparator.min and Comparator.max methods. Preliminary >> discussion is in this thread: >> https://mail.openjdk.org/pipermail/core-libs-dev/2025-May/145638.html >> The specification is mostly composed of Math.min/max a

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

On Wed, 21 May 2025 16:48:44 GMT, Naoto Sato wrote: >> Created jline/jline3#1282. > > Thanks! JLine seems to incorporate the stdin encoding already, which is quick! - PR Review Comment: https://git.openjdk.org/jdk/pull/25271#discussion_r2105219623

Re: RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v26]

> Implement the requested methods and add a test thereof. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8354724: "input reader specific" -> "reader specific" - Changes: - all: https://git.openjdk.org/jdk/pull/247

Integrated: 8357401: BigDecimal: Constants ONE_TENTH and ONE_HALF are unused after JDK-8341402

On Wed, 21 May 2025 00:59:34 GMT, Sergey Bylokhov wrote: > Both fields were added by the > [JDK-4851777](https://bugs.openjdk.org/browse/JDK-4851777): > see > https://github.com/openjdk/jdk/commit/4045a8be07195acac7fb2faef0e6bf90edcaf9f8 > And the usage were deleted by the > [JDK-8341402](http

Integrated: 8357281: sun.util.Locale.LanguageTag should be immutable

On Wed, 21 May 2025 21:19:36 GMT, Justin Lu wrote: > _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data > carrier for Locale. The class, once created is not modified; the class should > be made immutable. Converting the class to a record accomplishes this and > also simplif

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v3]

On Thu, 22 May 2025 17:51:32 GMT, Justin Lu wrote: >> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data >> carrier for Locale. The class, once created is not modified; the class >> should be made immutable. Converting the class to a record accomplishes this >> and also sim

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

On Thu, 22 May 2025 17:46:33 GMT, Naoto Sato wrote: >> `java.io.Console` uses the charset specified by the `stdout.encoding` system >> property for both input and output. While this is generally sufficient, >> since Console is intended for interactive terminal use, some platforms allow >> diff

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

On Thu, 22 May 2025 17:46:33 GMT, Naoto Sato wrote: >> `java.io.Console` uses the charset specified by the `stdout.encoding` system >> property for both input and output. While this is generally sufficient, >> since Console is intended for interactive terminal use, some platforms allow >> diff

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

On Fri, 23 May 2025 17:18:40 GMT, Stuart Marks wrote: > > Can they even possibly do so? > > Sure, as far as I know, IntelliJ IDEA runs on its own version of the JDK, and > it can easily be invoked or modified to allow use of those modules. I took a > quick look at NetBeans and didn't see any r

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

On Fri, 23 May 2025 16:26:36 GMT, Naoto Sato wrote: > Can they even possibly do so? Sure, as far as I know, IntelliJ IDEA runs on its own version of the JDK, and it can easily be invoked or modified to allow use of those modules. I took a quick look at NetBeans and didn't see any references to

Re: [External] : Could someone answer this question about Gatherers?

Sorry, I misremembered. What I was describing was not a bug, but a quirk of streams, where they aggressively pre-fetch on parallel, but not when sequential, causig an OOME on parallel streams. Not that it helps, but here it is in case you want to read it anyways. https://mail.openjdk.org/piperma

Re: RFR: 8357644: Add missing CPE statements

On Fri, 23 May 2025 11:40:24 GMT, Sorna Sarathi N wrote: > Adds missing classpath exception in a couple of files. Thank you for fixing this! My sincere apologies for the trouble. - PR Comment: https://git.openjdk.org/jdk/pull/25413#issuecomment-2905075388

Re: [External] : Could someone answer this question about Gatherers?

Yes, please pull it up. We have a patch ready at https://github.com/openjdk/jdk/pull/25418, and I can test if this patch fixes your said bug. From: core-libs-dev on behalf of David Alayachew Sent: Friday, May 23, 2025 10:28 AM To: Viktor Klang Cc: core-libs-de

Re: RFR: 8357644: Add missing CPE statements

On Fri, 23 May 2025 11:40:24 GMT, Sorna Sarathi N wrote: > Adds missing classpath exception in a couple of files. Marked as reviewed by asemenyuk (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25413#pullrequestreview-2865019628

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

On Fri, 23 May 2025 03:47:32 GMT, Stuart Marks wrote: > But... do the IDEs use this to interface to implement their in-IDE terminal > emulator? Can they even possibly do so? `java.base`'s `module-info` exports `jdk.internal.io` only to `jdk.internal.le` and `jdk.jshell`, so I think no other

Re: RFR: 8357647 : Stream gatherers forward upstream size information to downstream

On Fri, 23 May 2025 16:04:50 GMT, Viktor Klang wrote: >> src/java.base/share/classes/java/util/stream/GathererOp.java line 153: >> >>> 151: if (initializer != Gatherer.defaultInitializer()) // >>> Optimization >>> 152: state = initializer.get(); >>> 153:

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v7]

On Wed, 21 May 2025 21:31:16 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null

On Fri, 23 May 2025 16:05:08 GMT, Steffen Nießing wrote: > `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the > specified argument is `null`. This PR adds the missing `throws` declaration > for the NPE. I have created a CSR for this change. - PR Comment:

RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null

`Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the specified argument is `null`. This PR adds the missing `throws` declaration for the NPE. - Commit messages: - 8357597: Add throws declaration for NPE Changes: https://git.openjdk.org/jdk/pull/25419/files

Re: RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null

On Fri, 23 May 2025 16:05:08 GMT, Steffen Nießing wrote: > `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the > specified argument is `null`. This PR adds the missing `throws` declaration > for the NPE. looks fine, will review the csr when its drafted. -

Re: RFR: 8357647 : Stream gatherers forward upstream size information to downstream

On Fri, 23 May 2025 16:06:08 GMT, Viktor Klang wrote: >> @jdlib I guess that would depend on the definition of *value* and *cost* in >> this context. > > API modifications would definitely be its own thing. @viktorklang-ora, @liach I agree given the artificial starting point of the discussion

Re: RFR: 8357647 : Stream gatherers forward upstream size information to downstream

On Fri, 23 May 2025 15:53:22 GMT, Johannes Döbler wrote: >> While it could be argued that unbounded Spliterators should not report SIZED >> / SUBSIZED, GatherSink should report an unknown emission size, so switching >> to downstream.begin(-1) rather than downstream.begin(size). >> >> Includes

Re: RFR: 8357647 : Stream gatherers forward upstream size information to downstream

On Fri, 23 May 2025 15:15:30 GMT, Viktor Klang wrote: > While it could be argued that unbounded Spliterators should not report SIZED > / SUBSIZED, GatherSink should report an unknown emission size, so switching > to downstream.begin(-1) rather than downstream.begin(size). > > Includes a regres

Re: RFR: 8357178: Simplify Class::componentType [v2]

On Mon, 19 May 2025 00:22:08 GMT, Chen Liang wrote: >> `isArray` and null return is now redundant when `componentType` is changed >> to an explicit field. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > For parity with MT.de

Re: RFR: 8357647 : Stream gatherers forward upstream size information to downstream

On Fri, 23 May 2025 15:53:22 GMT, Johannes Döbler wrote: >> While it could be argued that unbounded Spliterators should not report SIZED >> / SUBSIZED, GatherSink should report an unknown emission size, so switching >> to downstream.begin(-1) rather than downstream.begin(size). >> >> Includes

Re: RFR: 8357081: Removed unused methods of HexDigits [v2]

On Fri, 23 May 2025 02:03:48 GMT, Shaojin Wen wrote: >> In HexDigits, getCharsLatin1 and getCharsUTF16 are no longer used, so remove >> these methods > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > >

Re: RFR: 8357647 : Stream gatherers forward upstream size information to downstream

On Fri, 23 May 2025 15:15:30 GMT, Viktor Klang wrote: > While it could be argued that unbounded Spliterators should not report SIZED > / SUBSIZED, GatherSink should report an unknown emission size, so switching > to downstream.begin(-1) rather than downstream.begin(size). > > Includes a regres

Re: [External] : Could someone answer this question about Gatherers?

Ty vm. You don't think this has anything to do with my bug from 6 months ago, where the parallel stream caused OOME, but the sequential ones short-circuited correctly? I can pull up the thread if you don't recall. On Fri, May 23, 2025, 11:26 AM Viktor Klang wrote: > I've opened a PR to prevent

Re: [External] : Could someone answer this question about Gatherers?

I've opened a PR to prevent this from occurring: https://github.com/openjdk/jdk/pull/25418/files However, there's an argument to be made that an unbounded Spliterator (as obtained by Random::ints(…)) should not report the SIZED and SUBSIZED characteristics, as it is indeed not sized. I'll open

RFR: 8357647 : Stream gatherers forward upstream size information to downstream

While it could be argued that unbounded Spliterators should not report SIZED / SUBSIZED, GatherSink should report an unknown emission size, so switching to downstream.begin(-1) rather than downstream.begin(size). Includes a regression test which yields an OOME if this change is omitted. ---

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v12]

On Wed, 21 May 2025 23:30:18 GMT, David Beaumont wrote: >> Adding read-only support to ZipFileSystem. >> >> The new `accessMode` environment property allows for readOnly and readWrite >> values, and ensures that the requested mode is consistent with what's >> returned. >> >> This involved a l

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v3]

On Fri, 23 May 2025 14:59:07 GMT, Nizar Benalla wrote: >> Please review this patch to fix some `javadoc` bugs in `java.base`. >> Certain `@link` tags used to refer to private fields instead of public APIs. >> >> A couple of `@see` tags in the [serialization >> page](https://download.java.net/ja

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v3]

> Please review this patch to fix some `javadoc` bugs in `java.base`. > Certain `@link` tags used to refer to private fields instead of public APIs. > > A couple of `@see` tags in the [serialization > page](https://download.java.net/java/early_access/jdk25/docs/api/serialized-form.html#java.lang.

Re: RFR: 8357285 : JSR166 Test case testShutdownNow_delayedTasks failed

On Fri, 23 May 2025 03:22:59 GMT, SendaoYan wrote: >> Barring other effects, it is likely that this test just needs to have some >> longer timeouts to ensure that a stall isn't likely to fail the test case. >> The shouldn't have any impact on test execution duration, as the test looks >> at ta

Integrated: 8357285 : JSR166 Test case testShutdownNow_delayedTasks failed

On Thu, 22 May 2025 14:19:09 GMT, Viktor Klang wrote: > Barring other effects, it is likely that this test just needs to have some > longer timeouts to ensure that a stall isn't likely to fail the test case. > The shouldn't have any impact on test execution duration, as the test looks > at tas

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v2]

On Thu, 22 May 2025 15:18:43 GMT, Nizar Benalla wrote: >> Please review this patch to fix some `javadoc` bugs in `java.base`. >> Certain `@link` tags used to refer to private fields instead of public APIs. >> >> A couple of `@see` tags in the [serialization >> page](https://download.java.net/ja

Re: RFR: 8356629: Incorrect use of {@linkplain} in java.sql

On Sat, 17 May 2025 17:21:01 GMT, Nizar Benalla wrote: > Please review this trivial patch to fix a javadoc bug. > > TIA Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25286#pullrequestreview-2864609961

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v12]

On Wed, 21 May 2025 23:30:18 GMT, David Beaumont wrote: >> Adding read-only support to ZipFileSystem. >> >> The new `accessMode` environment property allows for readOnly and readWrite >> values, and ensures that the requested mode is consistent with what's >> returned. >> >> This involved a l

Integrated: 8357171: Test tools/jpackage/windows/WinOSConditionTest.java fails for non administrator

On Thu, 22 May 2025 19:39:04 GMT, Alexey Semenyuk wrote: > - Allow to configure multiple expected installation exit codes for jpackage > native packaging tests. > - Adjusted the test to get skipped if executed in a restricted environment > that doesn't allow per-user installations for non-admi

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

Hi Per, Thanks very much. Looks like there's lots of good info out there but I didn't really know where to start so I appreciate the references. -Archie On Fri, May 23, 2025 at 3:31 AM Per-Ake Minborg wrote: > Hi Archie! > > The C2 compiler can use *automatic vectorization* [1] to speed up su

Re: RFR: 8357171: Test tools/jpackage/windows/WinOSConditionTest.java fails for non administrator

On Thu, 22 May 2025 19:39:04 GMT, Alexey Semenyuk wrote: > - Allow to configure multiple expected installation exit codes for jpackage > native packaging tests. > - Adjusted the test to get skipped if executed in a restricted environment > that doesn't allow per-user installations for non-admi

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v12]

On Fri, 23 May 2025 04:31:39 GMT, Ioi Lam wrote: >> This is the implementation of the draft [JEP: Ahead-of-time Command Line >> Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) >> >> - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT >> cache using the "one-com

Re: [External] : Could someone answer this question about Gatherers?

Hi David, This definitely sounds like a bug, so I've opened: https://bugs.openjdk.org/browse/JDK-8357647 Thanks, √ Viktor Klang Software Architect, Java Platform Group Oracle From: David Alayachew Sent: Friday, 23 May 2025 12:44 To: Viktor Klang ; core-libs-d

Re: RFR: 8356995: Provide default methods min(T, T) and max(T, T) in Comparator interface [v4]

> Implementation of Comparator.min and Comparator.max methods. Preliminary > discussion is in this thread: > https://mail.openjdk.org/pipermail/core-libs-dev/2025-May/145638.html > The specification is mostly composed of Math.min/max and Collections.min/max > specifications. > > The methods are

RFR: 8357644: Add missing CPE statements

Adds missing classpath exception in a couple of files. - Commit messages: - Adding missing CPE Changes: https://git.openjdk.org/jdk/pull/25413/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25413&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8357644 Stats: 6 line

Could someone answer this question about Gatherers?

Hello Core Libs Dev Team, A post came up on StackOverflow recently that asked a question about Gatherers -- https://stackoverflow.com/questions/79622707/why-doesnt-my-gatherer-short-circuit-the-stream-if-the-source-is-an-intstream Just raising it here, as I think the only folks equipped to answer

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v13]

On Tue, 18 Feb 2025 14:33:16 GMT, Aleksey Shipilev wrote: >> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` >> implementation. That implementation carries a doubly-linked list, and so >> makes DBB suffer from the same issue fixed for generic >> `java.lang.ref.Cleaner` users w

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

Hi Archie! The C2 compiler can use automatic vectorization [1] to speed up such operations. You can watch my explanation of the concept in some of my recent presentations, e.g, [2] Best, Per YouTube Share your videos with friends, family, and the world youtu

Re: RFR: 8355022: Implement JEP 506: Scoped Values [v8]

On Thu, 22 May 2025 15:09:12 GMT, Andrew Haley wrote: >> Propose to finalize scoped values. >> The only functional change is that the orElse() method no longer accepts a >> null argument. > > Andrew Haley has updated the pull request with a new target base due to a > merge or a rebase. The pull