On Fri, 2 May 2025 03:49:39 GMT, Shaojin Wen wrote:
>> In BufferedReader.readLine and other similar scenarios, we need to use
>> StringBuilder.append(char[]) to build the string.
>>
>> For these scenarios, we can use the intrinsic method StringUTF16.compress
>> and Unsafe.copyMemory instead of
On Fri, 2 May 2025 03:49:39 GMT, Shaojin Wen wrote:
>> In BufferedReader.readLine and other similar scenarios, we need to use
>> StringBuilder.append(char[]) to build the string.
>>
>> For these scenarios, we can use the intrinsic method StringUTF16.compress
>> and Unsafe.copyMemory instead of
On Fri, 2 May 2025 06:14:19 GMT, Emanuel Peter wrote:
>> erifan has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains six additional commits since
>>
On Mon, 21 Apr 2025 15:19:40 GMT, Chen Liang wrote:
> This might be helpful combined with #21730.
That implies creating a copy of the chars:
private final void appendChars(CharSequence s, int off, int end) {
if (isLatin1()) {
byte[] val = this.value;
// - Begin of Expe
On Thu, 1 May 2025 21:08:29 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Fri, 4 Apr 2025 07:20:23 GMT, Jan Lahoda wrote:
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `jav
On Thu, 1 May 2025 21:08:29 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Thu, 1 May 2025 21:08:29 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Fri, 2 May 2025 05:19:57 GMT, Shaojin Wen wrote:
>> As another step toward the removal of the old generics infrastructure, I
>> propose to remove the usages of generic parsing utilities and use the
>> facilities provided by BytecodeDescriptor, already used by
>> MethodType.fromDescriptorStr
On Thu, 1 May 2025 00:01:08 GMT, Chen Liang wrote:
> As another step toward the removal of the old generics infrastructure, I
> propose to remove the usages of generic parsing utilities and use the
> facilities provided by BytecodeDescriptor, already used by
> MethodType.fromDescriptorString.
On Thu, 1 May 2025 00:01:08 GMT, Chen Liang wrote:
> As another step toward the removal of the old generics infrastructure, I
> propose to remove the usages of generic parsing utilities and use the
> facilities provided by BytecodeDescriptor, already used by
> MethodType.fromDescriptorString.
On Fri, 2 May 2025 04:56:51 GMT, Shaojin Wen wrote:
>> As another step toward the removal of the old generics infrastructure, I
>> propose to remove the usages of generic parsing utilities and use the
>> facilities provided by BytecodeDescriptor, already used by
>> MethodType.fromDescriptorStr
On Thu, 20 Feb 2025 09:30:02 GMT, Andrey Turbanov wrote:
> We have helpful NPE messages now - they are more user-friendly.
> And shorter methods are more likely to be inlined.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/23710
On Thu, 1 May 2025 00:01:08 GMT, Chen Liang wrote:
> As another step toward the removal of the old generics infrastructure, I
> propose to remove the usages of generic parsing utilities and use the
> facilities provided by BytecodeDescriptor, already used by
> MethodType.fromDescriptorString.
> The byte[] allocated in Integer/Long.toString is fully filled, so we can use
> StringConcatHelper::newArray to create byte[] to improve performance.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains eight commits:
- Merg
> This is an optimization for decimal Integer.parseInt and Long.parseLong,
> which improves performance by about 10%. The optimization includes:
> 1. Improve performance by parsing 2 numbers at a time, which has performance
> improvements for numbers with length >= 3.
> 2. It uses charAt(0) for t
> In BufferedReader.readLine and other similar scenarios, we need to use
> StringBuilder.append(char[]) to build the string.
>
> For these scenarios, we can use the intrinsic method StringUTF16.compress and
> Unsafe.copyMemory instead of the character copy of the char-by-char loop to
> improve
On Thu, 7 Sep 2023 19:27:14 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fra
On Thu, 7 Sep 2023 19:27:14 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fra
Please review this PR to problemlist jdk & langtools tier1 tests requiring
runtime usages of /bin/tools, for testing on static-jdk. The affected
tests using following tools at runtime:
- javac
- javadoc
- jar
- jarsigner
- jimage
- jps
-
Commit messages:
- Merge branch 'openjdk:ma
On Mon, 24 Feb 2025 23:47:02 GMT, Chen Liang wrote:
> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
This pull request has now been integrated.
Changeset: bd7c7789
Author:Chen Liang
URL:
https://git.openjdk.org/jdk/commit/bd7c77898a75dece0586bef24d4e18d540f0828
On Thu, 1 May 2025 17:38:42 GMT, Chen Liang wrote:
>> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed bug id
Thanks for the refreshed review!
-
On Thu, 1 May 2025 17:38:42 GMT, Chen Liang wrote:
>> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed bug id
Thank you for the updates. Changes look
On Thu, 1 May 2025 18:43:57 GMT, Chen Liang wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating copyright year.
>
> src/java.base/share/classes/java/lang/IO.java line 157:
>
>> 155: *
>> 156: * Write
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `java. ... .IO` is no longer automatically imported in an
On Fri, 2 May 2025 00:54:24 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>> -
Hi Hempushpa,
You may want to talk to Christoph on JDK-8168664, he might have temped a
fix at the time. Otherwise, feel free to create a new bug and PR, and we
can start from there.
Thanks,
Joe
On 4/23/25 7:03 AM, Hempushpa Sahu wrote:
Problem Description :
XSLT transformation creating
On Thu, 1 May 2025 23:33:00 GMT, Tatsunori Uchino wrote:
>> `InputStreamReader` and `Scanner` taking `stdin.encoding` is an interesting
>> idea, but would introduce compatiblity concerns. It would have been simpler
>> if we had `stdin/out/err.encoding` system properties prior to JEP 400.
>> As
On Thu, 1 May 2025 17:40:56 GMT, Naoto Sato wrote:
>> Hello @tats-u , there is no bother, I appreciate you looking at this.
>>
>> The addition of `stdin.encoding` in
>> [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703) (#24738) happened
>> very quickly. I worked with @naotoj and @Alan
> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
Chen Liang has updated the pull request incrementally with one additional
commit since the last revision:
Missed bug id
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23757/files
- new: https://git.ope
On Thu, 1 May 2025 17:51:53 GMT, Stuart Marks wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Fix readAllChars gaffe in Reader returned by Readed.of and
>> account for it in test
>
> src/java.base/sha
On Thu, 1 May 2025 21:30:30 GMT, Roger Riggs wrote:
>> In Windows CMD, the `echo` command, when called without arguments, displays
>> the current state of the command echoing mode — either enabled (`ON`) or
>> disabled (`OFF`). For the case when this test is run from IntelliJ IDEA.
>>
>> And t
On Thu, 1 May 2025 20:27:01 GMT, Oleksii Sylichenko wrote:
>> test/jdk/java/lang/ProcessBuilder/Basic.java line 1843:
>>
>>> 1841:
>>> //
>>> 1842: try {
>>> 1843: String[] cmdp = Windows.is() ? new Stri
> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
> up the intermittent failures:
>
> * run with `othervm`: this test blocks the (global) finalizer thread, and
> also requires the (global) finalizer thread to enter the test's `finalize()`
> method
> * The test uses `
On Wed, 30 Apr 2025 20:17:57 GMT, Alexander Matveev
wrote:
> - Symbolic links will not be followed for `--app-content` on all platforms.
> - Added test to cover this case.
> - `MacHelper` updated to use "cp -R" instead of "cp -r" when unpacking DMG,
> since "cp -r" on macOS is not documented op
On Thu, 1 May 2025 16:27:17 GMT, Naoto Sato wrote:
>> Similar to #24959, java.util.Locale.hashCode can also make the same
>> improvement.
>>
>> Replace manual bitwise operations in hashCode implementations of
>> java.util.Locale with Double::hashCode.
>
> Thanks for the fix. Even though the fi
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
On Thu, 1 May 2025 19:24:13 GMT, Roger Riggs wrote:
>> This PR proposes three improvements to the `Basic.java` test:
>>
>> 1. Increase Timeout
>>- The current timeout is insufficient when running the test in IntelliJ
>> IDEA.
>>- I propose increasing it by one minute.
>>- The timeou
On Thu, 1 May 2025 17:48:22 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>> -
On Tue, 18 Feb 2025 14:33:16 GMT, Aleksey Shipilev wrote:
>> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner`
>> implementation. That implementation carries a doubly-linked list, and so
>> makes DBB suffer from the same issue fixed for generic
>> `java.lang.ref.Cleaner` users w
On Thu, 1 May 2025 17:26:48 GMT, Joe Darcy wrote:
>> Note, the timeout factor also adjusts the jtreg timeout for the entire test.
>> The adjustTimeout() method allows internal test timeouts to scale along with
>> the jtreg timeout.
>
>> Hi Joe, yes `adjustTimeout` will scale based on the jtreg
On Thu, 6 Mar 2025 13:34:07 GMT, Oleksii Sylichenko wrote:
> This PR proposes three improvements to the `Basic.java` test:
>
> 1. Increase Timeout
>- The current timeout is insufficient when running the test in IntelliJ
> IDEA.
>- I propose increasing it by one minute.
>- The timeou
On Mon, 28 Apr 2025 10:34:49 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
>
> Before [JDK-8353786](https://bugs.openjdk.org/browse/JDK-8353786), when a
> released jdk not supportting sleef (for any reason, e.g. low gcc version,
> intrinsic not supported, rvv not supported,
On Tue, 22 Apr 2025 16:51:05 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Add Reader.readAllLines; test not yet updated
>
> src/java.base/share/classes/java/io/Reader.java line 403
On Wed, 30 Apr 2025 20:23:13 GMT, Brent Christian wrote:
> It spins until at least one `MyObject` has entered `finalize()` before
> proceeding to fetch the histogram.
My eyes must be going. Somehow I read that as a `-1`.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24143
On Thu, 1 May 2025 19:17:42 GMT, Kim Barrett wrote:
>> It spins until at least one `MyObject` has entered `finalize()` before
>> proceeding to fetch the histogram.
>
>> It spins until at least one `MyObject` has entered `finalize()` before
>> proceeding to fetch the histogram.
>
> My eyes must
On Thu, 1 May 2025 12:40:02 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8355954: Address comments on naming in the PR
>
> src/java.base/windows/classes/java/io/WinNTFileSystem.java line 45
On Thu, 1 May 2025 17:48:22 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>> -
On Tue, 29 Apr 2025 22:59:29 GMT, Ioi Lam wrote:
> This is a general fix for all the "points to a static field that may hold a
> different value" failures related to `java/lang/invoke/MethodHandleImpl`.
> E.g., [JDK-8354840](https://bugs.openjdk.org/browse/JDK-8354840),
> [JDK-8353330](https:/
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Thu, 1 May 2025 16:55:06 GMT, Stuart Marks wrote:
>> `stdin.encoding` seems to work as intended in Windows for Japanese. (I
>> managed to get the Windows binary of my PR) No need to change. (I wish the
>> constructors of `InputStreamReader` and `Scanner` used `stdin.encoding`
>> instead of
> This change proposes to modify `java.io.File.delete()` so that regular files
> on Windows will not be deleted by default if their read-only attribute is
> set. A boolean-valued system compatibility property
> `jdk.io.File.deleteReadOnly` is defined to reinstate legacy behavior if
> desired.
On Thu, 6 Mar 2025 13:34:07 GMT, Oleksii Sylichenko wrote:
> This PR proposes three improvements to the `Basic.java` test:
>
> 1. Increase Timeout
>- The current timeout is insufficient when running the test in IntelliJ
> IDEA.
>- I propose increasing it by one minute.
>- The timeou
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `java. ... .IO` is no longer automatically imported in an
On Thu, 1 May 2025 16:34:14 GMT, Chen Liang wrote:
>> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review suggestions
Thanks for the reviews. On baselin
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `java. ... .IO` is no longer automatically imported in an
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
Chen Liang has updated the pull request incrementally with one additional
commit since the last revision:
Review suggestions
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23757/files
- new: https://gi
On Wed, 30 Apr 2025 18:01:08 GMT, Shaojin Wen wrote:
> Similar to #24959, java.util.Locale.hashCode can also make the same
> improvement.
>
> Replace manual bitwise operations in hashCode implementations of
> java.util.Locale with Double::hashCode.
Thanks for the fix. Even though the fix is t
On Thu, 24 Apr 2025 16:24:53 GMT, Stuart Marks wrote:
>> Hi Joe, yes `adjustTimeout` will scale based on the jtreg timeout factor. I
>> believe the behaviour is to multiply whatever hardcoded timeout is passed by
>> the timeout factor.
>> On lower tiers, in our CI, I beleive it means the test w
On Thu, 1 May 2025 16:34:14 GMT, Chen Liang wrote:
>> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review suggestions
Changes look good. Thanks!
--
On Thu, 1 May 2025 16:23:13 GMT, Joe Darcy wrote:
>> I can open a bug report, but I think text parity makes no sense: There are
>> lots of other places in OpenJDK where the short form is used already, so
>> there will not be any benefit of text parity with just one other code
>> location, but
On Fri, 11 Apr 2025 23:05:51 GMT, Joe Wang wrote:
> Streamline the extension function control in the XPath API by relying solely
> on
> [XPathFunctionResolver](https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/xpath/XPathFunctionResolver.html),
> which provides a secure and
On Thu, 1 May 2025 10:20:44 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/BufferStack.java line 163:
>>
>>> 161: lock.unlock();
>>> 162: }
>>> 163: Reference.reachabilityFence(arena);
>>
>> I'm not sure t
On Thu, 1 May 2025 16:16:22 GMT, Alan Bateman wrote:
> [...] we will need to find everything that might be accidentally depending on
> the behavior.
So far I found only `SetAccess` but there is more testing to do, as well as
code scanning.
-
PR Comment: https://git.openjdk.org/jd
On Thu, 1 May 2025 09:51:41 GMT, Tatsunori Uchino wrote:
>> Anyway you need to merge master first to test `stdin.encoding`.
>
> `stdin.encoding` seems to work as intended in Windows for Japanese. (I
> managed to get the Windows binary of my PR) No need to change. (I wish the
> constructors of `
On Thu, 1 May 2025 13:03:47 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 488:
>>
>>> 486: /**
>>> 487: * {@inheritDoc CharSequence}
>>> 488: */
>>
>> Suggestion:
>>
>> * {@inheritDoc CharSequence}
>> * @param srcBegin
On Thu, 1 May 2025 15:54:39 GMT, Brian Burkhalter wrote:
> > Will the new property will also change behavior of
> > java.io.File.deleteOnExit()
>
> Yes, as that calls `File.delete`.
Jason's message is a reminder that we will need to find everything that might
be accidentally depending on the
On Thu, 1 May 2025 15:03:02 GMT, Jason Mehrens wrote:
> Will the new property will also change behavior of java.io.File.deleteOnExit()
Yes, as that calls `File.delete`.
> and java.nio.file.StandardOpenOption.DELETE_ON_CLOSE?
No.
-
PR Comment: https://git.openjdk.org/jdk/pull/2497
On Wed, 30 Apr 2025 22:12:20 GMT, Chen Liang wrote:
>> Take the class file version to reject flags not yet defined, redefined, or
>> obsoleted. This is useful for clients like javap to report the correct
>> undefined flags for different class file versions.
>>
>> A preparatory patch for javap
On Wed, 30 Apr 2025 23:38:02 GMT, Brian Burkhalter wrote:
> This change proposes to modify `java.io.File.delete()` so that regular files
> on Windows will not be deleted by default if their read-only attribute is
> set. A boolean-valued system compatibility property
> `jdk.io.File.deleteReadOn
On Fri, 18 Apr 2025 20:33:27 GMT, Chen Liang wrote:
> Take the class file version to reject flags not yet defined, redefined, or
> obsoleted. This is useful for clients like javap to report the correct
> undefined flags for different class file versions.
>
> A preparatory patch for javap to pa
On Thu, 1 May 2025 12:40:41 GMT, Alan Bateman wrote:
> It will need a release note too.
The issue is already so labelled.
-
PR Comment: https://git.openjdk.org/jdk/pull/24977#issuecomment-2845119678
On Wed, 30 Apr 2025 18:01:08 GMT, Shaojin Wen wrote:
> Similar to #24959, java.util.Locale.hashCode can also make the same
> improvement.
>
> Replace manual bitwise operations in hashCode implementations of
> java.util.Locale with Double::hashCode.
This pull request has now been integrated.
On Wed, 30 Apr 2025 23:02:24 GMT, Chen Liang wrote:
>> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
>
> Chen Liang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the
This PR is defining a new internal annotation,
`@jdk.internal.RequiresIdentity`, with target types PARAMETER and
TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation that
an argument to a given method or constructor parameter will be an object with a
unique identity, not a
On Wed, 30 Apr 2025 23:02:24 GMT, Chen Liang wrote:
>> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
>
> Chen Liang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the
On Fri, 18 Apr 2025 00:06:26 GMT, Vicente Romero wrote:
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or cons
On Fri, 18 Apr 2025 02:32:06 GMT, Chen Liang wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or cons
> Finalize the KDF API.
Weijun Wang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains six commits:
- merge
- add a positive debug log and update exception message
- enhancing exception messages and debug outputs
- update @since tags
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
On Thu, 1 May 2025 13:36:13 GMT, Roger Riggs wrote:
> Remove internal ValueBased annotation from the ProcessHandle interface
> declaration.
> The implementation remains value based as described in the javadoc.
> Remove unnecessary "public" keyword in interfaces and cleanup javadoc.
Good cleanu
On Wed, 30 Apr 2025 18:01:08 GMT, Shaojin Wen wrote:
> Similar to #24959, java.util.Locale.hashCode can also make the same
> improvement.
>
> Replace manual bitwise operations in hashCode implementations of
> java.util.Locale with Double::hashCode.
Thanks for this cleanup, indeed equivalent.
On Wed, 30 Apr 2025 18:01:08 GMT, Shaojin Wen wrote:
> Similar to #24959, java.util.Locale.hashCode can also make the same
> improvement.
>
> Replace manual bitwise operations in hashCode implementations of
> java.util.Locale with Double::hashCode.
lgltm
-
Marked as reviewed by
Remove internal ValueBased annotation from the ProcessHandle interface
declaration.
The implementation remains value based as described in the javadoc.
Remove unnecessary "public" keyword in interfaces and cleanup javadoc.
-
Commit messages:
- 8354334: Remove @ValueBased from Proce
On Thu, 1 May 2025 12:56:42 GMT, Chen Liang wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Applied proposal by Daniel: If there's no change to this file the
>> copyright year update could be reverted?
>
> src/java
On Wed, 30 Apr 2025 23:38:02 GMT, Brian Burkhalter wrote:
> This change proposes to modify `java.io.File.delete()` so that regular files
> on Windows will not be deleted by default if their read-only attribute is
> set. A boolean-valued system compatibility property
> `jdk.io.File.deleteReadOn
On Thu, 1 May 2025 05:33:29 GMT, Volkan Yazici wrote:
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 315:
> 313: * WARNING: The caller of
On Thu, 1 May 2025 08:45:06 GMT, Markus KARG wrote:
>> This Pull Request proposes an implementation for
>> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
>> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
>> dstBegin)` to the `CharSequence` in
On Thu, 1 May 2025 01:15:26 GMT, Jaikiran Pai wrote:
> > I think throwing the SkippedException is the right way to go long term but
> > I assume this shows as a reported failure in Mach5 and in the case of
> > assumeTrue it does not result in a failure being reported?
>
> That is correct, use
On Wed, 30 Apr 2025 22:12:20 GMT, Chen Liang wrote:
>> Take the class file version to reject flags not yet defined, redefined, or
>> obsoleted. This is useful for clients like javap to report the correct
>> undefined flags for different class file versions.
>>
>> A preparatory patch for javap
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote:
>> This PR is based on the work of @mernst-github and aims to implement an
>> _internal_ thread-local 'stack' allocator, which works like a dynamically
>> sized arena, but with reset functionality to reset the allocated size back
>> to a cer
On Thu, 1 May 2025 09:22:57 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve on comments
>
> src/java.base/share/classes/jdk/internal/foreign/BufferStack.java line 163:
>
>> 161:
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote:
>> This PR is based on the work of @mernst-github and aims to implement an
>> _internal_ thread-local 'stack' allocator, which works like a dynamically
>> sized arena, but with reset functionality to reset the allocated size back
>> to a cer
Thanks for all these helpful responses. So I guess there's nothing to do here
except we want to integrate the change proposed by Chen to update the
expression to use Long.hashCode.
Cheers,
Steffen
Ursprüngliche Nachricht
Am 30.04.25 23:25 schrieb Roger Riggs :
> Hi Steffen,
>
On Sun, 27 Apr 2025 14:23:50 GMT, Tatsunori Uchino wrote:
>> I misunderstood that I have tested `stdin.encoding`.
>> I cannot confirm that `stdin.encoding` is changed in Windows to proper ones
>> because it has not been included in the latest EA build (20) and I cannot
>> build master for Windo
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote:
>> This PR is based on the work of @mernst-github and aims to implement an
>> _internal_ thread-local 'stack' allocator, which works like a dynamically
>> sized arena, but with reset functionality to reset the allocated size back
>> to a cer
On Thu, 1 May 2025 09:04:00 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve on comments
>
> src/java.base/share/classes/jdk/internal/foreign/BufferStack.java line 81:
>
>> 79:
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote:
>> This PR is based on the work of @mernst-github and aims to implement an
>> _internal_ thread-local 'stack' allocator, which works like a dynamically
>> sized arena, but with reset functionality to reset the allocated size back
>> to a cer
1 - 100 of 111 matches
Mail list logo
