Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v8]

2025-03-30 Thread Per Minborg
On Tue, 25 Mar 2025 23:28:46 GMT, Johannes Graham wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revamp toString() methods > > src/java.base/share/classes/jdk/internal/lang/stable/StableValueFactories.java > line

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v11]

2025-03-30 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove empty instances - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - new: https://git.openj

RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-03-30 Thread tison
Try to add clear type annotations. Please let me know how this patch can be properly reviewed >_< - Commit messages: - chore: AttachCurrentThread 's argument is JavaVMAttachArgs Changes: https://git.openjdk.org/jdk/pull/21658/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr

Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-03-30 Thread David Holmes
Hi, This change was already proposed (by myself): https://bugs.openjdk.org/browse/JDK-8289253 but it cannot be done as it will break source compatibility. We will just have to live with this historical oddity. Cheers, David On 31/03/2025 12:46 pm, tison wrote: On Mon, 31 Mar 2025 02:08:02 G

Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-03-30 Thread tison
On Mon, 31 Mar 2025 02:08:02 GMT, Jaikiran Pai wrote: >> retest? > > Hello @tisonkun, is there an issue created for this? > https://bugs.openjdk.org/browse/JDK-8304674 against which this PR is linked > is for something else. The PR description too isn't clear what this change is > about. @jai

Re: RFR: 8347009: Speed ​​up parseInt and parseLong [v20]

2025-03-30 Thread Shaojin Wen
> This is an optimization for decimal Integer.parseInt and Long.parseLong, > which improves performance by about 10%. The optimization includes: > 1. Improve performance by parsing 2 numbers at a time, which has performance > improvements for numbers with length >= 3. > 2. It uses charAt(0) for t

Re: RFR: 8304674: AttachCurrentThread 's argument is JavaVMAttachArgs

2025-03-30 Thread tison
On Wed, 23 Oct 2024 06:06:43 GMT, tison wrote: > Try to add clear type annotations. > > Please let me know how this patch can be properly reviewed >_< Let me see how to sign an OCA .. Wait a bit :P Wait a bit :P Wait a bit :P retest? - PR Comment: https://git.openjdk.org/jdk/p

Withdrawn: 8258246: sun.net.www.ParseUtil.decode throws java.lang.IllegalArgumentException: Error decoding percent encoded characters

2025-03-30 Thread duke
On Fri, 31 Jan 2025 09:47:35 GMT, Fabian Meumertzheim wrote: > `URLClassPath` called into `ParseUtil.fileToEncodedURL`, which misencoded > characters with a four byte UTF-8 representation. Replacing that function > with `toPath().toUri().toURL()` (and removing it, since its only used once) > r

RFR: 8304674: File java.c compile error with -fsanitize=address -O0

2025-03-30 Thread SendaoYan
Hi all, File src/java.base/share/native/libjli/java.c compile error: control reaches end of non-void function [-Werror=return-type] with gcc options -fsanitize=address -O0. The function int JavaMain(void* _args) in this file will execute return ret in LEAVE() macro, but gcc with -O0 is not smart

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v4]

2025-03-30 Thread Markus KARG
On Sat, 29 Mar 2025 23:53:36 GMT, Chen Liang wrote: >> Markus KARG has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Applied changes requested by Alan: This sentence doesn't make sense, did >> something get deleted? >> - Applied chan

Re: RFR: 8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized

2025-03-30 Thread SendaoYan
On Sat, 29 Mar 2025 01:32:19 GMT, Vladimir Ivanov wrote: >> Hi all, >> >> The return type of function `const __m256i &perm` is `__m256i`, so `const >> __m256i &perm` should be replaced as 'const __m256i perm'. >> >> The function implementation in gcc/clang compiler header: >> >> 1. gcc: lib/g

Integrated: 8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized

2025-03-30 Thread SendaoYan
On Thu, 6 Mar 2025 03:35:20 GMT, SendaoYan wrote: > Hi all, > > The return type of function `const __m256i &perm` is `__m256i`, so `const > __m256i &perm` should be replaced as 'const __m256i perm'. > > The function implementation in gcc/clang compiler header: > > 1. gcc: lib/gcc/x86_64-pc-li

Re: RFR: 8351996: Behavioral updates for ClassValue::remove [v2]

2025-03-30 Thread Chen Liang
On Wed, 19 Mar 2025 21:35:53 GMT, Chen Liang wrote: >> The recent patch #23866 makes calling `ClassValue::remove()` from >> `ClassValue::computeValue()` end up in infinite loops while fixing the stale >> value risk from the method. >> >> The proposed fix is to preserve the stale value risk fix

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v5]

2025-03-30 Thread Markus KARG
> This Pull Request proposes an implementation for > [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new > method `public void getChars(int srcBegin, int srcEnd, char[] dst, int > dstBegin)` to the `CharSequence` interface, providing a **bulk-read** > facility including a

Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v3]

2025-03-30 Thread Cormac Redmond
On Sat, 22 Feb 2025 14:40:39 GMT, Alexey Semenyuk wrote: >> Support the use of a custom msi wrapper executable when building an exe >> installer. >> >> Put `installer.exe` file in the resource directory and jpackage will use it >> instead of the default `msiwrapper.exe` resource for exe instal