Please review following changes, thanks.
- Add `static` to the vm_info for static JDK. The `-version` output now
contains `static` on static JDK, e.g.:
$ static-jdk/bin/java -version
openjdk version "25-internal" 2025-09-16
OpenJDK Runtime Environment (fastdebug build 25-internal-adhoc.jiangliz
On Fri, 21 Mar 2025 20:25:51 GMT, Andrew Dinn wrote:
>>> In all these cases there is a fast path: e.g. when we know we have already
>>> warned for enable native access, or for Unsafe. In the SV API, the fast
>>> path is when we know that the SV is set already. In my experience, the
>>> volatil
On Fri, 26 Jul 2024 14:20:07 GMT, Shaojin Wen wrote:
> 1. Create a tool class jdk.internal.util.DateTimeHelper, move the formatTo
> method of LocalDateTime/LocalDate/LocalTime to it, so that these methods can
> be used across packages within JDK, so that StringBuilder can be shared,
> avoiding
On Sat, 23 Nov 2024 15:47:53 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds a utility API in the test libraries to
> assert whether a file is currently open.
>
> Several OpenJDK tests currently rely on approximations to check this,
> including deletion (fails only on Windows),
On Mon, 3 Feb 2025 22:31:10 GMT, Shaojin Wen wrote:
>> 1. Create a tool class jdk.internal.util.DateTimeHelper, move the formatTo
>> method of LocalDateTime/LocalDate/LocalTime to it, so that these methods can
>> be used across packages within JDK, so that StringBuilder can be shared,
>> avoid
On Thu, 20 Mar 2025 17:28:54 GMT, Severin Gehwolf wrote:
>> After running this patch through our testing I can confirm that it at least
>> solves all existing test issues and does not create regressions.
>>
>> I, however, admit that the added code in JRTArchive.java is quite hacky and
>> is ac
On Fri, 21 Mar 2025 20:17:31 GMT, Naoto Sato wrote:
> Refining regex tests for Grapheme break so that every test case will run even
> with some failing ones.
Marked as reviewed by joehw (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24168#pullrequestreview-2707275607
On Fri, 21 Mar 2025 17:26:08 GMT, Quan Anh Mai wrote:
>>> Hi again Per!
>>>
>>> Here are some brief notes from our face-to-face chat at JavaOne.
>>>
>>> Debuggers want/need a "hook" for tentative evaluation of stables. It is an
>>> error for a debugger to trigger stable value decisions. This a
On Fri, 21 Mar 2025 20:17:31 GMT, Naoto Sato wrote:
> Refining regex tests for Grapheme break so that every test case will run even
> with some failing ones.
Looks good
-
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/24168#pullrequestreview-27
> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
> up the intermittent failures:
>
> * run with `othervm`: this test blocks the (global) finalizer thread, and
> also requires the (global) finalizer thread to enter the test's `finalize()`
> method
> * The test uses `
On Fri, 21 Mar 2025 18:20:29 GMT, Alexey Semenyuk wrote:
>> Automate setting up an environment for mac signing tests: create
>> keychain(s), self-signing certificates, and register them in the system.
>>
>> To set up the environment, run `make test-only
>> TEST=test/jdk/tools/jpackage/macosx/b
> After "JDK-8339480: Build static-jdk image with a statically linked launcher"
> AIX was not able to build the new target. Therefore with "JDK-8345590 AIX
> 'make all' fails after JDK-8339480" the new target was disabled again.
>
> Now with this change we can enable the statically linked launch
Refining regex tests for Grapheme break so that every test case will run even
with some failing ones.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/24168/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24168&range=00
Issue: https://bugs.op
Adding ForceInline to helper methods.
-
Commit messages:
- Adding ForceInline to helper operations
Changes: https://git.openjdk.org/jdk/pull/24165/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24165&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8339543
Stats: 64
On Fri, 21 Mar 2025 17:38:53 GMT, Ian Graves wrote:
> Adding ForceInline to helper methods.
`insert` and `extract` are intrinsics indeed.
Assuming vector API belongs to core-libs.
-
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24165#pullrequ
> The recent patch #23866 makes calling `ClassValue::remove()` from
> `ClassValue::computeValue()` end up in infinite loops while fixing the stale
> value risk from the method.
>
> The proposed fix is to preserve the stale value risk fix, and update the
> remove-from-compute behavior from the o
On Fri, 21 Mar 2025 14:24:19 GMT, Mikhail Yankelevich
wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 'return' not needed in lambda
>
> test/jdk/java/lang/ref/FinalizerHistogramTest.java line 72:
>
>> 70:
On Fri, 21 Mar 2025 14:24:16 GMT, Mikhail Yankelevich
wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> rename counter variables to use 'Count'
>
> test/jdk/java/lang/ref/FinalizerHistogramTest.java line 45:
>
>
> The recent patch #23866 makes calling `ClassValue::remove()` from
> `ClassValue::computeValue()` end up in infinite loops while fixing the stale
> value risk from the method.
>
> The proposed fix is to preserve the stale value risk fix, and update the
> remove-from-compute behavior from the o
On Fri, 21 Mar 2025 15:50:05 GMT, Maurizio Cimadamore
wrote:
> In all these cases there is a fast path: e.g. when we know we have already
> warned for enable native access, or for Unsafe. In the SV API, the fast path
> is when we know that the SV is set already. In my experience, the volatile
> The recent patch #23866 makes calling `ClassValue::remove()` from
> `ClassValue::computeValue()` end up in infinite loops while fixing the stale
> value risk from the method.
>
> The proposed fix is to preserve the stale value risk fix, and update the
> remove-from-compute behavior from the o
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
On Thu, 20 Mar 2025 14:30:58 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
> Provide method overloads to the ClassFile interface of the
> java.lang.classfile API which allow parsing of classes found in byte buffers
> and memory segments, as well as allowing built class files to be output to
> these types.
David M. Lloyd has updated the pull request incrementally with
On Thu, 20 Mar 2025 21:11:41 GMT, Chen Liang wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in byte buffers
>> and memory segments, as well as allowing built class files to be output to
>> these types.
>
> sr
> After "JDK-8339480: Build static-jdk image with a statically linked launcher"
> AIX was not able to build the new target. Therefore with "JDK-8345590 AIX
> 'make all' fails after JDK-8339480" the new target was disabled again.
>
> Now with this change we can enable the statically linked launch
On Sun, 16 Mar 2025 07:51:55 GMT, Alan Bateman wrote:
> I'm surprised to see `@ForceInline` in the offset query functions in
> `Unsafe`. Those are not on any fast path I'm aware of. What use case does
> this annotation address? If none, consider deleting; it will be a future
> maintenance puzz
> Automate setting up an environment for mac signing tests: create keychain(s),
> self-signing certificates, and register them in the system.
>
> To set up the environment, run `make test-only
> TEST=test/jdk/tools/jpackage/macosx/base/SigningBase.java
> JTREG=JAVA_OPTIONS=-Djpackage.test.SignE
On Fri, 21 Mar 2025 11:44:49 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Thu, 20 Mar 2025 22:35:23 GMT, Brent Christian wrote:
> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
> up the intermittent failures:
>
> * run with `othervm`: this test blocks the (global) finalizer thread, and
> also requires the (global) finalizer thread to
On Fri, 21 Mar 2025 10:00:26 GMT, Aleksey Shipilev wrote:
> When jspawnhelper fails for whatever reason, but more prominently due to
> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
> the errors into stdout, but not to the relevant `IOException`. So, if the
> applic
On Fri, 14 Mar 2025 11:47:44 GMT, Joachim Kern wrote:
> The test `testEcoFriendly()` checks if the launcher pollutes the
> `LD_LIBRARY_PATH` environment variable.
> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does not
> make sense to make this test somehow passing with
On Wed, 19 Mar 2025 19:54:41 GMT, Roger Riggs wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java
>
> test/jdk/java/lang/RuntimeTests/ExitLogging-FINE.
On Wed, 19 Mar 2025 20:07:26 GMT, Roger Riggs wrote:
> Out of curiosity, what raised this as an issue that needed more tests? Was
> there a failure of some implementation that caused a bug?
Thank you for your comment.
No, I haven't found any bugs yet.
This is an important feature that is often
On Tue, 18 Mar 2025 12:34:37 GMT, Mikhail Yankelevich
wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java
>
> test/jdk/java/lang/RuntimeTests/RuntimeE
36 matches
Mail list logo
