RFR: 8352437: -XX:+AOTClassLinking is not compatible with --add-export

2025-03-19 Thread Ioi Lam
`-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG). - Before this PR, when `--add-export` is specified, FMG is disabled, so AOT caches created with `-XX:+AOTClassLinking` cannot be loaded. - After this PR, if the exact same `--add-export` flags as specified across the tra

Re: RFR: 8352176: Automate setting up environment for mac signing tests

2025-03-19 Thread Alexander Matveev
On Mon, 17 Mar 2025 19:51:36 GMT, Alexey Semenyuk wrote: > Automate setting up an environment for mac signing tests: create keychain(s), > self-signing certificates, and register them in the system. > > To set up the environment, run `make test-only > TEST=test/jdk/tools/jpackage/macosx/base/S

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v6]

2025-03-19 Thread Per Minborg
On Thu, 13 Mar 2025 15:49:37 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/StableValue.java line 45: >> >>> 43: >>> 44: /** >>> 45: * A stable value is a shallowly immutable holder of deferred content. >> >> Is this terminology a leftover from previous JEP iteratio

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v7]

2025-03-19 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 249 commits: - Fix comments on doc issues - Create separate reentry prevention method and add tests - Merge bran

Re: RFR: 8351996: Behavioral updates for ClassValue::remove [v2]

2025-03-19 Thread Chen Liang
> The recent patch #23866 makes calling `ClassValue::remove()` from > `ClassValue::computeValue()` end up in infinite loops while fixing the stale > value risk from the method. > > The proposed fix is to preserve the stale value risk fix, and update the > remove-from-compute behavior from the o

Re: RFR: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK

2025-03-19 Thread Jiangli Zhou
On Wed, 19 Mar 2025 09:20:33 GMT, Alan Bateman wrote: > can't rule anything in or out right now +1 @AlanBateman @dholmes-ora Does it look reasonable to not run these tests on static JDK for now? - PR Comment: https://git.openjdk.org/jdk/pull/24103#issuecomment-2738148828

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java

2025-03-19 Thread Roger Riggs
On Fri, 14 Mar 2025 09:17:06 GMT, KIRIYAMA Takuya wrote: > The current test program for the logging feature added in JDK-8301627 does > not fully check some important cases. > > Issue Details: > The test does not properly check cases where logging might not happen due to > different logging le

Re: RFR: 8346948: Update CLDR to Version 47.0 [v2]

2025-03-19 Thread Naoto Sato
> Upgrading the CLDR to version 47.0. A corresponding CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Copyright year/bugid update - Changes: - all: https://git.openjdk.org/jdk/pull/24120/files

Integrated: 8351969: Add Public Identifiers to the JDK built-in Catalog

2025-03-19 Thread Joe Wang
On Thu, 13 Mar 2025 19:01:03 GMT, Joe Wang wrote: > Add public identifiers to the JDK built-in Catalog; Replace the incorrect > Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct > Schema 1.0 DTDs. The JDK built-in Catalog contains Schema 1.0 files only. > > DTD files

Re: RFR: 8319447: Improve performance of delayed task handling [v11]

2025-03-19 Thread Dmitry Chuyko
On Fri, 14 Mar 2025 09:36:43 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a >> performance bottleneck (a

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v3]

2025-03-19 Thread Joe Wang
On Wed, 19 Mar 2025 00:43:28 GMT, Joe Wang wrote: >> Add public identifiers to the JDK built-in Catalog; Replace the incorrect >> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct >> Schema 1.0 DTDs. The JDK built-in Catalog contains Schema 1.0 files only. >> >> DTD

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview)

2025-03-19 Thread Maurizio Cimadamore
On Sun, 16 Mar 2025 03:30:46 GMT, John Rose wrote: > This might seem to contradict my previous assertion > that StableValue, being mutex based, must not > use lock-free idioms. That comment applies > specifically to the update operation that takes > a lambda. Other operations, such as reading > a

Re: RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset [v4]

2025-03-19 Thread Jaikiran Pai
On Thu, 13 Mar 2025 19:31:31 GMT, Eirik Bjørsnøs wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add code comment > > test/jdk/java/util/zip/ZipFile/ZipFileSharedSourceTest.java line 78: > >> 76: >> 77: /** >

Re: RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset [v2]

2025-03-19 Thread Jaikiran Pai
On Thu, 13 Mar 2025 11:03:00 GMT, Jaikiran Pai wrote: >> Hello Jaikiran, >> >> I'm not convinced dropping `zipCoderForPos` is a step forward: >> >> * `zipCoderForPos` included a short-circuit optimization logic which skipped >> reading the CENFLG field in the case where the opening charset was

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v25]

2025-03-19 Thread Thomas Schatzl
On Wed, 19 Mar 2025 13:17:19 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that implements (currently Draft) JEP: G1: >> Improve Application Throughput with a More Efficient Write-Barrier. >> >> The reason for posting this early is that this is a large change, and the

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-19 Thread Roger Riggs
On Tue, 18 Mar 2025 18:27:56 GMT, Roger Riggs wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the test: change variables and etc. > > src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/w3c/dtd/schema10/XMLSc

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v3]

2025-03-19 Thread Roger Riggs
On Wed, 19 Mar 2025 00:43:28 GMT, Joe Wang wrote: >> Add public identifiers to the JDK built-in Catalog; Replace the incorrect >> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct >> Schema 1.0 DTDs. The JDK built-in Catalog contains Schema 1.0 files only. >> >> DTD

Re: jpackage and Wix 5

2025-03-19 Thread Alexey Semenyuk
Hi Davide, jpackage should work seamlessly with WiX5. Could you run your jpackage command with `--verbose` arg? It will provide a context for the error. - Alexey On 3/19/2025 6:19 AM, Davide Perini wrote: I add some context: I installed wix 5 using the donet command globally, wix is in the

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-19 Thread Roger Riggs
On Tue, 18 Mar 2025 19:55:39 GMT, Joe Wang wrote: >> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/w3c/dtd/schema10/XMLSchema.dtd >> line 8: >> >>> 6: >>> >>> 7: >>> >>> 8: >>> >> >> The other XML comments use the multi-line format with a single begin

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v25]

2025-03-19 Thread Thomas Schatzl
> Hi all, > > please review this change that implements (currently Draft) JEP: G1: > Improve Application Throughput with a More Efficient Write-Barrier. > > The reason for posting this early is that this is a large change, and the JEP > process is already taking very long with no end in sight

Re: RFR: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK

2025-03-19 Thread Alan Bateman
On Wed, 19 Mar 2025 02:02:56 GMT, Jiangli Zhou wrote: >> Please review this PR that adds `@requires !jdk.static` to tests, thanks. >> >> - runtime/StackGap/TestStackGap.java >> - runtime/StackGuardPages/TestStackGuardPages.java >> - runtime/TLS/TestTLS.java >> - runtime/jni/daemonDestroy/TestDae

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-19 Thread Erik Joelsson
On Wed, 19 Mar 2025 09:11:05 GMT, Alan Bateman wrote: > For the folks targeting embedded/small environments then I think the right > thing is to publish the packaged modules (JMOD files) for the target platform > and then use `jlink` to create the run-image with the right VM + small set of > m

RFR: 8351843: change open/test/jdk/com/sun/net/httpserver/simpleserver/RootDirPermissionsTest.java to a manual test

2025-03-19 Thread serhiysachkov
8351843: change open/test/jdk/com/sun/net/httpserver/simpleserver/RootDirPermissionsTest.java to a manual test - Commit messages: - 8351843:change open/test/jdk/com/sun/net/httpserver/simpleserver/RootDirPermissionsTest.java to a manual test Changes: https://git.openjdk.org/jdk/

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool [v2]

2025-03-19 Thread Dmitry Chuyko
On Tue, 18 Mar 2025 09:11:00 GMT, Dmitry Chuyko wrote: >> Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) >> in one case when TC subfield in ctl field is decremented, the applied >> masking (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. >> In J

Integrated: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

2025-03-19 Thread Dmitry Chuyko
On Thu, 13 Mar 2025 13:34:51 GMT, Dmitry Chuyko wrote: > Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) > in one case when TC subfield in ctl field is decremented, the applied masking > (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. In JDKs >

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool [v2]

2025-03-19 Thread Alan Bateman
On Tue, 18 Mar 2025 09:11:00 GMT, Dmitry Chuyko wrote: >> Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) >> in one case when TC subfield in ctl field is decremented, the applied >> masking (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. >> In J

Re: jpackage and Wix 5

2025-03-19 Thread Davide Perini
I add some context: I installed wix 5 using the donet command globally, wix is in the path but when I try to run my jpackage command I get this error: jpackage -i ./target --type exe --main-class org.dpsoftware.JavaFXStarter --main-jar FireflyLuciferin-jar-with-dependencies.jar --icon ./dat

jpackage and Wix 5

2025-03-19 Thread Davide Perini
Hi there, I'm using jpackage along with Wix3. The command I use to generate my .exe is: jpackage -i ../../target --type exe --main-class org.dpsoftware.JavaFXStarter --main-jar FireflyLuciferin-jar-with-dependencies.jar --icon ../../data/img/java_fast_screen_capture_logo.ico --win

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-19 Thread Alan Bateman
On Tue, 18 Mar 2025 12:31:27 GMT, Magnus Ihse Bursie wrote: > And to be absolutely clear: this PR is just about adding new functionality > that was not present before. Sure but I think it's also an attractive nuisance. The VM is very tightly coupled to java.base and a few other core modules. I

Re: RFR: 8342486: Implement JEP draft: Structured Concurrency (Fifth Preview) [v6]

2025-03-19 Thread Alan Bateman
> Changes for [JEP draft: Structured Concurrency (Fifth > Preview)](https://openjdk.org/jeps/8340343). The JEP isn't on the technical > roadmap yet. The proposal is to re-preview the API with some changes, > specifically: > > - A > [StructuredTaskScope](https://download.java.net/java/early_acc