Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

On Thu, 13 Mar 2025 13:34:51 GMT, Dmitry Chuyko wrote: > Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) > in one case when TC subfield in ctl field is decremented, the applied masking > (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. In JDKs >

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

On Thu, 13 Mar 2025 13:34:51 GMT, Dmitry Chuyko wrote: > Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) > in one case when TC subfield in ctl field is decremented, the applied masking > (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. In JDKs >

Re: Missing offset+length Arrays.hashCode() methods?

Just a comment "en passant", array, List or String in Java tend to use the from/to index convention instead of the offset+length convention which is the convention for system calls (read/write etc). regards, Rémi > From: "Roger Riggs" > To: "core-libs-dev" > Sent: Monday, March 17, 2025 7

Integrated: 8351970: Retire JavaLangAccess::exit

On Fri, 14 Mar 2025 18:31:38 GMT, Roger Riggs wrote: > Cleanup the single use of JavaLangAccess.exit() it is no longer necessary; > System.exit() can be called directly. This pull request has now been integrated. Changeset: 19154f7a Author:Roger Riggs URL: https://git.openjdk.org/j

Re: Missing offset+length Arrays.hashCode() methods?

Hi, It seems like a reasonable API enhancement, the implementation already supports sub-ranges. Created JDK-8352171 Arrays.hashCode for sub-range of byte array API addition Regards, Roger On 1/31/25 6:45 AM, Matthew Swift wrote: Hello experts,

Integrated: 8351372: Improve negative tests coverage of jpackage

On Thu, 6 Mar 2025 23:30:09 GMT, Alexey Semenyuk wrote: > Changes to tests: > - Added more test cases to ErrorTest. > - Added functionality to jpackage test lib to facilitate new ErrorTest test > cases. > - Make all other negative tests use the `CannedFormattedString` class to > validate err

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run [v2]

On Mon, 17 Mar 2025 17:22:10 GMT, Kim Barrett wrote: >> Please review this revision of a previously puzzling comment intending to >> provide the rationale for a bit of non-obvious code. > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run [v2]

> Please review this revision of a previously puzzling comment intending to > provide the rationale for a bit of non-obvious code. Kim Barrett has updated the pull request incrementally with one additional commit since the last revision: bchristi-git review - Changes: - all: ht

Re: RFR: 8352107: Allow jtreg test cases to query test VM properties

On Mon, 17 Mar 2025 10:55:14 GMT, Jaikiran Pai wrote: > > So I think the best solution may be for jtreg to save the properties to a > > location of its choice, and pass this location to the test cases with a > > property like test.vm.properties.file. > > From what I understand of the use case,

Re: RFR: 8352044: Add --with-import-jvms to configure

On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. The discussion on jdk-dev was useful but I don't think adding --with-import-jvms is the right dir

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

On Mon, 17 Mar 2025 13:11:14 GMT, Joachim Kern wrote: >> Thanks Eric, this might help with the command, but my problem is the >> dependency. The rules to generate the export files is not called, because in >> the build output I cannot find any line 'Generating export list for static >> libs'.

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

On Thu, 13 Mar 2025 13:34:51 GMT, Dmitry Chuyko wrote: > Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) > in one case when TC subfield in ctl field is decremented, the applied masking > (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. In JDKs >

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

On Mon, 17 Mar 2025 14:43:05 GMT, Chen Liang wrote: > It seems this is an overflow for the TC part of the flag. The RC part seems > to be able to overflow too, but because it occupies the higher bits its > overflow will never affect the TC. And this is the only site where TC is > masked with `

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

On Mon, 17 Mar 2025 13:14:44 GMT, Erik Joelsson wrote: >> The problem seems to be that `$(generate_export_list)` is empty and I do not >> know why. > > Looks like this variable is misspelled (missing "S"). > > DEPS := $(STATIC_LIB_FILE), \ > > Also note that by default log level INFO is not pr

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

On Thu, 13 Mar 2025 13:34:51 GMT, Dmitry Chuyko wrote: > Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) > in one case when TC subfield in ctl field is decremented, the applied masking > (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. In JDKs >

Re: RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

On Mon, 17 Mar 2025 08:27:20 GMT, Christoph Langer wrote: > Can we maybe add a possibility to store two alternative SHA sums in the JMod > archives, per file? Then we could add SHA sums for both, the stripped and the > full pdb file and either one which is present in the current runtime would b

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

On Mon, 17 Mar 2025 10:02:12 GMT, Joachim Kern wrote: >> make/StaticLibs.gmk line 116: >> >>> 114: #DEPS := $(STATIC_LIB_FILE), \ >>> 115: #OUTPUT_FILE := $(STATIC_LIB_EXPORT_FILES), \ >>> 116: #COMMAND := $(AR) $(ARFLAGS) -w $(patsubst %.exp, %, $@) | $(GREP) >>> -v '^\.' | $(AWK)

Re: RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are > most likely not needed any more and could be removed. > The removal (on Linux) brings the lib optimization level de facto from LOW to > HIGH. Marked as rev

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog

On Fri, 14 Mar 2025 18:35:12 GMT, Joe Wang wrote: > Thanks for review. Updated the test. Thank you! - PR Comment: https://git.openjdk.org/jdk/pull/24039#issuecomment-2729299732

Re: RFR: 8352107: Allow jtreg test cases to query test VM properties

On Sun, 16 Mar 2025 02:54:36 GMT, Ioi Lam wrote: > This is probably not the right thing to do. I agree that this doesn't sound like the right thing to do. This breaks the jtreg -othervm mode. I use the -othervm mode whenever I want to run reproduce a failure in jtreg. In -othervm mode the pwd

Re: RFR: 8352107: Allow jtreg test cases to query test VM properties

On Mon, 17 Mar 2025 08:46:06 GMT, Ioi Lam wrote: > So I think the best solution may be for jtreg to save the properties to a > location of its choice, and pass this location to the test cases with a > property like test.vm.properties.file. >From what I understand of the use case, certain parts

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote: >> @magicus why can't we just use `-pthread` everywhere? My recollection is >> that `-pthread` both sets compiler directives needed for pthread programming >> and links to libpthread, so it seems to be what we should be using. ?? > >> Anothe

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

On Thu, 13 Mar 2025 13:34:51 GMT, Dmitry Chuyko wrote: > Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) > in one case when TC subfield in ctl field is decremented, the applied masking > (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. In JDKs >

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v23]

> Hi all, > > please review this change that implements (currently Draft) JEP: G1: > Improve Application Throughput with a More Efficient Write-Barrier. > > The reason for posting this early is that this is a large change, and the JEP > process is already taking very long with no end in sight

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

On Fri, 14 Mar 2025 17:35:02 GMT, Erik Joelsson wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >>

Re: RFR: 8352044: Add --with-import-jvms to configure

On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. For completeness/reference, this is my JDK frankensteining script that is used for producing buil

Re: RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

On Fri, 14 Mar 2025 12:29:22 GMT, Christoph Langer wrote: > Alternative approach to #24012 > > This keeps the current handling of *.pdb vs *.stripped.pdb which allows > debugging at the cost of a little hack in jlink. Maybe the code in jlink can > be improved, e.g. make it more conditional. >

Re: RFR: 8352107: Allow jtreg test cases to query test VM properties

On Mon, 17 Mar 2025 07:55:00 GMT, Stefan Karlsson wrote: > > This is probably not the right thing to do. > > I agree that this doesn't sound like the right thing to do. This breaks the > jtreg -othervm mode. > > I use the -othervm mode whenever I want to run reproduce a failure in jtreg. > In

Re: RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

On Fri, 14 Mar 2025 14:10:30 GMT, Severin Gehwolf wrote: >> Alternative approach to #24012 >> >> This keeps the current handling of *.pdb vs *.stripped.pdb which allows >> debugging at the cost of a little hack in jlink. Maybe the code in jlink can >> be improved, e.g. make it more conditional

Re: RFR: 8351970: Retire JavaLangAccess::exit

On Fri, 14 Mar 2025 18:31:38 GMT, Roger Riggs wrote: > Cleanup the single use of JavaLangAccess.exit() it is no longer necessary; > System.exit() can be called directly. Marked as reviewed by djelinski (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24066#pullrequestrevi