On Tue, 11 Mar 2025 16:09:37 GMT, Eirik Bjørsnøs wrote:
> > Agreed. I've officially marked this as requiring 2 reviewers.
>
> Did you mean to do `/reviewers 2 reviewer` ?
I didn't know there was a difference, but reading through the skara command
documentation, it appears there is. So I've now
On Tue, 11 Mar 2025 15:32:53 GMT, Eirik Bjørsnøs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tiny typo fix in newly introduced documentation
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 1222:
On Tue, 11 Mar 2025 15:28:59 GMT, Eirik Bjørsnøs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tiny typo fix in newly introduced documentation
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 87:
>
> Can I please get a review of this change which proposes to fix an issue
> `java.util.zip.ZipFile` which would cause failures when multiple instances of
> `ZipFile` using non-UTF8 `Charset` were operating against the same underlying
> ZIP file? This addresses https://bugs.openjdk.org/browse/JDK
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Greg Lew
We have helpful NPE messages now - they are more user-friendly.
And shorter methods are more likely to be inlined.
-
Commit messages:
- [PATCH] Avoid explicit Objects.requireNonNull where we know implicit NPE
will happen
- [PATCH] Avoid explicit Objects.requireNonNull where we know
> JDK-8349989: jlink can use String.replace instead of String.replaceAll
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Address review feedbacks
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23954/files
- new: htt
On Tue, 11 Mar 2025 13:46:52 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1301:
>>
>>> 1299: if ((room == 0 ||// pad if no caller-run
>>> 1300: a[m & (s - ((internal || task == null ||
>>> 1301:
> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>
> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
> both ill-suited for many (if not most) of its applications, and is a
> performance bottleneck (as seen especially in Loom and CompletableFuture
> usages
On Wed, 5 Mar 2025 15:19:27 GMT, Chen Liang wrote:
>> After a call to `ClassValue.remove`, a `ClassValue` can still install a
>> value that is computed with information that is not up-to-date with the
>> remove call. This is demonstrated in the test case, where an innocuous
>> `ClassValue.get`
On Mon, 3 Mar 2025 15:24:05 GMT, Chen Liang wrote:
> After a call to `ClassValue.remove`, a `ClassValue` can still install a value
> that is computed with information that is not up-to-date with the remove
> call. This is demonstrated in the test case, where an innocuous
> `ClassValue.get` cal
On Wed, 5 Mar 2025 15:19:27 GMT, Chen Liang wrote:
>> After a call to `ClassValue.remove`, a `ClassValue` can still install a
>> value that is computed with information that is not up-to-date with the
>> remove call. This is demonstrated in the test case, where an innocuous
>> `ClassValue.get`
On Tue, 14 Jan 2025 07:38:30 GMT, Chen Liang wrote:
> Some AccessFlag parsing methods throw IAE because a flag mask is not valid in
> a location. However, there is no easy way to check what flag mask bits or
> what flags are valid for a location. We need such APIs to check, specific to
> each
On Tue, 11 Feb 2025 02:26:57 GMT, Chen Liang wrote:
> The ClassFile API promotes usage of constant nominal descriptors over literal
> strings. However, for `class` file parsing, currently the efficient way to
> check if a constant pool entry matches a desired descriptor is via unrolling
> them
JDK has been using JLine based Console implementation, in JDK20 as opt-in, then
in JDK22 as the default. While it has been providing rich functionality for
Console, it is increasingly difficult to maintain as a Console implementation.
In light of the on-ramp feature (https://bugs.openjdk.org/bro
On Sun, 9 Mar 2025 17:17:50 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (as
On Mon, 10 Mar 2025 18:06:43 GMT, Roger Riggs wrote:
> Remove misleading/invalid diagnostic output from the JAR manifest test
> ValueUtf8Coding.java.
>
> The Manifest binary stream is not a well formed UTF-8 string due to the
> inserted continuation characters used for lines longer than 70 cha
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Greg Lew
On Tue, 11 Mar 2025 16:27:52 GMT, Henry Jen wrote:
>> JDK-8349989: jlink can use String.replace instead of String.replaceAll
>
> Henry Jen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year
Marked as reviewed by alanb (R
On Thu, 6 Mar 2025 12:38:01 GMT, Jaikiran Pai wrote:
>> We have helpful NPE messages now - they are more user-friendly.
>> And shorter methods are more likely to be inlined.
>
> src/java.base/share/classes/java/lang/String.java line 3649:
>
>> 3647: Iterable elements) {
>> 3648:
On Thu, 6 Mar 2025 13:53:31 GMT, Antonio Vieiro wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by G
On Wed, 5 Feb 2025 15:36:15 GMT, kabutz wrote:
> The LinkedBlockingDeque does not behave consistently with other concurrency
> components. If we call putFirst(), putLast(), takeFirst(), or takeLast() with
> a thread that is interrupted, it does not immediately throw an
> InterruptedException,
On Tue, 4 Mar 2025 19:37:32 GMT, Vladimir Ivanov wrote:
>> test setup was updated to generate data of requested size.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8350811 [JMH] test foreign.StrLenTest failed with
On Sun, 9 Mar 2025 18:11:07 GMT, Chen Liang wrote:
>> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java line 794:
>>
>>> 792: log.format("%-40s %s%n",
>>> 793:"-".repeat(internalApiTitle.length()),
>>> 794:
On Fri, 7 Mar 2025 06:19:03 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of t
On Thu, 5 Dec 2024 18:44:06 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request wit
On Sat, 8 Mar 2025 04:01:41 GMT, Alexander Matveev wrote:
>> Alexey Semenyuk has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix typo
>> - Fix Unicode signing certificate index
>
> test/jdk/tools/jpackage/macosx/base/SigningBase.java
> Changes to tests:
> - Added more test cases to ErrorTest.
> - Added functionality to jpackage test lib to facilitate new ErrorTest test
> cases.
> - Make all other negative tests use the `CannedFormattedString` class to
> validate error messages in jpackage output strictly.
> - Removed redu
On Thu, 6 Mar 2025 23:36:29 GMT, Naoto Sato wrote:
> Clarifying the explanation for `TemporalUnit.between()`. There is already an
> example for the `HOURS` case where the minutes are not enough to make a full
> hour. Explaining how smaller units contribute to determining the whole
> number, al
On Thu, 9 Jan 2025 10:55:16 GMT, Raffaello Giulietti
wrote:
>> See the JBS bug for some details.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The
On Mon, 10 Mar 2025 15:54:56 GMT, Alexey Semenyuk wrote:
>> Changes to tests:
>> - Added more test cases to ErrorTest.
>> - Added functionality to jpackage test lib to facilitate new ErrorTest test
>> cases.
>> - Make all other negative tests use the `CannedFormattedString` class to
>> valid
> JDK-8349989: jlink can use String.replace instead of String.replaceAll
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23954/files
- new: https:
On Tue, 11 Mar 2025 14:37:34 GMT, Jaikiran Pai wrote:
> Agreed. I've officially marked this as requiring 2 reviewers.
Did you mean to do `/reviewers 2 reviewer` ?
-
PR Comment: https://git.openjdk.org/jdk/pull/23986#issuecomment-2714917964
On Tue, 11 Mar 2025 14:46:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
On Tue, 11 Mar 2025 14:23:02 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix an issue
> `java.util.zip.ZipFile` which would cause failures when multiple instances of
> `ZipFile` using non-UTF8 `Charset` were operating against the same underlying
> ZIP
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the work done by Greg Lewis in
> Can I please get a review of this change which proposes to fix an issue
> `java.util.zip.ZipFile` which would cause failures when multiple instances of
> `ZipFile` using non-UTF8 `Charset` were operating against the same underlying
> ZIP file? This addresses https://bugs.openjdk.org/browse/JDK
On Tue, 11 Mar 2025 14:31:48 GMT, Alan Bateman wrote:
> This is going to require careful review. Can you ensure that this has at
> least 2 reviewers?
Agreed. I've officially marked this as requiring 2 reviewers. @LanceAndersen,
@cl4es, I would specially like your reviews for this change, when
On Tue, 11 Mar 2025 14:23:02 GMT, Jaikiran Pai wrote:
> The change that was done in Java 15 was a performance optimization. I have
> verified that the current proposed change in this PR doesn't degrade the
> performance and yet fixes the reported issue.
The `test/micro/org/openjdk/bench/java/u
Can I please get a review of this change which proposes to fix an issue
`java.util.zip.ZipFile` which would cause failures when multiple instances of
`ZipFile` using non-UTF8 `Charset` were operating against the same underlying
ZIP file? This addresses https://bugs.openjdk.org/browse/JDK-8347712
On Mon, 10 Mar 2025 22:08:06 GMT, Henry Jen wrote:
>> JDK-8349989: jlink can use String.replace instead of String.replaceAll
>
> Henry Jen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address review feedbacks
I think this looks okay, I
On Mon, 10 Mar 2025 14:34:42 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Disambiguate caller-runs vs Interruptible
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1301:
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Mon, 10 Mar 2025 19:06:27 GMT, Vladimir Yaroslavskiy
wrote:
>> Hi. I've seen this PR being worked on for a long time. Did you discuss the
>> motivation and objectives for this PR in the relevant mailing list as
>> indicated in the JDK issue? Reviewing this PR seems like a handful and given
On Tue, 11 Mar 2025 03:22:52 GMT, Fei Yang wrote:
> Tier1-3 test good on linux-riscv64 platform. And I have prepared an add-on
> change which implements the barrier method to write cards for a reference
> array for this platform. Do you want to have it in this PR? Thanks.
I added your changes,
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote:
>>> What is the intended way of using this? Do you run make with
>>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the
>>> specific way of linking to pthread?
>>
>> This is in preparation of the upcoming BSD port, which use
46 matches
Mail list logo
