Re: RFR: 8351372: Improve negative tests coverage of jpackage

2025-03-07 Thread Alexander Matveev
On Thu, 6 Mar 2025 23:30:09 GMT, Alexey Semenyuk wrote: > Changes to tests: > - Added more test cases to ErrorTest. > - Added functionality to jpackage test lib to facilitate new ErrorTest test > cases. > - Make all other negative tests use the `CannedFormattedString` class to > validate err

Re: RFR: 8351372: Improve negative tests coverage of jpackage

2025-03-07 Thread Alexey Semenyuk
On Thu, 6 Mar 2025 23:30:09 GMT, Alexey Semenyuk wrote: > Changes to tests: > - Added more test cases to ErrorTest. > - Added functionality to jpackage test lib to facilitate new ErrorTest test > cases. > - Make all other negative tests use the `CannedFormattedString` class to > validate err

RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll

2025-03-07 Thread Henry Jen
JDK-8349989: jlink can use String.replace instead of String.replaceAll - Commit messages: - JDK-8349989: jlink can use String.replace instead of String.replaceAll - JDK-8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll Changes: https://git.openjdk.org/jdk/pu

Re: RFR: 8351372: Improve negative tests coverage of jpackage

2025-03-07 Thread Alexey Semenyuk
On Thu, 6 Mar 2025 23:30:09 GMT, Alexey Semenyuk wrote: > Changes to tests: > - Added more test cases to ErrorTest. > - Added functionality to jpackage test lib to facilitate new ErrorTest test > cases. > - Make all other negative tests use the `CannedFormattedString` class to > validate err

Re: RFR: 8347472: Correct Attribute traversal and writing for Code attributes

2025-03-07 Thread Chen Liang
On Fri, 7 Feb 2025 19:25:04 GMT, Chen Liang wrote: > Make UnknownAttribute and CustomAttribute delivered in code traversal, and > make sure stack maps update the label references after a code transform when > it is reused. Other code-bound attributes are not updated as they cannot be > supplie

Re: RFR: 8351344: Avoid explicit Objects.requireNonNull in String.join

2025-03-07 Thread Raffaello Giulietti
On Thu, 20 Feb 2025 09:30:02 GMT, Andrey Turbanov wrote: > We have helpful NPE messages now - they are more user-friendly. > And shorter methods are more likely to be inlined. At some point we will probably have [null-restricted types](https://openjdk.org/jeps/8303099). Then it will be possibl

RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-07 Thread Kim Barrett
Please review this revision of a previously puzzling comment intending to provide the rationale for a bit of non-obvious code. - Commit messages: - improve comment Changes: https://git.openjdk.org/jdk/pull/23952/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23952&range=00

Re: RFR: 8345687: Improve the implementation of SegmentFactories::allocateSegment [v6]

2025-03-07 Thread Quan Anh Mai
On Fri, 7 Mar 2025 17:38:13 GMT, Quan Anh Mai wrote: >> Hi, >> >> This patch improves the performance of a typical `Arena::allocate` in >> several ways: >> >> - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge >> of the instance with the one obtained from the call in t

Withdrawn: 8316882: Add NOT_INTERRUPTIBLE OpenOption and use it in ZipFS

2025-03-07 Thread duke
On Wed, 25 Dec 2024 23:55:18 GMT, Bruno Ploumhans wrote: > Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882. > > Following discussion in nio-dev a while ago, I have opted to add a new > `NOT_INTERRUPTIBLE` open option, superseding > `FileChannelImpl#setUninterruptible`. This pull

Integrated: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea

2025-03-07 Thread Eric Caspole
On Wed, 5 Mar 2025 15:16:03 GMT, Eric Caspole wrote: > The normal SQE process runs all the repo JMH with -ea to get the last bit of > extra testing. This DremFrem JMH contained some asserts that would always > fire on the correct answer, disturbing this normal SQE process. I removed a > lot mo

Re: Question about IO.println

2025-03-07 Thread Stuart Marks
Hi, Our goal with the IO class is to have it add as few mechanisms as possible. Anything it can do, one should easily be able to do with existing classes like PrintStream or BufferedReader. So, we wouldn't add a varargs method to IO itself without having one in PrintStream or something. Now,

Integrated: 8350909: [JMH] test ThreadOnSpinWaitShared failed for 2 threads config

2025-03-07 Thread Vladimir Ivanov
On Fri, 28 Feb 2025 01:20:44 GMT, Vladimir Ivanov wrote: > The scope was updated to support multithread configuration (jmh option '-t > 2') . No other changes needed. This pull request has now been integrated. Changeset: 4e67ac41 Author:Vladimir Ivanov Committer: Derek White URL:

Re: RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea [v2]

2025-03-07 Thread Chen Liang
On Thu, 6 Mar 2025 19:51:46 GMT, Eric Caspole wrote: >> The normal SQE process runs all the repo JMH with -ea to get the last bit of >> extra testing. This DremFrem JMH contained some asserts that would always >> fire on the correct answer, disturbing this normal SQE process. I removed a >> lo

Integrated: 8350607: Consolidate MethodHandles::zero into MethodHandles::constant

2025-03-07 Thread Chen Liang
On Thu, 20 Feb 2025 02:33:59 GMT, Chen Liang wrote: > LF editor spins classes, this avoids the spinning overhead and should speed > up non-capturing lambdas too. > > There may need to be additional intrinsic work for MH combinator lf bytecode > generation. This pull request has now been integ

Re: RFR: 8350607: Consolidate MethodHandles::zero into MethodHandles::constant [v2]

2025-03-07 Thread Chen Liang
On Mon, 24 Feb 2025 23:45:37 GMT, Chen Liang wrote: >> LF editor spins classes, this avoids the spinning overhead and should speed >> up non-capturing lambdas too. >> >> There may need to be additional intrinsic work for MH combinator lf bytecode >> generation. > > Chen Liang has updated the p

Re: RFR: 8350909: [JMH] test ThreadOnSpinWaitShared failed for 2 threads config

2025-03-07 Thread Derek White
On Fri, 28 Feb 2025 01:20:44 GMT, Vladimir Ivanov wrote: > The scope was updated to support multithread configuration (jmh option '-t > 2') . No other changes needed. Looks good! - Marked as reviewed by drwhite (Committer). PR Review: https://git.openjdk.org/jdk/pull/23834#pullre

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v17]

2025-03-07 Thread Sergey Chernyshev
On Fri, 7 Mar 2025 04:34:24 GMT, David Holmes wrote: >>> OK for me now. `test_cgroupSubsystem_linux.cpp` needs a copyright update as >>> well. >> >> Thanks for your review @jerboaa ! I cheched the >> test_cgroupSubsystem_linux.cpp, it's already updated to 2025 in the master >> branch. > > @se

RFR: 8351372: Improve negative tests coverage of jpackage

2025-03-07 Thread Alexey Semenyuk
Changes to tests: - Added more test cases to ErrorTest. - Added functionality to jpackage test lib to facilitate new ErrorTest test cases. - Make all other negative tests use the `CannedFormattedString` class to validate error messages in jpackage output strictly. - Removed redundant negative

Integrated: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451

2025-03-07 Thread Vladimir Ivanov
On Mon, 3 Mar 2025 20:24:54 GMT, Vladimir Ivanov wrote: > test setup was updated to generate data of requested size. This pull request has now been integrated. Changeset: 7c22b814 Author:Vladimir Ivanov URL: https://git.openjdk.org/jdk/commit/7c22b814d670deda6c2bb93b1e150975c27a165f

Re: RFR: 8345687: Improve the implementation of SegmentFactories::allocateSegment [v6]

2025-03-07 Thread Quan Anh Mai
> Hi, > > This patch improves the performance of a typical `Arena::allocate` in several > ways: > > - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of > the instance with the one obtained from the call in the uncommon path, > increasing the chance the object being sc

Re: RFR: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 [v4]

2025-03-07 Thread Jatin Bhateja
On Fri, 7 Mar 2025 16:13:05 GMT, Vladimir Ivanov wrote: >> test setup was updated to generate data of requested size. > > Vladimir Ivanov has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8350811 [JMH] test foreign.StrLenTest failed with

Re: RFR: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 [v3]

2025-03-07 Thread Vladimir Ivanov
On Fri, 7 Mar 2025 15:51:36 GMT, Vladimir Ivanov wrote: >> test setup was updated to generate data of requested size. > > Vladimir Ivanov has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8350811 [JMH] test foreign.StrLenTest failed with

Re: RFR: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 [v4]

2025-03-07 Thread Vladimir Ivanov
> test setup was updated to generate data of requested size. Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision: JDK-8350811 [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 - Change

Re: RFR: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 [v3]

2025-03-07 Thread Jatin Bhateja
On Fri, 7 Mar 2025 15:51:36 GMT, Vladimir Ivanov wrote: >> test setup was updated to generate data of requested size. > > Vladimir Ivanov has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8350811 [JMH] test foreign.StrLenTest failed with

Re: RFR: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 [v2]

2025-03-07 Thread Vladimir Ivanov
On Fri, 7 Mar 2025 05:59:29 GMT, Jatin Bhateja wrote: >> Vladimir Ivanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8350811 [JMH] test foreign.StrLenTest failed with >> StringIndexOutOfBoundsException for size=451 > > test/micr

Re: RFR: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 [v2]

2025-03-07 Thread Vladimir Ivanov
On Fri, 7 Mar 2025 05:47:59 GMT, Jatin Bhateja wrote: >> Vladimir Ivanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8350811 [JMH] test foreign.StrLenTest failed with >> StringIndexOutOfBoundsException for size=451 > > test/micr

Re: RFR: 8350811: [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 [v3]

2025-03-07 Thread Vladimir Ivanov
> test setup was updated to generate data of requested size. Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision: JDK-8350811 [JMH] test foreign.StrLenTest failed with StringIndexOutOfBoundsException for size=451 - Change

Re: RFR: 8351017: ChronoUnit.MONTHS.between() not giving correct result when date is in February

2025-03-07 Thread Roger Riggs
On Thu, 6 Mar 2025 23:36:29 GMT, Naoto Sato wrote: > Clarifying the explanation for `TemporalUnit.between()`. There is already an > example for the `HOURS` case where the minutes are not enough to make a full > hour. Explaining how smaller units contribute to determining the whole > number, al

Re: RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea [v2]

2025-03-07 Thread Eric Caspole
On Thu, 6 Mar 2025 19:51:46 GMT, Eric Caspole wrote: >> The normal SQE process runs all the repo JMH with -ea to get the last bit of >> extra testing. This DremFrem JMH contained some asserts that would always >> fire on the correct answer, disturbing this normal SQE process. I removed a >> lo

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v12]

2025-03-07 Thread Galder Zamarreño
On Thu, 27 Feb 2025 06:54:30 GMT, Emanuel Peter wrote: > As for possible solutions. In all Regression 1-3 cases, it seems the issue is > scalar cmove. So actually in all cases a possible solution is using branching > code (i.e. `cmp+mov`). So to me, these are the follow-up RFE's: > > * Detect

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v12]

2025-03-07 Thread Emanuel Peter
On Fri, 7 Mar 2025 12:25:51 GMT, Galder Zamarreño wrote: >> @galderz Thanks for the summary of regressions! Yes, there are plenty of >> speedups, I assume primarily because of `Long.min/max` vectorization, but >> possibly also because the operation can now "float" out of a loop for >> example.

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v14]

2025-03-07 Thread Albert Mingkun Yang
On Thu, 6 Mar 2025 16:26:31 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that implements (currently Draft) JEP: G1: >> Improve Application Throughput with a More Efficient Write-Barrier. >> >> The reason for posting this early is that this is a large change, and the

Re: RFR: 8337972: Problem list jdk/internal/util/ReferencedKeyTest.java

2025-03-07 Thread Dalaiyaz21213M
On Wed, 7 Aug 2024 08:33:06 GMT, Doug Simon wrote: > Problem list until [JDK-8336926](https://bugs.openjdk.org/browse/JDK-8336926) > is fixed to reduce the noise in testing. Marked as reviewed by dalaiyaz212...@github.com (no known OpenJDK username). - PR Review: https://git.openj

Re: RFR: 8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized

2025-03-07 Thread SendaoYan
On Thu, 6 Mar 2025 03:35:20 GMT, SendaoYan wrote: > Hi all, > > The return type of function `const __m256i &perm` is `__m256i`, so `const > __m256i &perm` should be replaced as 'const __m256i perm'. > > The function implementation in gcc/clang compiler header: > > 1. gcc: lib/gcc/x86_64-pc-li

Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-07 Thread Magnus Ihse Bursie
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote: >>> What is the intended way of using this? Do you run make with >>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the >>> specific way of linking to pthread? >> >> This is in preparation of the upcoming BSD port, which use

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v14]

2025-03-07 Thread Galder Zamarreño
On Fri, 7 Mar 2025 06:44:57 GMT, Emanuel Peter wrote: >> Galder Zamarreño has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 47 additional >> commi

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v14]

2025-03-07 Thread Emanuel Peter
On Fri, 7 Mar 2025 06:19:03 GMT, Galder Zamarreño wrote: >> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in >> order to help improve vectorization performance. >> >> Currently vectorization does not kick in for loops containing either of >> these calls because of t