On Thu, 6 Mar 2025 02:56:34 GMT, SendaoYan wrote:
>> Hi all,
>>
>> Several JMH tests fails "cannot access class
>> jdk.internal.vm.ContinuationScope (in module java.base) because module
>> java.base does not export jdk.internal.vm to unnamed module". This PR add VM
>> option `--add-exports=ja
On Wed, 5 Mar 2025 16:15:55 GMT, Alan Bateman wrote:
>> Should we remove these JMH tests, or just fix the test bug and make tests
>> run normally
>
>> Should we remove these JMH tests, or just fix the test bug and make tests
>> run normally
>
> I think that would be best as they are left over
On Mon, 24 Feb 2025 05:50:40 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> an intermittent failure in the
> `test/jdk/java/util/zip/ZipFile/TestCleaner.java` test?
>
> This test does operations on Inflater/Deflater/ZipFile and closes
On Mon, 24 Feb 2025 05:50:40 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> an intermittent failure in the
> `test/jdk/java/util/zip/ZipFile/TestCleaner.java` test?
>
> This test does operations on Inflater/Deflater/ZipFile and closes
On Thu, 6 Mar 2025 05:18:26 GMT, Hannes Wallnöfer wrote:
>> Please review an enhancement to make `DocCommentParser` normalize whitespace
>> inside `` elements. The normalization is conceptually simple and and
>> intended to be minimally invasive. Before parsing, `DocCommentParser` checks
>> wh
> Please review an enhancement to make `DocCommentParser` normalize whitespace
> inside `` elements. The normalization is conceptually simple and and
> intended to be minimally invasive. Before parsing, `DocCommentParser` checks
> whether the text is a traditional doc comment and whether every l
Hi all,
The return type of function `const __m256i &perm` is `__m256i`, so `const
__m256i &perm` should be replaced as 'const __m256i perm'.
The function implementation in gcc/clang compiler header:
1. gcc: lib/gcc/x86_64-pc-linux-gnu/14.2.0/include/avxintrin.h
extern __inline __m256i __attri
On Thu, 6 Mar 2025 03:35:20 GMT, SendaoYan wrote:
> Hi all,
>
> The return type of function `const __m256i &perm` is `__m256i`, so `const
> __m256i &perm` should be replaced as 'const __m256i perm'.
>
> The function implementation in gcc/clang compiler header:
>
> 1. gcc: lib/gcc/x86_64-pc-li
On Wed, 5 Mar 2025 21:13:44 GMT, Alexey Semenyuk wrote:
> jpackage app laucnher will expand environment variables in .cfg files.
>
> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
> `$ROOTDIR` tokens with the corresponding path values. With this patch, any
> environme
On Wed, 5 Mar 2025 16:15:55 GMT, Alan Bateman wrote:
> > Should we remove these JMH tests, or just fix the test bug and make tests
> > run normally
>
> I think that would be best as they are left over from early development.
The related test files has been removed in this PR.
-
P
> Hi all,
>
> Several JMH tests fails "cannot access class
> jdk.internal.vm.ContinuationScope (in module java.base) because module
> java.base does not export jdk.internal.vm to unnamed module". This PR add VM
> option `--add-exports=java.base/jdk.internal.vm=ALL-UNNAMED` to fix the JMH
> tes
On Wed, 5 Mar 2025 21:13:44 GMT, Alexey Semenyuk wrote:
> jpackage app laucnher will expand environment variables in .cfg files.
>
> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
> `$ROOTDIR` tokens with the corresponding path values. With this patch, any
> environme
jpackage app laucnher will expand environment variables in .cfg files.
Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
`$ROOTDIR` tokens with the corresponding path values. With this patch, any
environment variable can be expanded. The syntax is shell-like `$ENV_VAR_NAME
On Wed, 8 Jan 2025 09:04:47 GMT, Nicole Xu wrote:
> Suite `MaskedLogicOpts.maskedLogicOperationsLong512()` failed on both x86 and
> AArch64 with the following error:
>
>
> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>
>
> The variable `long256_arr_idx` is misu
On Thu, 27 Feb 2025 01:55:59 GMT, Xiaohong Gong wrote:
>> Nicole Xu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to
>> IndexOutOfBoundsException
>>
>>Suite Maske
On Wed, 26 Feb 2025 07:04:58 GMT, Nicole Xu wrote:
>> Suite `MaskedLogicOpts.maskedLogicOperationsLong512()` failed on both x86
>> and AArch64 with the following error:
>>
>>
>> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>>
>>
>> The variable `long256_arr_idx
On Wed, 5 Mar 2025 21:13:44 GMT, Alexey Semenyuk wrote:
> jpackage app laucnher will expand environment variables in .cfg files.
>
> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
> `$ROOTDIR` tokens with the corresponding path values. With this patch, any
> environme
On Thu, 6 Mar 2025 00:39:59 GMT, Vladimir Ivanov wrote:
>> test/micro/org/openjdk/bench/java/lang/foreign/StrLenTest.java line 149:
>>
>>> 147: while (lorem.length() < size) {
>>> 148: lorem += lorem;
>>> 149: }
>>
>> This is matter of taste, but I would prefer Strin
On Tue, 4 Mar 2025 19:37:32 GMT, Vladimir Ivanov wrote:
>> test setup was updated to generate data of requested size.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8350811 [JMH] test foreign.StrLenTest failed with
On Wed, 5 Mar 2025 23:29:42 GMT, Volodymyr Paprotski
wrote:
>> Vladimir Ivanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8350811 [JMH] test foreign.StrLenTest failed with
>> StringIndexOutOfBoundsException for size=451
>
> te
On Wed, 5 Mar 2025 15:16:03 GMT, Eric Caspole wrote:
> The normal SQE process runs all the repo JMH with -ea to get the last bit of
> extra testing. This DremFrem JMH contained some asserts that would always
> fire on the correct answer, disturbing this normal SQE process. I removed a
> lot mo
On Tue, 4 Mar 2025 19:37:32 GMT, Vladimir Ivanov wrote:
>> test setup was updated to generate data of requested size.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8350811 [JMH] test foreign.StrLenTest failed with
On Wed, 5 Mar 2025 15:13:06 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reduce volatile reads
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3741:
>
>> 3739: publ
On Mon, 3 Mar 2025 16:41:18 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to make `DocCommentParser` normalize whitespace
> inside `` elements. The normalization is conceptually simple and and
> intended to be minimally invasive. Before parsing, `DocCommentParser` checks
> whethe
On Tue, 25 Feb 2025 22:08:33 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java line 2241:
>>
>>> 2239: var form = constantForm(basicType);
>>> 2240:
>>> 2241: if (type.isPrimitive()) {
>>
>> I think you could simplify this using `Wrapp
On Mon, 24 Feb 2025 23:45:37 GMT, Chen Liang wrote:
>> LF editor spins classes, this avoids the spinning overhead and should speed
>> up non-capturing lambdas too.
>>
>> There may need to be additional intrinsic work for MH combinator lf bytecode
>> generation.
>
> Chen Liang has updated the p
On Tue, 4 Mar 2025 01:37:57 GMT, Justin Lu wrote:
> Please review this PR and associated CSR which disallows passing null to 4
> `DecimalFormat` prefix/suffix setter methods.
>
> Currently these setters do not check the input String for null. When the
> prefix/suffix is null, any such DecimalF
On Mon, 3 Mar 2025 16:41:18 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to make `DocCommentParser` normalize whitespace
> inside `` elements. The normalization is conceptually simple and and
> intended to be minimally invasive. Before parsing, `DocCommentParser` checks
> whethe
On Tue, 4 Mar 2025 20:36:02 GMT, John R Rose wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> We no longer load DelegateMH as we no longer rebind
>
> src/java.base/share/classes/java/lang/invoke/SimpleMethodHandle.jav
On Sat, 2 Nov 2024 15:40:30 GMT, Archie Cobbs wrote:
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
This pull request has now been integrated.
Changeset: 661bd5bf
Author:Archie Cobbs
URL:
https://git.openjdk.org/jdk/commit/661bd5bfe883a7449c
On Wed, 5 Mar 2025 15:16:03 GMT, Eric Caspole wrote:
> The normal SQE process runs all the repo JMH with -ea to get the last bit of
> extra testing. This DremFrem JMH contained some asserts that would always
> fire on the correct answer, disturbing this normal SQE process. I removed a
> lot mo
On Tue, 4 Mar 2025 15:33:16 GMT, SendaoYan wrote:
> Should we remove these JMH tests, or just fix the test bug and make tests run
> normally
I think that would be best as they are left over from early development.
-
PR Comment: https://git.openjdk.org/jdk/pull/23437#issuecomment-2
The normal SQE process runs all the repo JMH with -ea to get the last bit of
extra testing. This DremFrem JMH contained some asserts that would always fire
on the correct answer, disturbing this normal SQE process. I removed a lot more
asserts from this JMH which seemed to make it more of a SQE
> After a call to `ClassValue.remove`, a `ClassValue` can still install a value
> that is computed with information that is not up-to-date with the remove
> call. This is demonstrated in the test case, where an innocuous
> `ClassValue.get` call on an uncomputed CV may happen to compute during wh
On Tue, 4 Mar 2025 19:17:57 GMT, John R Rose wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits si
On Sat, 1 Mar 2025 15:43:17 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (as
> The Type and AnnotatedType hierarchies have been enigmatic to new users:
> users have no clue how to categorize arbitrary type objects, when it is safe
> to cast to more specific types, and the exact conditions for method contracts.
>
> A manifest is [JDK-8306039](https://bugs.openjdk.org/brow
On Mon, 3 Mar 2025 15:24:05 GMT, Chen Liang wrote:
> After a call to `ClassValue.remove`, a `ClassValue` can still install a value
> that is computed with information that is not up-to-date with the remove
> call. This is demonstrated in the test case, where an innocuous
> `ClassValue.get` cal
Hi Joe,
Thanks for your mail, and interest about what Apache Xalan-J team
has been able to do up to now with respect to XSLT 3.0 language
implementation.
On Tue, Mar 4, 2025 at 10:24 AM Joe Wang wrote:
> Great work. Are the tests counted differently?
Apache Xalan-J's XSLT 3.0 & XPath 3.1 test
On Tue, 4 Mar 2025 01:47:40 GMT, Justin Lu wrote:
>> Please review this PR and associated CSR which disallows passing null to 4
>> `DecimalFormat` prefix/suffix setter methods.
>>
>> Currently these setters do not check the input String for null. When the
>> prefix/suffix is null, any such Dec
On Tue, 4 Mar 2025 17:20:28 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Wed, 5 Mar 2025 09:45:00 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Thu, 31 Oct 2024 15:00:25 GMT, Sergey Chernyshev
wrote:
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
44 matches
Mail list logo
