Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v3]

2025-03-01 Thread kerr
> Motivation: > When a user passes a wrong parameter, the current implementation throws an > IllegalArgumentException with an error message `null`, which is not helpful. > > Modification: > Add detail error messages. > > Result: > Helpful messages. He-Pin(kerr) has updated the pull request incr

Re: adding Xalan's XSL 3 implementation within jdk

2025-03-01 Thread Mukul Gandhi
Hi Joe, Thanks for nice thoughts. On Fri, 28 Feb, 2025, 00:06 Joe Wang, wrote: > What's your assessment on the readiness for a formal release (or how > much additional work is needed)? What are the conformance test results? > The link here, https://github.com/apache/xalan-java/tree/xalan-j_

Re: adding Xalan's XSL 3 implementation within jdk

2025-03-01 Thread Mukul Gandhi
Hi Alan, Thanks for your reply. On Thu, 27 Feb, 2025, 13:41 Alan Bateman, wrote: > If you are interested in contributing to the XML implementations in the > java.xml module then this would be welcomed. It's always better to start > small with bug fixes, test improvements and other changes to

Re: RFR: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method [v10]

2025-03-01 Thread Jason Mehrens
On Fri, 28 Feb 2025 12:29:04 GMT, David Beaumont wrote: >The former is, in my opinion, a pretty awful user experience... Specifically, I'm referring to this, with awareness of the above described limitations: //String.format is var-arg logger.log(Level.SEVERE, () -> { return String.format("foo

Re: RFR: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method [v10]

2025-03-01 Thread Jason Mehrens
On Fri, 28 Feb 2025 14:23:49 GMT, David Beaumont wrote: >> 8349206: j.u.l.Handler classes create deadlock risk via synchronized >> publish() method. >> >> 1. Remove synchronization of calls to publish() in Handlers in >> java.util.logging package. >> 2. Add explanatory comments to various affe

Re: RFR: 8319447: Improve performance of delayed task handling [v6]

2025-03-01 Thread Doug Lea
> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) > > The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is > both ill-suited for many (if not most) of its applications, and is a > performance bottleneck (as seen especially in Loom and CompletableFuture > usages

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA

2025-03-01 Thread Joe Wang
On Fri, 28 Feb 2025 22:33:14 GMT, Naoto Sato wrote: >> Fix handleCharacters by adding a guard to zero length and letting the rest >> of the process continue (e.g. closing tags and etc). > > src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXStream2SAX.java > line 286: >

Re: RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources [v3]

2025-03-01 Thread Jaikiran Pai
> Can I please get a review of this doc-only change which proposes to improve > the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`, > `InflaterInputStream` and `InflaterOutputStream` classes? > > As noted in https://bugs.openjdk.org/browse/JDK-8066583 some of the > construct

Re: RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources [v3]

2025-03-01 Thread Jaikiran Pai
On Sat, 1 Mar 2025 07:50:44 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which proposes to improve >> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`, >> `InflaterInputStream` and `InflaterOutputStream` classes? >> >> As noted in https://