> On Feb 27, 2025, at 11:43 AM, Alexey Semenyuk
> wrote:
>
> Thank you for trying it out! I'll look closer at the issues you reported and
> get back to you.
I put something up on my trying it out if helpful when you get a chance to look
at it.
MacOS system JRE in JavaVirtualMachines with j
On Fri, 28 Feb 2025 23:02:28 GMT, Naoto Sato wrote:
>> Hi Naoto,
>>
>> Yes, I did look through that code and bug 5046319. Unfortunately, it
>> happened when JAXP was standalone, the history of the change was lost.
>> The variable "buf" seems to be an instance variable that serves to cache the
> Fix handleCharacters by adding a guard to zero length and letting the rest of
> the process continue (e.g. closing tags and etc).
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
remove commented section
-
Changes:
- all
On Fri, 21 Feb 2025 00:01:36 GMT, Chen Liang wrote:
> Simplify the layout access var handles to be direct in some common cases.
> Also made `VarHandle::isAccessModeSupported` report if an access mode is
> supported for a VH.
>
> Reduces the instructions to execute this code in a simple main by
On Sat, 1 Mar 2025 00:40:26 GMT, Sandhya Viswanathan
wrote:
>> Array initialization by parameter was added. Extra constant was used to
>> align cycle step with used arrays.
>
> test/micro/org/openjdk/bench/jdk/incubator/vector/IndexInRangeBenchmark.java
> line 51:
>
>> 49: @Setup(Level.Tr
On Tue, 25 Feb 2025 19:06:05 GMT, Vladimir Ivanov wrote:
> Array initialization by parameter was added. Extra constant was used to align
> cycle step with used arrays.
test/micro/org/openjdk/bench/jdk/incubator/vector/IndexInRangeBenchmark.java
line 51:
> 49: @Setup(Level.Trial)
> 50:
On Fri, 28 Feb 2025 22:36:32 GMT, Alexey Semenyuk wrote:
>> Add a test to verify jpackage is using a custom MSI condition blocking
>> package installation depending on the version of Windows where the package
>> installer runs. Support for this MSI condition was added in
>> [JDK-8150442](https
On Thu, 27 Feb 2025 19:43:34 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to
> a merge o
On Fri, 28 Feb 2025 22:56:27 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXStream2SAX.java
>> line 286:
>>
>>> 284: if (textLength > 0) {
>>> 285: staxStreamReader.getTextCharacters(0, chars, 0,
>>> textLength);
>>> 286:
> Add a test to verify jpackage is using a custom MSI condition blocking
> package installation depending on the version of Windows where the package
> installer runs. Support for this MSI condition was added in
> [JDK-8150442](https://bugs.openjdk.org/browse/JDK-8150442).
>
> The test adds an
On Fri, 28 Feb 2025 17:42:24 GMT, Joe Wang wrote:
> Fix handleCharacters by adding a guard to zero length and letting the rest of
> the process continue (e.g. closing tags and etc).
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXStream2SAX.java
line 286:
> 284:
On Fri, 28 Feb 2025 15:57:18 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Tue, 25 Feb 2025 19:06:05 GMT, Vladimir Ivanov wrote:
> Array initialization by parameter was added. Extra constant was used to align
> cycle step with used arrays.
Marked as reviewed by drwhite (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/23783#pullrequestreview-
On Fri, 28 Feb 2025 17:08:19 GMT, Severin Gehwolf wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated comment
>
> src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1SubsystemController.java
On Fri, 28 Feb 2025 12:27:13 GMT, Matthias Baesken wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated comment
>
> test/jdk/jdk/internal/platform/cgroup/CgroupV1SubsystemControllerTest.java
> line 69:
>
On Fri, 28 Feb 2025 17:07:59 GMT, Severin Gehwolf wrote:
>> src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2020, 2024, Red Hat Inc.
>>
>> Guess this must be 2025 now ? Same for other files ...
>
> yes indeed.
indeed, updated the copyright headers.
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Thu, 27 Feb 2025 02:53:26 GMT, Alexander Matveev
wrote:
> - Fixed by increasing test timeout. Fix verified on host which reproduced
> issue.
This pull request has now been integrated.
Changeset: a87dd1a7
Author:Alexander Matveev
URL:
https://git.openjdk.org/jdk/commit/a87dd1a75
On Tue, 25 Feb 2025 23:58:21 GMT, Justin Lu wrote:
> Please review this PR which prevents an `AIOOBE` from leaking out when
> `java.util.Calendar.Builder` is used to build a Japanese calendar with an era
> value too large.
>
> Note that we don't check under `BEFORE_MEIJI`/0 as historically Jap
On Fri, 28 Feb 2025 14:23:49 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affe
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Thu, 27 Feb 2025 19:52:13 GMT, Justin Lu wrote:
>> Please review this PR which clarifies some behavior regarding NumberFormat
>> grouping specifically in the grouping related methods.
>>
>> Please see the corresponding CSR for further detail. Note that an
>> alternative would be to specify
Fix handleCharacters by adding a guard to zero length and letting the rest of
the process continue (e.g. closing tags and etc).
-
Commit messages:
- 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA
Changes: https://git.openjdk.org/jdk/pull/23847/files
Webrev: https
On Fri, 28 Feb 2025 14:23:49 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affe
On Wed, 26 Feb 2025 00:52:41 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Fri, 28 Feb 2025 12:19:53 GMT, Matthias Baesken wrote:
>> Sergey Chernyshev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated comment
>
> src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 2:
>
>> 1: /*
>> 2: * Copyright (c
On Fri, 28 Feb 2025 15:57:18 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Fri, 28 Feb 2025 15:57:18 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
> Simplify the layout access var handles to be direct in some common cases.
> Also made `VarHandle::isAccessModeSupported` report if an access mode is
> supported for a VH.
>
> Reduces the instructions to execute this code in a simple main by 47%:
>
> long[] arr = new long[8];
> var ms = Memory
On Fri, 28 Feb 2025 10:37:17 GMT, Maurizio Cimadamore
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> noStride -> constantOffset, optimize VH classes to have only 2 instead of
>> 3 classes for each type
>
> src/jav
> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>
> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
> both ill-suited for many (if not most) of its applications, and is a
> performance bottleneck (as seen especially in Loom and CompletableFuture
> usages
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected methods.
> 3. Add a test to ensure deadlocks no longer occu
On Tue, 25 Feb 2025 01:19:14 GMT, Stuart Marks wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweaking @implNote for better rendering.
>
> src/java.logging/share/classes/java/util/logging/StreamHandler.java line
On Fri, 28 Feb 2025 09:28:29 GMT, Daniel Fuchs wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix @implNote to @apiNote.
>
> src/java.logging/share/classes/java/util/logging/StreamHandler.java line 240:
>
>> 23
On Fri, 28 Feb 2025 01:00:49 GMT, Stuart Marks wrote:
>> src/java.logging/share/classes/java/util/logging/StreamHandler.java line 184:
>>
>>> 182: *
>>> 183: * @param record description of the log event. A null record is
>>> 184: * silently ignored and is not pub
On Thu, 27 Feb 2025 10:19:51 GMT, Matthias Baesken wrote:
>> While testing a bit with a minimal JVM, it has been noticed that some
>> java/lang jtreg tests use jfr but do not declare it with a "requires
>> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
>
> Matthias Baesken
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Fri, 28 Feb 2025 10:21:27 GMT, Maurizio Cimadamore
wrote:
>> Maybe something like `isOffsetFixed` or `hasFixedOffset` would be better?
>
> (I suggested renaming to something that didn't contain the term "offset" --
> it's a subjective thing and if I'm in the minority that's ok. Maybe
> `noI
On Fri, 28 Feb 2025 10:38:28 GMT, Maurizio Cimadamore
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> noStride -> constantOffset, optimize VH classes to have only 2 instead of
>> 3 classes for each type
>
> src/jav
> As we advance, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a `MemorySegment` to capture potential error states. This can lead
> to negative performance implications if not designed carefully
On Fri, 28 Feb 2025 01:09:21 GMT, Stuart Marks wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix @implNote to @apiNote.
>
> src/java.logging/share/classes/java/util/logging/StreamHandler.java line 288:
>
>> 28
On Thu, 27 Feb 2025 14:17:27 GMT, Jorn Vernee wrote:
>> Well, the reason I removed the eager init is that their creation in clinit
>> is super costly. Also I think one pair of getter + creator is better than 3
>> pairs.
>
>> ... their creation in clinit is super costly
>
> You mean because th
On Tue, 25 Feb 2025 11:35:18 GMT, David Beaumont wrote:
>> src/java.logging/share/classes/java/util/logging/Formatter.java line 94:
>>
>>> 92: * important to avoid making callbacks to unknown user-provided
>>> arguments
>>> 93: * (e.g. log record parameters captured from previous call
On Thu, 27 Feb 2025 14:07:17 GMT, Jason Mehrens wrote:
>> Need to update to have single call to getFormatter().
>
>>Keeping an unformatted log record around for any time after the log statement
>>that created it has exited would be quite problematic (it prevents GC of
>>arbitrary things).
>
>
On Wed, 26 Feb 2025 00:52:41 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Wed, 26 Feb 2025 00:52:41 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Thu, 27 Feb 2025 18:31:16 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * remove unnecessarily added logging
>
> src/hotspot/share/gc/g1/g1RemSet.cpp line 1252:
>
>> 1250: G1Con
On Fri, 28 Feb 2025 10:29:46 GMT, Maurizio Cimadamore
wrote:
> I have observed the same thing -- these helper method handles lead to some
> bytecode spinning
Although - that was before; in the new code these helpers don't do
adaptation... so it should be ok. (I also see the code has been upda
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Thu, 27 Feb 2025 12:07:29 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * remove unnecessarily added logging
>
> src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp line 349:
>
>> 347:
On Thu, 27 Feb 2025 16:00:47 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Tue, 25 Feb 2025 14:39:23 GMT, Magnus Ihse Bursie wrote:
>> Left a space and an extra note to make the comment hash more obvious.
>
> Unless you plan to shortly push a new PR where you either enable this
> functionality, or remove the commented-out lines, I strongly prefer *not* to
> have co
On Tue, 25 Feb 2025 09:51:08 GMT, Maurizio Cimadamore
wrote:
>> Benchmark results for the latest revision appears performance neutral.
>> bytestacks same as last revision. 11 jobs left in tier 1-3, no failure so
>> far. Also created CSR for this minor behavioral change.
>>
>> Benchmark
On Thu, 27 Feb 2025 18:24:15 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * remove unnecessarily added logging
>
> src/hotspot/share/gc/g1/g1BarrierSet.hpp line 54:
>
>> 52: // them,
On Thu, 27 Feb 2025 14:21:17 GMT, Jorn Vernee wrote:
>> In last revision I called it `fixedOffset`, but it becomes confusing with
>> the actual fixed value of the offset.
>
> Maybe something like `isOffsetFixed` or `hasFixedOffset` would be better?
(I suggested renaming to something that didn't
On Thu, 27 Feb 2025 10:19:51 GMT, Matthias Baesken wrote:
>> While testing a bit with a minimal JVM, it has been noticed that some
>> java/lang jtreg tests use jfr but do not declare it with a "requires
>> vm.hasJFR" ; that leads to test errors in a JVM setup with no JFR .
>
> Matthias Baesken
On Fri, 28 Feb 2025 07:22:24 GMT, Alan Bateman wrote:
> In this case it's a JDK-specific module
Okay but is there a transitive dependency from the public module that has to be
present to the internal module?
That said ... we are building a minimal VM we are not building Compact
Profiles. I do
On Thu, 27 Feb 2025 17:15:56 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affe
On Fri, 28 Feb 2025 00:59:22 GMT, Stuart Marks wrote:
>> src/java.logging/share/classes/java/util/logging/SocketHandler.java line 178:
>>
>>> 176: // JDK-8349206: Do NOT synchronize around the parent's
>>> publish() method.
>>> 177: super.publish(record);
>>> 178: flush(
59 matches
Mail list logo
