Integrated: 8349653: Clarify the docs for MemorySegment::reinterpret

2025-02-23 Thread Per Minborg
On Wed, 19 Feb 2025 09:14:03 GMT, Per Minborg wrote: > This PR proposes to clarify the documentation for two of the > `MemorySegment::reinterpret` overloads. This pull request has now been integrated. Changeset: f755fadc Author:Per Minborg URL: https://git.openjdk.org/jdk/commit/f7

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v13]

2025-02-23 Thread Alan Bateman
On Mon, 24 Feb 2025 06:10:39 GMT, Kim Barrett wrote: > And here is a bug and recently opened PR that would benefit from having > Cleaner.waitForCleaning. If you are suggesting exposing this as a public API then I don't think we should do this, I actually think it's time to consider deprecatin

Re: RFR: 8204868: java/util/zip/ZipFile/TestCleaner.java still fails with "cleaner failed to clean zipfile."

2025-02-23 Thread Kim Barrett
On Mon, 24 Feb 2025 05:50:40 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which proposes to address > an intermittent failure in the > `test/jdk/java/util/zip/ZipFile/TestCleaner.java` test? > > This test does operations on Inflater/Deflater/ZipFile and closes

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v13]

2025-02-23 Thread Kim Barrett
On Tue, 18 Feb 2025 14:33:16 GMT, Aleksey Shipilev wrote: >> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` >> implementation. That implementation carries a doubly-linked list, and so >> makes DBB suffer from the same issue fixed for generic >> `java.lang.ref.Cleaner` users w

RFR: 8204868: java/util/zip/ZipFile/TestCleaner.java still fails with "cleaner failed to clean zipfile."

2025-02-23 Thread Jaikiran Pai
Can I please get a review of this test-only change which proposes to address an intermittent failure in the `test/jdk/java/util/zip/ZipFile/TestCleaner.java` test? This test does operations on Inflater/Deflater/ZipFile and closes those instances and then waits for GC to kick in. After wait for

Re: RFR: 8349545: ClassLoader.definePackage() throws IllegalArgumentException if package already defined

2025-02-23 Thread Alan Bateman
On Sun, 23 Feb 2025 11:32:41 GMT, Robert Stupp wrote: > Concurent calls to `ClassLoader.definePackage()` can yield > `IllegalArgumentException`s if the package is already defined. Some built-in > class loaders, like `URLClassLoader`, already handle this case, but custom > class loaders (would)

Re: RFR: 8319447: Improve performance of delayed task handling [v3]

2025-02-23 Thread Doug Lea
On Sat, 22 Feb 2025 14:30:11 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a >> performance bottleneck (a

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-23 Thread Doug Lea
> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) > > The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is > both ill-suited for many (if not most) of its applications, and is a > performance bottleneck (as seen especially in Loom and CompletableFuture > usages

Re: RFR: 8349545: ClassLoader.definePackage() throws IllegalArgumentException if package already defined

2025-02-23 Thread Robert Stupp
On Sun, 23 Feb 2025 11:32:41 GMT, Robert Stupp wrote: > Concurent calls to `ClassLoader.definePackage()` can yield > `IllegalArgumentException`s if the package is already defined. Some built-in > class loaders, like `URLClassLoader`, already handle this case, but custom > class loaders (would)

RFR: 8349545: ClassLoader.definePackage() throws IllegalArgumentException if package already defined

2025-02-23 Thread Robert Stupp
Concurent calls to `ClassLoader.definePackage()` can yield `IllegalArgumentException`s if the package is already defined. Some built-in class loaders, like `URLClassLoader`, already handle this case, but custom class loaders (would) have to handle this case. This change updates the logic of `CL

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v13]

2025-02-23 Thread Kim Barrett
On Tue, 18 Feb 2025 14:33:16 GMT, Aleksey Shipilev wrote: >> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` >> implementation. That implementation carries a doubly-linked list, and so >> makes DBB suffer from the same issue fixed for generic >> `java.lang.ref.Cleaner` users w